Skip to content
Snippets Groups Projects
  1. Dec 28, 2012
    • Iustin Pop's avatar
      Fix a bad data type in Hcheck.hs · f6b9c6e5
      Iustin Pop authored
      
      While trying to understand why some code was not being tested, I
      realised that we have a bad data type in Hcheck.hs.
      
      We have "data Level = GroupLvl | ClusterLvl", but then we need to pass
      the group name/index as well, so we have functions that look like the
      following:
      
        f :: Level -> Maybe String -> …
        f GroupLvl (Just gname) = …
        f GroupLvl Nothing = … -- never used
        f ClusterLvl _ = … -- wrong, since a (Just x) could be passed
      
      It's clear that we just need to move the group name in the "GroupLvl"
      constructor, and simplify the call chain.
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      f6b9c6e5
    • Iustin Pop's avatar
      Move src/Ganeti/HTools/Program.hs to Program/Main.hs · 2fd5a116
      Iustin Pop authored
      
      This removes one more tab conflict; this is the last module in our
      code where we have both x.hs and x/.
      
      Furthermore, we collapse all actual code into the new Main.hs module,
      leaving the htools.hs basically empty (will allow better testing in
      the future).
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      2fd5a116
  2. Dec 27, 2012
  3. Dec 24, 2012
  4. Dec 22, 2012
  5. Dec 21, 2012
Loading