1. 14 Jun, 2010 2 commits
    • Iustin Pop's avatar
      Fix a bug in instance startup with custom hvparams · c47478f9
      Iustin Pop authored
      
      
      Since the introduction of OS-specific hvparams, we shouldn't ever use
      objects.FillDict directly for instances, but instead go via the cluster
      object. Otherwise the os_hvp will be ignored.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      c47478f9
    • Iustin Pop's avatar
      Fix unsafe variant initializer in _TryOSFromDisk · 845da3e8
      Iustin Pop authored
      
      
      In case an OS has inconsistent declarations, we might get into a case
      where one node reports a valid variants list (with OS API >=15), and
      another node has OS API < 15, in which case its supported_variants gets
      the default value of None. This leads to the same variable having
      inconsistent data types, which leads to subtle bugs later: instead of
      reporting something like "Inconsistent OS API versions", the LU exits
      with a run-time exception. Furthermore, in another datapath, variants is
      initialized to '[]' in case of OS diagnose failures.
      
      The patch changes _TryOSFromDisk to initialize variants to '[]' for
      OS api level below 15, and changes the variants calculation in
      DiagnoseOS to be more readable.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      845da3e8
  2. 13 Jun, 2010 1 commit
  3. 11 Jun, 2010 2 commits
  4. 10 Jun, 2010 1 commit
  5. 04 Jun, 2010 5 commits
  6. 03 Jun, 2010 1 commit
  7. 02 Jun, 2010 6 commits
  8. 01 Jun, 2010 12 commits
  9. 31 May, 2010 3 commits
  10. 27 May, 2010 1 commit
  11. 25 May, 2010 5 commits
  12. 24 May, 2010 1 commit
    • Guido Trotter's avatar
      TestSingleFileEventHandler: abstract notifier type · 49f986e7
      Guido Trotter authored
      
      
      Rather than hardcode that we have two notifiers, and notifier 0 is the
      terminating one, we abstract this with class level constants. This makes
      it easier to add more, with different features.
      
      The only real change is that now the callback class takes as input the
      whole test object, rather than just the notified array, to have access
      to those constants.
      
      The rest is just replacing of hardcoded 0s and 1s with
      self.NOTIFIER_TERM and self.NOTIFIER_NORM, and of notifier_count with
      len(self.NOTIFIERS).
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarBalazs Lecz <leczb@google.com>
      49f986e7