1. 23 Mar, 2010 6 commits
    • Guido Trotter's avatar
      Fix burnin error when trying to grow a file volume · 728489a3
      Guido Trotter authored
      
      
      Abstract the growable disk types in a ganeti constants, and only run
      disk grow, from burnin, on them.
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      728489a3
    • Iustin Pop's avatar
      Some epydoc fixes · 3a488770
      Iustin Pop authored
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      3a488770
    • Iustin Pop's avatar
      A rewrite of LUClusterVerify · 02c521e4
      Iustin Pop authored
      
      
      Per issue 90, current cluster verify is very very brittle. It's one of
      the oldest pieces of code, with only additions without cleanups over the
      last years.
      
      Among its problems:
      
      - data initialization interspersed with verification of RPC results,
        leading to non-initialized data for some branches
      - due to the above, we order strictly some checks and we have the case
        where a bad node time result will skip checking of node volumes
      - many many local variables, with each new check adding a new dict,
        leading to a spaghetti of dicts in the main Exec function
      - monolithic code, both Exec() and _NodeVerify() do a lot of
        independent checks
      
      This patch does an imperfect rewrite, but at least we gain:
      
      - a clear infrastructure for adding more checks (the new NodeImage
        class, with it's clear and documented fields), and removal of most
        per-node dicts from the Exec() function
      - the new NodeImage object should allow better type safety, e.g. by
        allowing pylint to check the actual object attributes rather than
        strings as dict keys
      - a-priori initialization of data fields, eliminating the need to
        introduce dependencies between checks
      - per-result-key status field, allowing elimination of duplicate error
        messages (where we want)
      - split of most independent checks into separate functions, for greater
        clarity
      
      The new code, being new will probably introduce for the short term more
      bugs than it removes. However, it should offer a much better way for
      extending cluster verify in the future.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      02c521e4
    • Iustin Pop's avatar
      Introduce a bool CLI option type · e7b61bb0
      Iustin Pop authored
      
      
      This option type enforces its value to either True or False, relieving
      the scripts from manually parsing the values in each function.
      
      We also update the bash completion code to use the option type if
      possible.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      e7b61bb0
    • Iustin Pop's avatar
      Fix backend.VerifyNode behaviour for VG problems · ed904904
      Iustin Pop authored
      
      
      In case LVM is broken, backend.GetVolumeList will raise an RPC exception
      (as expected since it's a function exposed over RPC). Therefore we must
      be prepared to catch any such exceptions, so that we don't fail the
      whole verify call in this case. cmdlib is already prepared to handle
      string results for this response key.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      ed904904
    • René Nussbaumer's avatar
      Adding missing documentation to make the docs better · 2263aec2
      René Nussbaumer authored
      
      
      Also fixed a typo I noticed.
      Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      2263aec2
  2. 22 Mar, 2010 6 commits
  3. 18 Mar, 2010 12 commits
  4. 17 Mar, 2010 6 commits
  5. 16 Mar, 2010 2 commits
  6. 15 Mar, 2010 8 commits