1. 16 Jan, 2009 3 commits
    • Iustin Pop's avatar
      Instance: add a new all_nodes property · cfcc5c6d
      Iustin Pop authored
      Since we often need the list of all nodes of an instance, we add a new
      "all_nodes" property that returns all nodes of the instance, and we
      switch secondary_nodes to a simpler implementation based on this new
      function.
      
      Reviewed-by: ultrotter
      cfcc5c6d
    • Iustin Pop's avatar
      Fix gnt-backup export with short names · aeb83a2b
      Iustin Pop authored
      We need to pass the fully-qualified node to _CheckNodeOnline, not the short
      one.
      
      Reviewed-by: imsnah
      aeb83a2b
    • Iustin Pop's avatar
      burnin: add option to not remove instances · 320eda24
      Iustin Pop authored
      This patch adds a burnin option to keep instances at the end, so that
      debugging after a burnin failure is easier.
      
      Also, we reorder the command line parsing and client query so that one
      can use ./tools/burnin --help even on non-ganeti machines.
      
      Reviewed-by: ultrotter
      320eda24
  2. 15 Jan, 2009 2 commits
    • Iustin Pop's avatar
      Some docstring updates · 25e7b43f
      Iustin Pop authored
      This patch rewraps some comments to shorter lengths, changes
      double-quotes to single-quotes inside triple-quoted docstrings for
      better editor handling.
      
      It also fixes some epydoc errors, namely invalid crossreferences (after
      method rename), documentation for inexistent (removed) parameters, etc.
      
      Reviewed-by: ultrotter
      25e7b43f
    • Iustin Pop's avatar
      ganeti-noded: reduce log noise · 14d57a8b
      Iustin Pop authored
      The source port/addr is currently logged three times for each
      connection, and this is unnecessary. We change two log entries to debug,
      since they are useful for precise timing, and we keep only one at INFO
      level.
      
      Reviewed-by: imsnah
      14d57a8b
  3. 14 Jan, 2009 1 commit
  4. 13 Jan, 2009 14 commits
    • Iustin Pop's avatar
      Forward port of the burnin migration · 99bdd139
      Iustin Pop authored
      This is again a copy of the latest 1.2 burnin code related to migration.
      
      Reviewed-by: ultrotter
      99bdd139
    • Iustin Pop's avatar
      Forward port the live migration from 1.2 branch · 53c776b5
      Iustin Pop authored
      This is forward port via copy (and not individual patches cherry-pick)
      of the latest code on the 1.2 branch related to the migration.
      
      The changes compared to 1.2 are the fact that we don't need the
      IdentifyDisks step anymore (the drbd rpc calls are independent now), and
      the rpc module improvements.
      
      Reviewed-by: ultrotter
      53c776b5
    • Iustin Pop's avatar
      Port replace disk/change node to the new DRBD RPCs · a2d59d8b
      Iustin Pop authored
      In replace disks to new secondary, since Attach (and therefore
      call_blockdev_find) is not modifying the devices anymore, we need to
      switch this LU to the new call_drbd_disconnect_net and
      call_drbd_attach_net functions.
      
      Due to the authentication needed in 2.0, we need to be more careful with
      the activation order. In 1.2, we have the case that the new node was
      directly activated with networking information, and could connect to the
      primary while it was still connected or WFConnect to the old secondary.
      
      In the new scheme, we:
        - create the new drbd in StandAlone mode
        - shutdown old secondary (primary becomes WFConnection)
        - disconnect primary (and thus it goes into StandAlone)
        - connect both primary and new secondary to network using the
          call_drbd_attach_net rpc
      
      This should be safer, and is cleaner. This passes burnin.
      
      Reviewed-by: ultrotter
      a2d59d8b
    • Iustin Pop's avatar
      Forward-port DrbdNetReconfig · 6b93ec9d
      Iustin Pop authored
      This is a modified forward-port of DrbdNetReconfig and their associated
      RPCs. In Ganeti 2.0, these functions will be used for two things:
        - live migration (as in 1.2)
        - and for other network reconfiguration tasks, since DRBD8.Attach()
          doesn't do them anymore
      
      Because of the Attach() changes, we can now implement the
      AttachNet/DisconnectNet functions as independent entities, and we don't
      need the cache anymore.
      
      Note these functions are copies of the latest 1.2 code, and not
      cherry-picks of the (many) patches that went into 1.2.
      
      Reviewed-by: ultrotter
      6b93ec9d
    • Iustin Pop's avatar
      backend: rename AttachOrAssemble to Assemble · f96e3c4f
      Iustin Pop authored
      Since now the Assemble function is different than Attach, we rename this
      backend function to show that the intent is to fully assemble the device
      (and it's always allowed to modify the device).
      
      Reviewed-by: ultrotter
      f96e3c4f
    • Iustin Pop's avatar
      drbd: change the semantics of Attach vs. Assemble · 2d0c8319
      Iustin Pop authored
      Currently, both the Attach and Assemble methods for DRBD8 devices will use and
      alter the device state. This is suboptimal, and it has been worked
      around in 1.2 via a special cache in the node daemon so that we don't
      need to call Attach() again in migration, for example.
      
      Since in 2.0 we have static minors, we can change these functions so
      that:
        - Attach() does not affect the device in any way, and only checks if
          the minor is already in use or not
        - Assemble() has two logic paths, one for startup from unused minor
          (the old Assemble, now renamed _FastAssemble) and one for
          re-checking/fixing an in-use minor (the old Attach, now renamed
          _SlowAttach)
      
      Basically Attach was renamed to _SlowAttach, Assemble to _FastAssemble,
      and we have a new, simple Assemble that calls one or the other based on
      the result of the new Attach.
      
      The LUReplaceDisks (with new secondary) is relying on the special
      semantics of Attach modifying the device and is broken until the end of
      the patch series.
      
      Reviewed-by: ultrotter
      2d0c8319
    • Iustin Pop's avatar
      bdev: Do not call Assemble() on children · f87548b5
      Iustin Pop authored
      The caller of dev.Assemble() (backend._RecursiveAssembleBD) is doing an
      explicit recursion over all the children of the device, with better
      error reporting. As such, we don't need this repeated assembly inside
      the base BlockDev class.
      
      Reviewed-by: ultrotter
      f87548b5
    • Iustin Pop's avatar
      Fix modification of instance memory · ea33068f
      Iustin Pop authored
      ... as found by the QA script - bug was introduced by me in commit 2117.
      
      Reviwed-by: imsnah
      ea33068f
    • Iustin Pop's avatar
      burnin: redo the output formatting · 836d59d7
      Iustin Pop authored
      Since we added many more tests in burnin, the output became almost
      unreadable. This patch changes the output to an indented one, so that
      the different phases and operations of burnin are more easily
      understood.
      
      Reviwed-by: ultrotter
      836d59d7
    • Iustin Pop's avatar
      burnin: move start_stop at the end · eb61f8d3
      Iustin Pop authored
      Traditionally the start/stop test was the last, so move it back to there
      (added as last option in commit 854).
      
      Reviewed-by: amishchenko
      eb61f8d3
    • Iustin Pop's avatar
      QA: add burnin parameters (parallel, http-check) · 0b0a150a
      Iustin Pop authored
      This patch adds burnin parameters for --parallel and --http-check
      options to the burnin script.
      
      Reviewed-by: ultrotter
      0b0a150a
    • Iustin Pop's avatar
      Increase resync speed to 60MB/s · 24b0d752
      Iustin Pop authored
      This is a forward-port of commit 2219 on the 1.2 branch.
      
      Reviewed-by: ultrotter
      24b0d752
    • Iustin Pop's avatar
      burnin: introduce instance alive checks · 5178f1bc
      Iustin Pop authored
      This patch adds instance alive checks after most start operations. The
      check is done in a custom way:
        - the instance is expected to have an http server up and running
        - and it should server the '/hostname.txt' resource containing the
          hostname of the instance
      
      This allows checking that:
        - creation is working OK
        - start after failover (and in the future migrate) is ok
        - rename works correctly
      
      By default, the check is disabled since one needs a custom OS for this
      check.
      
      The patch also fixes a wrong variable name from a previous burnin patch.
      
      Reviewed-by: ultrotter
      5178f1bc
    • Iustin Pop's avatar
      Small typo in ganeti-watcher · 4bffa7f7
      Iustin Pop authored
      Reviewed-by: imsnah
      4bffa7f7
  5. 12 Jan, 2009 6 commits
    • Iustin Pop's avatar
      Skip offline nodes in gnt-cluster commands · 4040a784
      Iustin Pop authored
      This patch makes gnt-cluster copyfile and command skip the offline
      nodes.
      
      Reviwed-by: ultrotter, imsnah
      4040a784
    • Iustin Pop's avatar
      burnin: Add tests for add/remove disks and NICs · 5c22d16e
      Iustin Pop authored
      This patch adds testing of add/remove disks and NICs to the burnin.
      
      Reviewed-by: imsnah
      5c22d16e
    • Iustin Pop's avatar
      Heavy redo of gnt-instance info output · 19708787
      Iustin Pop authored
      In 2.0, we have more parameters in drbd's logical_id, and passing the
      results over json makes them unicode which looks worse with the default
      formatting. As such, a redo of the output is needed.
      
      This patch:
        - adds a separate function to format the logical_id of devices
        - moves the actual indentation format out of _FormatBlockDevInfo,
          which now just generates a list of items
        - adds a function _FormatList that recursively formats the list
        - formats specially key,value tuples
      
      The result is that the output is nicer, and the code in
      _FormatBlockDevInfo somewhat cleaner (as it doesn't deal with spacing
      and such issues).
      
      Reviewed-by: ultrotter
      19708787
    • Iustin Pop's avatar
      Fix some errors in instance modify --disk remove · 4cfb9426
      Iustin Pop authored
      The RpcResult introduction still left some bugs (after multiple patches):
        - we don't correctly check the result type
        - rename a variable to prevent a conflict
      
      Reviewed-by: imsnah
      4cfb9426
    • Iustin Pop's avatar
      Fix an error handling case in instance info · f57c76e4
      Iustin Pop authored
      The checking for invalid instance names in LUQueryInstanceData is broken
      since commit 1642.
      
      Reviewed-by: imsnah
      f57c76e4
    • Iustin Pop's avatar
      Introduce a very simple LU to force config updates · afee0879
      Iustin Pop authored
      This LU can be used to force a push of the config in case it's needed,
      for example after an upgrade to update the ssconf_release_version file.
      
      Reviewed-by: imsnah
      afee0879
  6. 09 Jan, 2009 9 commits
    • Iustin Pop's avatar
      Add a new ssconf file with the ganeti version · 8a113c7a
      Iustin Pop authored
      The patch adds a new ssconf file containing the ganeti version.
      
      Reviewed-by: imsnah
      8a113c7a
    • Iustin Pop's avatar
      Work around a DRBD sync speed race condition · 7d585316
      Iustin Pop authored
      This is modified forward-port of commit 1544 on the 1.2 branch:
      
        When DRBD is doing its dance to establish a connection with its
        peer, it also sends the synchronization speed over the wire. In
        some cases setting the sync speed only after setting up both
        sides can race with DRBD connecting, hence we set it here before
        telling DRBD anything about its peer.
      
        Reviewed-by: iustinp
      
      The modification we make is that we split SetSyncSpeed in two so that we
      don't need to modify our minor temporarily, and the fact that we call
      this function from within _AssembleNet (right before enabling network),
      instead of Assemble()/Attach().
      
      Original-Author: imsnah
      7d585316
    • Iustin Pop's avatar
      burnin: Add activate/deactivate disks · 90e722d1
      Iustin Pop authored
      Reviewed-by: imsnah
      90e722d1
    • Iustin Pop's avatar
      burnin: use the new replace_disks constants · cfacfd6e
      Iustin Pop authored
      This patch updates burnin to the latest replace disks constant, and
      changes the constants' values to be more accurate.
      
      Reviewed-by: imsnah
      cfacfd6e
    • Iustin Pop's avatar
      burnin: do not use offline nodes · 729164d0
      Iustin Pop authored
      This patch makes burnin skip the offline nodes in it's builtin node
      selection. It also removes an extra line.
      
      Reviewed-by: imsnah
      729164d0
    • Iustin Pop's avatar
      Fix gnt-os for offline nodes · 94a02bb5
      Iustin Pop authored
      We shouldn't query offline nodes in gnt-os. This patch adds an utility
      function to ConfigWriter that returns the names of online nodes and uses
      it in LUDiagnoseOS to query only the good nodes.
      
      Reviewed-by: imsnah
      94a02bb5
    • Iustin Pop's avatar
      Silence warning on node list for offline nodes · 186ec53c
      Iustin Pop authored
      The warning in node list is meant for nodes that return wrong
      information, but for offline nodes this case is normal.
      
      Reviewed-by: imsnah
      186ec53c
    • Iustin Pop's avatar
      Rework the daemonization sequence · 7d88772a
      Iustin Pop authored
      The current fork+close fds sequence has deficiencies which are hard to
      work around:
        - logging can start logging before we fork (e.g. if we need to emit
          messages related to master checking), and thus use FDs which we
          can't track nicely
        - the queue locks the queue file, and again this fd needs to be kept
          open which is hard from the main loop (and this error is currently
          hidden by the fact that we don't log it)
      
      Given the above, it's much simpler, in case we will fork later, to close
      file descriptors right at the beginning of the program, and in Daemonize
      only close/reopen the stdin/out/err fds.
      
      In addition, we also close() the handlers we remove in SetupLogging so
      that the cleanup is more thorough.
      
      Reviewed-by: imsnah
      7d88772a
    • Iustin Pop's avatar
      Cleanup replace-disks modes and options · 7e9366f7
      Iustin Pop authored
      In 1.2, due to the md+drbd7 legacy, we had a complex choice of replace
      modes, and the new drbd8 modes where forced into this syntax, with some
      complicated rules of transition from one mode to another (if REPLACE_ALL
      but not new node passed, switch to REPLACE_SEC, etc.).
      
      This patch cleans this situation by making a clear separation between
      the two main modes:
        - replace on current nodes (with the two sub-cases on primary and on
          secondary)
        - change to a new node (either via manually specified node or via
          iallocator)
      
      Reviewed-by: imsnah
      7e9366f7
  7. 08 Jan, 2009 4 commits
    • Iustin Pop's avatar
      Fix cluster verify/node net test for offline nodes · 82e37788
      Iustin Pop authored
      For offline nodes, we shouldn't add them to the NV_NODELIST and
      NV_NODENETTEST tests since they most likely won't succeed.
      
      The patch makes gnt-cluster verify happy again in such cases.
      
      Reviewed-by: imsnah
      82e37788
    • Iustin Pop's avatar
      rpc: Add a method for easy check of remote results · 3247bbac
      Iustin Pop authored
      The patch adds a new method to the rpc.RpcResult class called
      "RemoteFailMsg" which is useful for the RPC calls which return a
      (status, payload) style result.
      
      Reviewed-by: imsnah
      3247bbac
    • Iustin Pop's avatar
      Add an instance_migratable rpc call · 56e7640c
      Iustin Pop authored
      This is a forward-port of commit 1194 on the 1.2 branch:
      
        This call will check whether an instance is up on its primary, and that
        it has been started with symlinks. We currently have no on-secondary
        checks, nor any hypervisor specific call.
      
        Reviewed-by: iustinp
      
      The difference from the original patch is that we don't include the
      cmdlib changes, since those will come as a copy from the 1.2 cmdlib.py,
      and not as individual patches.
      
      Original-Author: ultrotter
      56e7640c
    • Iustin Pop's avatar
      bdev: forward-port ReAttachNet/DisconnectNet · cf8df3f3
      Iustin Pop authored
      This is plain copy of the 1.2 ReAttachNet and DisconnectNet methods on
      the DRBD8 device, with the logger to logging module changes and the
      ReAttachNet method renamed to AttachNet.
      
      These methods are not used anywhere right now, but will be used for
      migration and a simpler disk-replace.
      
      The code was originally committed on the 1.2 branch as revision numbers
      1165 and 1204.
      
      Originally-Reviewed-by: imsnah, ultrotter
      cf8df3f3
  8. 07 Jan, 2009 1 commit
    • Iustin Pop's avatar
      backend: Remove symlinks by disk name · 5282084b
      Iustin Pop authored
      This is a modified forward-port of commit 1184 on the 1.2 branch:
      
        backend: Remove symlinks by disk name, not using a wildcard
      
        Reviewed-by: ultrotter
      
      The changes to the original patch are related to the docstring style and
      iv_name to index switch.
      
      Original-Author: imsnah
      5282084b