1. 05 Dec, 2008 4 commits
    • Iustin Pop's avatar
      watcher: handle offline nodes better · cbfc4681
      Iustin Pop authored
      This patch changes the LUQueryInstances to show a different state for
      offline nodes and also modifies the watcher to understand the offline
      state in its checks.
      Reviewed-by: ultrotter
    • Iustin Pop's avatar
      node list: add the offline field · 9ddb5e45
      Iustin Pop authored
      Reviewed-by: ultrotter
    • Iustin Pop's avatar
      Add a new node parameter 'offline' · fc0fe88c
      Iustin Pop authored
      This patch adds a new node parameter called offline that will be used to
      mark nodes which should be touched by commands.
      We also add this flag at cluster init, node add, and export it to
      iallocator scripts.
      Reviewed-by: ultrotter
    • Iustin Pop's avatar
      ssconf: empty files should not add a newline · 02b31f32
      Iustin Pop authored
      Currently we add a newline in the ssconf writeout process, even if the
      file is empty. We chage this case so that lists of values (e.g. offline
      nodes) are correct (not a list of one empty element).
      Reviewed-by: imsnah
  2. 04 Dec, 2008 10 commits
  3. 03 Dec, 2008 17 commits
  4. 02 Dec, 2008 9 commits
    • Guido Trotter's avatar
      Fix hooks_unittest with new rpc call structure · 7ccb3074
      Guido Trotter authored
      Reviewed-by: iustinp
    • Iustin Pop's avatar
      Fix gnt-cluster verify w.r.t. rpc changes · 25361b9a
      Iustin Pop authored
      This partially reorganizes the cluster verify LU:
        - introduce constants for the node verify rpc call
        - move from additional rpc calls to a single rpc call, the
          call_node_info, which gaters all data needed
      Also fix a small error (self.LogWarning instead of self.Warning).
      Reviewed-by: imsnah
    • Iustin Pop's avatar
      Fix cluster rename · 55cf7d83
      Iustin Pop authored
      With the recent configwriter/ssconf changes, cluster rename becomes
      trivial. This patch gets rids of the code and just updates the cluster
      Reviewed-by: imsnah
    • Iustin Pop's avatar
      Convert rpc results to a custom type · 781de953
      Iustin Pop authored
      For a long time we had the problem that both RPC-layer errors and
      results from the remote node share the same "valuespace". This is
      because we shouldn't raise an exception when only one node failed
      (and lose the results from the other nodes).
      This patch attempts to address this problem by returning a special
      object from RPC calls, which separates the rpc-layer status and the
      remote results into different attributes.
      All the users of rpc (mainly cmdlib, but also bootstrap and the
      HooksMaster in mcpu) have been converted to this new model. The code has
      changed from, e.g. for boolean return types:
        if not self.rpc.call_...
        result = self.rpc.call_
        if result.failed or not result.data:
           ^ rpc-layer error    |
                                - result payload
      While this is slightly more complicated, it will allow cleaner checks in
      the future; right now the code is just a plain port, without
      There's also a "result.Raise()" which raises an OpExecError if the
      rpc-layer had errors.
      One side-effect of the patch is that now all return types from the
      rpc.call_ functions are of either RpcResult (single-node) or dicts of
      (node name, RpcResult); previously, some functions were returning
      different object types based on error status.
      The code passes burnin (after many retries :).
      Reviewed-by: imsnah
    • Iustin Pop's avatar
      burnin: add instance reinstall and reboot · 00f91f29
      Iustin Pop authored
      These two operations were missing from burnin. The reboot is done with
      all valid modes (a new constant is added), and the reinstall is done
      both with and without specifying the OS (to account for the two code
      paths in the LU).
      Reviewed-by: imsnah
    • Iustin Pop's avatar
      burnin: don't do export/import for file storage · a5e7be6b
      Iustin Pop authored
      This is currently not supported, so don't try to do export/import in
      this case.
      Reviewed-by: imsnah
    • Guido Trotter's avatar
      KVMHypervisor add two missing 'constants.' · 8a74a9b9
      Guido Trotter authored
      Some calls to the HV parameters were missing them.
      Reviewed-by: imsnah
    • Guido Trotter's avatar
      KVMHypervisor fix to case misspellings · 47387b1e
      Guido Trotter authored
      Reviewed-by: imsnah
    • Guido Trotter's avatar
      cluster init: don't discard the hypervisor · 8f348e36
      Guido Trotter authored
      On cluster init if the user specifies a default hypervisor (with -t)
      which is not in the default list of enabled hypervisors (currently just
      xen-pvm) without explicitely specifying the list we silently override
      the choice.
      With this patch we set the list by default to just the required one, and
      we bail out should the list be hand-specified and not contain the
      default one. This still has an issue when the user doesn't specify a
      default hypervisor but specifies a list which doesn't include xen-pvm:
      in this case though we give an error, rather than silently discarding
      Reviewed-by: imsnah