1. 20 Jan, 2012 1 commit
    • Guido Trotter's avatar
      kvm: always start in paused state · 945a7e67
      Guido Trotter authored
      
      
      Currently kvm starts in a frozen state if cpu pinning is set.
      This is useful for other purposes as well (eg. ballooning before the
      instance uses the memory), so we move the functionality out of the cpu
      pinning code.
      
      Note that before the "continue" command was executed in a finally after
      trying to set the cpu pinning. This didn't help if anything else in the
      function failed before that, though. As such we just move it out, as
      anyway a failure above will cause an exception, so the user will know
      their start command hasn't succeeded anyway.
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      945a7e67
  2. 19 Jan, 2012 6 commits
  3. 18 Jan, 2012 4 commits
  4. 17 Jan, 2012 9 commits
  5. 16 Jan, 2012 15 commits
  6. 13 Jan, 2012 5 commits
    • Iustin Pop's avatar
      Fix very slow unit-test data generation in some cases · 7806125e
      Iustin Pop authored
      
      
      Learning, learning. It turns out that for objects with even just five
      fields, generating them and filtering can be costly, especially when
      the filtering is nested (as it was in this case, arbitrary1 →
      arbitrary2 + filter on arbitrary1 → arbitrary plus filter on
      aribitrary2).
      
      Changing the code to generate directly the good values speeds things
      up significantly. Additionally, we also generate correctly unique
      lists of disk templates (again, this should be a set, not a list,
      but…).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      7806125e
    • Iustin Pop's avatar
      Fix one bad unit-test data generation case · 746b7aa6
      Iustin Pop authored
      
      
      It could happen that the node is generated with 0 disk available, in
      which case the operation will fail due to disk issues, not CPU. Fix
      this by using the recently-introduced genOnlineNode helper.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      746b7aa6
    • Iustin Pop's avatar
      Further fixes to instance policy validation · 57dc299a
      Iustin Pop authored
      
      
      As a followup from "Remove extraneous check in policy creation", there
      are more places where we build an ipolicy, and then manually check for
      its validity. This is very bad style, as it duplicates the
      verification code across many places.
      
      This patch removes all such explicit checks (except for one in
      cmdlib.py which is correct), and instead does a bit more validation in
      the builder functions or in the actual dedicated verification
      functions. It also fixes cluster init which used the wrong,
      non-completed ipolicy (this was not detected before as we did call
      check on it, but otherwise we ignored it), and fixes a too-strong
      assert (due to the call chain, we first create the ipolicy from
      cmdline params, and only then we fill it).
      
      Finally, it removes an extraneous logging.info which I forgot from
      debugging.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      57dc299a
    • Iustin Pop's avatar
      Fix another data generation issue in tests · 3074ccaf
      Iustin Pop authored
      
      
      Another "good" seed value manages to generate nodes with identical
      names, which of course makes the sets be of smaller value than the
      lists. Avoid this issue by generating unique node names.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      3074ccaf
    • Iustin Pop's avatar
      Remove some dead code · 16670b57
      Iustin Pop authored
      
      
      While wondering why Cluster.tryReloc is not unit-tested, I realised
      that this is no longer uses. Apparently, last summer's new IAllocator
      modes and related changes have silently deprecated this function.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      16670b57