1. 06 Apr, 2009 6 commits
    • Iustin Pop's avatar
      Disable synchronous (locking) queries · 77921a95
      Iustin Pop authored
      This patch raises an error in the master daemon in case the user
      requests a locking query; accordingly, all clients were modified to send
      only lockless queries. This is short-term fix, for proper fix the
      clients should be modified to submit a job when the user request a
      locking query.
      
      The other approach would be to ignore the flag passed by the client;
      this would be worse as client's wouldn't get at least an error.
      
      The possible impact of this is multiple:
        - some commands could have been not converted, and thus fail; this
          can be remedied easily
        - the consistency of commands is lost; e.g. node failover will not
          lock the node *while we get the node info*, so we could miss some
          data; this is again in the thread of atomic operations which are
          missing in the current model of query-and-act from gnt-* scripts
      
      Reviewed-by: imsnah, ultrotter
      77921a95
    • Iustin Pop's avatar
      Fix the output of watcher on non-master nodes · 2c404217
      Iustin Pop authored
      Currently the watcher spews errors message on non-master nodes. This
      cleans it up.
      
      Reviewed-by: imsnah
      2c404217
    • Iustin Pop's avatar
      Change the watcher to use jobs instead of queries · 6dfcc47b
      Iustin Pop authored
      As per the mailing list discussion, this patch changes the watcher to
      use a single job (two opcodes) for getting the cluster state (node list
      and instance list); it will then compute the needed actions based on
      this data.
      
      The patch also archives this job and the verify-disks job.
      
      Reviewed-by: imsnah
      6dfcc47b
    • Iustin Pop's avatar
      Fix Xen soft reboot via polling · 7dd106d3
      Iustin Pop authored
      This patch fixes the Xen soft reboot ("xm reboot") via polling for a specific
      time for either changed domain ID or decreased CPU run-time.
      
      This sould prevent the race-conditions discussed on the mailing list for
      reboots.
      
      Reviewed-by: imsnah
      7dd106d3
    • Iustin Pop's avatar
      Add a new ssconf file with the cluster tags · 5d60b3bd
      Iustin Pop authored
      Since the cluster tags are/should be more-or-less static, add them as an
      ssconf key, so that querying them is possible without creating a
      job/requiring the masterd to be running.
      
      Reviewed-by: imsnah
      5d60b3bd
    • Iustin Pop's avatar
      Add some more debugging info to masterd · e566ddbd
      Iustin Pop authored
      This patch will log data about queries, which are today completely
      invisible (at the default log level) in the master log file.
      
      Reviewed-by: imsnah
      e566ddbd
  2. 27 Mar, 2009 1 commit
    • Iustin Pop's avatar
      Release 2.0rc2 · f06d91f2
      Iustin Pop authored
      This updates the NEWS file and bumps up the version number.
      
      Reviewed-by: ultrotter
      f06d91f2
  3. 20 Mar, 2009 3 commits
  4. 12 Mar, 2009 3 commits
  5. 10 Mar, 2009 1 commit
  6. 09 Mar, 2009 3 commits
    • Iustin Pop's avatar
      watcher: fix startup sequence locking the master · cc962d58
      Iustin Pop authored
      Currently, the watcher startup sequence does:
        - open a luxi client
        - get the instance list
        - get the node boot ids
        - open and lock the status file, and:
          - archive jobs
          - restart the down instances
          - check disks
      
      This, of course, can lead to problems when a node is (genuinely or not)
      locked for more than (watcher interval * maximum query clients) time. At
      that time, the master is completely unresponsive until the node is
      unlocked and all the watchers exit with error due to the state file
      being locked by the first instance.
      
      This patch reworks the startup sequence to first open/lock the status
      file, and only then open a luxi client. This should prevent the above
      case.
      
      Reviewed-by: ultrotter
      cc962d58
    • Iustin Pop's avatar
      Handle ghost instances in temp DRBD map · c614e5fb
      Iustin Pop authored
      Currently cluster-verify doesn't handle the (admitedly invalid) case where we
      have reservation for instances that were removed in the meantime.
      
      This patch adds a check for this and prevents code errors in cluster-verify in
      this case:
       * Verifying node node4.example.com (master candidate)
         - ERROR: ghost instance \'instance3.example.com\' in temporary DRBD map
      
      Reviewed-by: imsnah
      c614e5fb
    • Iustin Pop's avatar
      Fix error handling in replace-disks with new node · 82759cb1
      Iustin Pop authored
      Currently the _CreateSingleBlockDev function only raises OpExecError and not
      BlockDeviceError. This means that we don't release the instance's temporary
      minors properly, and this creates problems later if the instance is removed
      without master restart.
      
      We could just use OpExecError, but adding it and leaving
      BlockDeviceError in seems safer.
      
      Reviewed-by: imsnah
      82759cb1
  7. 06 Mar, 2009 1 commit
    • Iustin Pop's avatar
      Fix serial_no field on instances · 6f285030
      Iustin Pop authored
      The instance objects did not get a serial_no field. This patch adds a
      new constants for the field name and uses it for all three cases
      (cluster, nodes, instances).
      
      Reviewed-by: imsnah
      6f285030
  8. 05 Mar, 2009 1 commit
    • Guido Trotter's avatar
      Update gnt-cluster(8) for be/hyp parameter syntax · 555918b3
      Guido Trotter authored
      Now it displays:
      
      --hypervisor-parameters hypervisor:hv-param=value [ ,hv-param=value ... ]
      --backend-parameters be-param=value [ ,be-param=value ... ]
      
      Sorry for the super-long lines :( Is there a better way to insert spaces
      without pushing them to the resulting man page?
      
      Reviewed-by: iustinp
      555918b3
  9. 04 Mar, 2009 3 commits
    • Iustin Pop's avatar
      Complete the cfgupgrade script for 2.0 migrations · ac4d25b6
      Iustin Pop authored
      This patch makes the cfgupgrade script to handle:
        - instance changes
        - disk changes
        - further cluster fixes
        - adds configuration checks at the end, in non-dry-run mode
      
      Reviewed-by: ultrotter
      ac4d25b6
    • Iustin Pop's avatar
      First run at cfgupgrade for 2.0 upgrades · a421fdeb
      Iustin Pop authored
      This patch makes cfgupgrade work on empty cluster (i.e. no instances),
      up to a point that the config file can be converted from 1.2 to 2.0.
      This is not yet complete, though.
      
      Reviewed-by: ultrotter
      a421fdeb
    • Iustin Pop's avatar
      Fix bash completion for cluster copyfile/command · 75615bd3
      Iustin Pop authored
      “copyfile” takes a file argument, so we enable file-completion for it.
      “gnt-cluster command” takes a command, so we enable command completion.
      
      Reviewed-by: imsnah
      75615bd3
  10. 02 Mar, 2009 6 commits
    • Iustin Pop's avatar
      Release 2.0rc1 · a2370b24
      Iustin Pop authored
      This patch updates the NEWS file and increases the version to 2.0 rc1.
      
      Reviewed-by: ultrotter
      a2370b24
    • Iustin Pop's avatar
      Export tags to cluster verify hooks · 35e994e9
      Iustin Pop authored
      This patch export the cluster and node tags to the cluster verify hook
      scripts. The tags are exported as a space-separated list, which allows
      easy parsing from the shell (e.g. “for tag in $GANETI_CLUSTER_TAGS; do
      ...”) and therefore requires the previous “Don't allow spaces in tag
      names” patch.
      
      The patch also fixes a minor line length style problem.
      
      Reviewed-by: ultrotter
      35e994e9
    • Iustin Pop's avatar
      Don't allow spaces in tag names · 28ab6fed
      Iustin Pop authored
      This patch restricts the use of spaces in tags, as this does not allow
      nice exporting of tags to environment in hooks. One can use underscores
      or dashes instead of spaces.
      
      Reviewed-by: schreiberal
      28ab6fed
    • Iustin Pop's avatar
      Update the iallocator documentation · 77031881
      Iustin Pop authored
      This updates the iallocator documentation to 2.0, bumps up the
      iallocator version (and moves a constants to lib/constants.py), and
      fixes a style on install.rst.
      
      Reviewed-by: ultrotter
      77031881
    • Iustin Pop's avatar
      Fix a bug in utils.EnsureDirs · 1b2c8f85
      Iustin Pop authored
      This fixes a bug introduced in rev 2562 and also fixes the indentation.
      
      Reviewed-by: ultrotter
      1b2c8f85
    • Iustin Pop's avatar
      A doc update and a small indentation fix · b806661b
      Iustin Pop authored
      This adds a small paragraph about the “master” role of a node, and fixes
      a wrong indentation in the bash completion file.
      
      Reviewed-by: imsnah
      b806661b
  11. 27 Feb, 2009 6 commits
    • Guido Trotter's avatar
      Use EnsureDirs in KVM as well. · 9afb67fe
      Guido Trotter authored
      The KVM hypervisor has also code to ensure a list of directories exist.
      Substitute it with our new utils function.
      
      Reviewed-by: iustinp
      9afb67fe
    • Guido Trotter's avatar
      Create runtime dir in bootstrap · 9dae41ad
      Guido Trotter authored
      Some hypervisors (KVM) need RUN_GANETI_DIR to exist even at cluster init
      time. This patch creates it in InitCluster just before hv parameter
      checking. Since the code to make list of directories is already repeated
      twice in the code, and this would be the third time, we abstract it into
      an utils.EnsureDirs function and we call that one from ganti-noded,
      ganeti-masterd and bootstrap.
      
      Reviewed-by: iustinp
      9dae41ad
    • Guido Trotter's avatar
      LUVerifyCluster: Handle the "no volume group" case · cc9e1230
      Guido Trotter authored
      If we're only file based and out volume group is set to "None" there's
      no point in asking nodes for their volume groups, logical volumes, and
      drbd devices, and checking those.
      
      Reviewed-by: iustinp
      cc9e1230
    • Iustin Pop's avatar
      Convert the RAPI document to restructured text · 4352bf6d
      Iustin Pop authored
      This patch changes the RAPI document, and the RAPI resources
      autogenerated-documentation to restructured text. This meant changing
      the autogen tool.
      
      The new fragment can be included via RST directives, and doesn't need
      passing through replace-sed-vars. This was also the last sgml document
      in doc/, so we remove old makefile rules about it.
      
      Reviewed-by: imsnah
      4352bf6d
    • Iustin Pop's avatar
      Fix some epydoc style issues · 5fcc718f
      Iustin Pop authored
      99% of the epydoc return tags are "@return:", but each of the modified files
      had one "@returns:" line. We fix this for consistency.
      
      Reviewed-by: imsnah
      5fcc718f
    • Iustin Pop's avatar
      Convert the install document to restructured text. · 28e15341
      Iustin Pop authored
      This switches back to the hardcoding of the version number, as we don't
      yet have a wrapper for rst files that passes them through
      replace-sed-vars.
      
      Reviewed-by: imsnah
      28e15341
  12. 26 Feb, 2009 3 commits
    • Iustin Pop's avatar
      Fix the Makefile after the bash_completion patch · f72f8622
      Iustin Pop authored
      I've somehow left these two out. Sorry!
      
      Reviewed-by: imsnah
      f72f8622
    • Iustin Pop's avatar
      Add bash-completion rules · e2a2a2eb
      Iustin Pop authored
      This is a not-complete bash completion file for ganeti commands (gnt-*)
      and the burnin tool. It is based on previous work by Minghua Ye
      <yeminghua@google.com> for Ganeti 1.1, which wasn't used because the
      lack of ssconf keys (which allow easy inspection by the shell of the
      existing nodes and instances) made it too slow.
      
      The file works as expected, however I realized that our custom (like
      comma-separated, or a=b:c,e:f) options are not very nice for
      auto-completion. There are a few FIXMEs in the source for that.
      
      The file is not installed at make install time, but it should be put in
      the correct place by packages.
      
      Reviewed-by: imsnah
      e2a2a2eb
    • Michael Hanselmann's avatar
      Fix typos in utils.WriteFile's docstring · 69efe319
      Michael Hanselmann authored
      Reviewed-by: iustinp
      69efe319
  13. 25 Feb, 2009 3 commits
    • Iustin Pop's avatar
      Fix mixed pvm/hvm clusters and instance listing · b33b6f55
      Iustin Pop authored
      The current implementation of the combining of the instance lists will
      only do this for instances whose all four-fields match in both
      hypervisors; however, this is broken for the dynamic fields (state,
      times) which can change between the invocations of the two different
      hypervisors if the instance is busy.
      
      The patch checks only the memory and VCPUs, and makes mixed clusters
      work even with 100% CPU instances.
      
      Reviewed-by: imsnah
      b33b6f55
    • Iustin Pop's avatar
      Fix xen-hvm and KERNEL_ARGS · b399ce1e
      Iustin Pop authored
      xen-hvm doesn't have KERNEL_ARGS, and I just changed blindly all old
      extra_args to HV_KERNEL_ARGS. This makes xen-hvm work again.
      
      Reviewed-by: imsnah
      b399ce1e
    • Iustin Pop's avatar
      Update some version-related constants · f3e2e4c6
      Iustin Pop authored
      Since we are quite close to final RPC and hooks APIs, we update the hooks and
      protocol_version constants.
      
      Reviewed-by: imsnah
      f3e2e4c6