Commit 82759cb1 authored by Iustin Pop's avatar Iustin Pop
Browse files

Fix error handling in replace-disks with new node

Currently the _CreateSingleBlockDev function only raises OpExecError and not
BlockDeviceError. This means that we don't release the instance's temporary
minors properly, and this creates problems later if the instance is removed
without master restart.

We could just use OpExecError, but adding it and leaving
BlockDeviceError in seems safer.

Reviewed-by: imsnah
parent 6f285030
......@@ -5297,7 +5297,7 @@ class LUReplaceDisks(LogicalUnit):
try:
_CreateSingleBlockDev(self, new_node, instance, new_drbd,
_GetInstanceInfoText(instance), False)
except errors.BlockDeviceError:
except errors.GenericError:
self.cfg.ReleaseDRBDMinors(instance.name)
raise
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment