1. 12 Jan, 2011 3 commits
    • Iustin Pop's avatar
      Run pylint over QA code too · 3582eef6
      Iustin Pop authored
      
      
      Right now, the QA code is not covered by pylint, and this shows at
      least one low-impact bug.
      
      This patch does the necessary changes to make QA pylint-clean, and the
      changes the makefile to run pylint for it.
      
      Notable changes:
      
      - qa_utils.GenericQueryTest: randfields was not used at all, and my
        belief is that it was indented to be used in order not to modify the
        input list; so I replaced randfields with fields, so we only shuffle
        the our local copy
      - qa_node.TestOutOfBand was using it's own copy of AcquireNode(), so I
        replaced it with the existing version
      - qa_os: was using 'dir' in a couple of places, replaced with dirname
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      3582eef6
    • Iustin Pop's avatar
      QA: use a persistent SSH connection to the master · f7e6f3c8
      Iustin Pop authored
      
      
      The recent additions to QA (many more tests) make QA slow if the
      machine on which the QA runs is not very close to the tested nodes —
      or in general, when the SSH handhaske is costly.
      
      We discussed before about using a persistent connection, and here is
      the patch that implements it. On a very small QA (very very small), it
      cuts down a lot of time (almost half), so it should be useful even for
      a full QA.
      
      I've also thought about changing from external ssh to paramiko, but I
      estimated that it would be more work to correctly interleave the IO
      from the remote process than just running a background SSH.
      
      Also note that yes, the global dict is ugly, but I don't know of
      another simple way to implement this.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      f7e6f3c8
    • Iustin Pop's avatar
      QA: Fix duplicated OOB tests · 69df9d2b
      Iustin Pop authored
      Patch f55312bd
      
       added the OOB tests to TestClusterVerify, which is not
      actually a test for cluster verify, but a runner for cluster verify
      that is called multiple times, for each instance type, etc. This led
      to running the OOB commands multiple times, which is painful
      especially as this is a slow test.
      
      The patch moves this to a separate test, that is run only once.
      
      Furthermore, the way that data files are copied around is very
      inefficient: touch + mv + chmod + mv + rm for each node (5 times
      number of nodes), whereas it could be simply: touch on master, chmod
      on master, cluster copyfile, chmod on master, cluster copyfile,
      cluster command rm, i.e. only 5 fixed ssh calls to the master. The
      code is changed as such, for increased speed.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      69df9d2b
  2. 11 Jan, 2011 25 commits
  3. 10 Jan, 2011 12 commits