Run pylint over QA code too
Right now, the QA code is not covered by pylint, and this shows at least one low-impact bug. This patch does the necessary changes to make QA pylint-clean, and the changes the makefile to run pylint for it. Notable changes: - qa_utils.GenericQueryTest: randfields was not used at all, and my belief is that it was indented to be used in order not to modify the input list; so I replaced randfields with fields, so we only shuffle the our local copy - qa_node.TestOutOfBand was using it's own copy of AcquireNode(), so I replaced it with the existing version - qa_os: was using 'dir' in a couple of places, replaced with dirname Signed-off-by:Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
Showing
- Makefile.am 3 additions, 0 deletionsMakefile.am
- qa/ganeti-qa.py 4 additions, 1 deletionqa/ganeti-qa.py
- qa/qa_config.py 2 additions, 2 deletionsqa/qa_config.py
- qa/qa_error.py 4 additions, 0 deletionsqa/qa_error.py
- qa/qa_group.py 5 additions, 1 deletionqa/qa_group.py
- qa/qa_instance.py 6 additions, 1 deletionqa/qa_instance.py
- qa/qa_node.py 6 additions, 7 deletionsqa/qa_node.py
- qa/qa_os.py 10 additions, 10 deletionsqa/qa_os.py
- qa/qa_rapi.py 7 additions, 7 deletionsqa/qa_rapi.py
- qa/qa_utils.py 3 additions, 1 deletionqa/qa_utils.py
Loading
Please register or sign in to comment