They're cheap to instantiate and doing this changes makes the code
a bit simpler.

Reviewed-by: ultrotter

All other exceptions are named after the error name in RFC2616 (HTTP/1.1).

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Reviewed-by: amishchenko

More complex unittests will need some refactoring in the HTTP code.

Reviewed-by: amishchenko

Reviewed-by: iustinp

A job queue with too many jobs can increase memory usage and/or make
the master daemon slow. The current limit is just an arbitrary number.
A "soft" limit for automatic job archival is prepared.

Reviewed-by: iustinp

Sometimes the proc filesystem doesn't reflect the current status of
a process. By calling waitpid(), we make sure to get the current
information, at least for child processes. The timeout is still
kept for child processes to make sure the proc filesystem is updated.

Reviewed-by: iustinp

Reviewed-by: iustinp

The primary node is part of the instance, not of the opcode.

Reviewed-by: iustinp

poll() can be interrupted. rather than failing we retry until it
returns.

Reviewed-by: iustinp

Call socat with a full path specified at configure time, rather than
just by its name, and check for the binary to exist at hypervisor
verify.

Reviewed-by: iustinp

It makes sense for the default kvm kernel not to be called "xenU".

Reviewed-by: iustinp

Reviewed-by: iustinp

Otherwise it would be done on the first read/write operation, making
error handling more difficult (such as EOF during handshake).

Reviewed-by: iustinp

Reviewed-by: iustinp

Also add a comment next to the place where the SSL connection is shut
down.

Reviewed-by: iustinp

We should initialized the _last_cluster_serial in the constructor too (just to
be consistent).

Reviewed-by: amishchenko

This was changed in the past, but it seems this class was forgotten.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Wrong indentation and uniformize one method signature.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

This only means most of our error paths in this module were not working
(and generating exceptions).

Reviewed-by: amishchenko

Reviewed-by: amishchenko

This adds a docstring to the _autoconf.py file detailing how it's
generated (the other comment it's not visible in pydoc/epydoc).

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Quoting Michael: "why is this even working?"

Reviewed-by: imsnah,amishchenko

The default value of 'False' wasn't initialized properly. It doesn't
require initialization, but it's cleaner this way.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Two problems: the iallocator.hypervisor wasn't initialized to None in
the constructor, so pylint doesn't realize it's initialized later with
setattr.

Second, 'hypervisor' is a module, so we shouldn't use it as a variable.

Reviewed-by: amishchenko

And a small whitespace fix.

Reviewed-by: amishchenko

hypervisor is a module, so we shouldn't use it as an argument.

Reviewed-by: amishchenko

A few cases of wrong variable name.

Reviewed-by: amishchenko

This is a leftover from the abstraction of AdjustCandidatePool, and it
also requires the config lock, so it's better to remove it.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

For safety, we use the same algorithm as in disk count.

Reviewed-by: amishchenko

_RecursiveFindBD takes a parameter that isn't used; moreover, nowhere in
the SVN history can I find a case that it has been used.

As such, remove this parameter and fix its callers.

Reviewed-by: amishchenko

Reviewed-by: amishchenko