1. 04 Dec, 2008 8 commits
  2. 03 Dec, 2008 17 commits
  3. 02 Dec, 2008 15 commits
    • Guido Trotter's avatar
      Fix hooks_unittest with new rpc call structure · 7ccb3074
      Guido Trotter authored
      Reviewed-by: iustinp
      7ccb3074
    • Iustin Pop's avatar
      Fix gnt-cluster verify w.r.t. rpc changes · 25361b9a
      Iustin Pop authored
      This partially reorganizes the cluster verify LU:
        - introduce constants for the node verify rpc call
        - move from additional rpc calls to a single rpc call, the
          call_node_info, which gaters all data needed
      
      Also fix a small error (self.LogWarning instead of self.Warning).
      
      Reviewed-by: imsnah
      25361b9a
    • Iustin Pop's avatar
      Fix cluster rename · 55cf7d83
      Iustin Pop authored
      With the recent configwriter/ssconf changes, cluster rename becomes
      trivial. This patch gets rids of the code and just updates the cluster
      object.
      
      Reviewed-by: imsnah
      55cf7d83
    • Iustin Pop's avatar
      Convert rpc results to a custom type · 781de953
      Iustin Pop authored
      For a long time we had the problem that both RPC-layer errors and
      results from the remote node share the same "valuespace". This is
      because we shouldn't raise an exception when only one node failed
      (and lose the results from the other nodes).
      
      This patch attempts to address this problem by returning a special
      object from RPC calls, which separates the rpc-layer status and the
      remote results into different attributes.
      
      All the users of rpc (mainly cmdlib, but also bootstrap and the
      HooksMaster in mcpu) have been converted to this new model. The code has
      changed from, e.g. for boolean return types:
      
        if not self.rpc.call_...
      
      to
      
        result = self.rpc.call_
        if result.failed or not result.data:
           ^ rpc-layer error    |
                                - result payload
      
      While this is slightly more complicated, it will allow cleaner checks in
      the future; right now the code is just a plain port, without
      optimizations.
      
      There's also a "result.Raise()" which raises an OpExecError if the
      rpc-layer had errors.
      
      One side-effect of the patch is that now all return types from the
      rpc.call_ functions are of either RpcResult (single-node) or dicts of
      (node name, RpcResult); previously, some functions were returning
      different object types based on error status.
      
      The code passes burnin (after many retries :).
      
      Reviewed-by: imsnah
      781de953
    • Iustin Pop's avatar
      burnin: add instance reinstall and reboot · 00f91f29
      Iustin Pop authored
      These two operations were missing from burnin. The reboot is done with
      all valid modes (a new constant is added), and the reinstall is done
      both with and without specifying the OS (to account for the two code
      paths in the LU).
      
      Reviewed-by: imsnah
      00f91f29
    • Iustin Pop's avatar
      burnin: don't do export/import for file storage · a5e7be6b
      Iustin Pop authored
      This is currently not supported, so don't try to do export/import in
      this case.
      
      Reviewed-by: imsnah
      a5e7be6b
    • Guido Trotter's avatar
      KVMHypervisor add two missing 'constants.' · 8a74a9b9
      Guido Trotter authored
      Some calls to the HV parameters were missing them.
      
      Reviewed-by: imsnah
      8a74a9b9
    • Guido Trotter's avatar
      KVMHypervisor fix to case misspellings · 47387b1e
      Guido Trotter authored
      Reviewed-by: imsnah
      47387b1e
    • Guido Trotter's avatar
      cluster init: don't discard the hypervisor · 8f348e36
      Guido Trotter authored
      On cluster init if the user specifies a default hypervisor (with -t)
      which is not in the default list of enabled hypervisors (currently just
      xen-pvm) without explicitely specifying the list we silently override
      the choice.
      
      With this patch we set the list by default to just the required one, and
      we bail out should the list be hand-specified and not contain the
      default one. This still has an issue when the user doesn't specify a
      default hypervisor but specifies a list which doesn't include xen-pvm:
      in this case though we give an error, rather than silently discarding
      choices.
      
      Reviewed-by: imsnah
      8f348e36
    • Guido Trotter's avatar
      Use the new utils.CheckBEParams function · d4b72030
      Guido Trotter authored
      Where we used/forgot to validate beparams we now use the new common function.
      
      Reviewed-by: imsnah
      d4b72030
    • Guido Trotter's avatar
      Add utils.CheckBEParams · 42ce2e13
      Guido Trotter authored
      This function will be used in LUCreateInstance, LUSetInstanceParams,
      LUSetClusterParams and InitCluster to check the backend parameters
      validity and convert the relevant values to integer, without duplicating
      code. It lives in utils as bootstrap.py is calling it too.
      
      Reviewed-by: imsnah
      42ce2e13
    • Guido Trotter's avatar
      Add constants.VALUE_TRUE and VALUE_FALSE · 1817f49b
      Guido Trotter authored
      Reviewed-by: imsnah
      1817f49b
    • Guido Trotter's avatar
      Handle default/none values in hv/be params · 8edcd611
      Guido Trotter authored
      When a value is set to constants.VALUE_DEFAULT we have to remove it from
      the specific instance dict, as this way it will be populated from the
      cluster before. If instead it's specified as constants.VALUE_NONE we'll
      explicitely set it to None, to override its presence with a different
      values in such defaults. However, currently, we handle None values only
      for hvparams, that have a real use case for them.
      
      Reviewed-by: imsnah
      8edcd611
    • Guido Trotter's avatar
      SetInstanceParams: handle default/none values · 467ae11e
      Guido Trotter authored
      If the hv/be parameter lowercase value is set to "default" we'll pass
      constants.VALUE_DEFAULT, if it's set to "none" we'll pass
      constants.VALUE_NONE.
      
      Reviewed-by: imsnah
      467ae11e
    • Guido Trotter's avatar
      Update gnt-backup online help · 021f5d6f
      Guido Trotter authored
      --src-node and --src-dir are not mandatory anymore
      
      Reviewed-by: iustinp
      021f5d6f