1. 15 Oct, 2008 5 commits
  2. 14 Oct, 2008 31 commits
    • Guido Trotter's avatar
      gnt-backup: update for cluster parameters · b03efa30
      Guido Trotter authored
      - add backend and hypervisor parameters
      - fix beparams validation/passing
      - pass hypervisor and hvparams
      - remove deprecated flags
      
      Reviewed-by: iustinp
      b03efa30
    • Guido Trotter's avatar
      gnt-instance fix ValidateBeParams call · 7399cd55
      Guido Trotter authored
      ValidateBeParams does not return, but its return value is assigned to a
      variable which is never used. Avoid this assignment.
      
      Reviewed-by: iustinp
      7399cd55
    • Guido Trotter's avatar
      gnt-instance remove deprecated flags · 7ac1fc45
      Guido Trotter authored
      kernel, initrd, hvm_boot_order and vnc_bind_address are now hypervisor
      parameters and should not have their own flag. Moreover querying of
      vnc_bind_address should of course pass through the hv/ namespace.
      
      Reviewed-by: iustinp
      7ac1fc45
    • Iustin Pop's avatar
      grow-disk: wait until resync is completed · 6605411d
      Iustin Pop authored
      The patch adds a new ‘--no-wait-for-sync’ parameter to grow-disk similar
      to the one in instance add, and changes the default to wait.
      
      This is cleaner as at the moment when the command returns, we either
      have a fully synced disk or there is an error.
      
      This is a forward-port of rev 1183 on the 1.2 branch.
      
      Reviewed-by: ultrotter
      6605411d
    • Iustin Pop's avatar
      Burnin OpGrowDisk · 659712c8
      Iustin Pop authored
      With this patch both the os and the swap disk are grown during
      burnin. You can pass an increase size of 0 to skip this operation.
      
      and:
      
      burnin: don't try to grow diskless instances
      
          When burnin is run on a diskless instance, it fails when trying
          GrowDisk, because a non-existant disk cannot be grown. This patch
          disables the test for that disk template.
      
      This is a forward-port of revisions 1181 and 1606 on the 1.2 branch.
      
      Original author: ultrotter
      Reviewed-by: ultrotter
      659712c8
    • Iustin Pop's avatar
      Convert the KVM hypervisor to hvparams · 6b5605e8
      Iustin Pop authored
      I'm not sure which parameters it should use, I took all I saw in the
      code. Update: ultrotter says the list is OK for now.
      
      Reviewed-by: ultrotter
      6b5605e8
    • Iustin Pop's avatar
      Some fixes related to auto_balance · c0f2b229
      Iustin Pop authored
      Change the constant name to match the value (autobalance ->
      auto_balance).
      
      Also add the auto_balance header so that gnt-instance can list it.
      
      Reviewed-by: ultrotter
      c0f2b229
    • Iustin Pop's avatar
      Fix auto_balance and memory modification · 647a5d80
      Iustin Pop authored
      The secondary nodes should not be checked for free memory in case of non
      auto-balanced instances.
      
      This is a forward-port from rev 1567 on the 1.2 branch.
      
      Reviewed-by: ultrotter
      647a5d80
    • Iustin Pop's avatar
      Use the auto_balance in cluster verify · 3924700f
      Iustin Pop authored
      This patch changes the cluster verify in two ways:
        - do not use instances marked with auto_balance=False in N+1 memory
          checks
        - report, if any, the number of instances with auto_balance=False
      
      Forward port from rev 1562 on the 1.2 branch.
      
      Reviewed-by: ultrotter
      3924700f
    • Iustin Pop's avatar
      Fix ordering of instance/nodes · c1f1cbb2
      Iustin Pop authored
      After the locking changes, and the partial locking of nodes, the
      instance/node list is not ordered anymore. Reorder so that it behaves as
      before.
      
      Reviewed-by: ultrotter
      c1f1cbb2
    • Iustin Pop's avatar
      Remove old instance attributes · bf766476
      Iustin Pop authored
      Reviewed-by: ultrotter
      bf766476
    • Iustin Pop's avatar
      Change over to beparams · 338e51e8
      Iustin Pop authored
      This big patch changes the master code to use the beparams. Errors might
      have crept in, but it passes a small burnin.
      
      Reviewed-by: ultrotter
      338e51e8
    • Iustin Pop's avatar
      Change the backend to use the beparams · 51de46bf
      Iustin Pop authored
      The backend.FinalizeExport function is changed to use the beparams
      instead of the instance attributes. Future enhancements should be done
      in order to export and import/reuse the whole be/hv params.
      
      Reviewed-by: ultrotter
      51de46bf
    • Iustin Pop's avatar
      Change hypervisors to use the beparams · 8b3fd458
      Iustin Pop authored
      This patch changes the hypervisor functions to use the beparams dict
      instead of the instance attributes.
      
      Reviewed-by: ultrotter
      8b3fd458
    • Iustin Pop's avatar
      Correctly fill the beparams too over RPC · 5b442704
      Iustin Pop authored
      As for the hvparams, we need to replace the sent instance beparams.
      
      Reviewed-by: ultrotter
      5b442704
    • Iustin Pop's avatar
      Add cli function for beparams validation · a604f165
      Iustin Pop authored
      This is used to validate the parameters in both “gnt-instance add” and
      “gnt-backup import”.
      
      Reviewed-by: ultrotter
      a604f165
    • Iustin Pop's avatar
      Modify the beparams constants · cd3ab26e
      Iustin Pop authored
      Memory is renamed for easier use.
      
      Reviewed-by: ultrotter
      cd3ab26e
    • Iustin Pop's avatar
      Fix a bug with instance creation and hvparameters · 8705eb96
      Iustin Pop authored
      When creating an instance, we need to check not the opcode hvparams, but
      the final, filled hvparams against validity. While we do this for the
      remote node calls (i.e. ValidateParams), we didn't do this for
      CheckParameterSyntax.
      
      Reviewed-by: imsnah
      8705eb96
    • Iustin Pop's avatar
      Allow instance info to only query the config file · 57821cac
      Iustin Pop authored
      This patch adds a new '-s' parameter to ‘gnt-instance info’ that makes
      it return only 'static' information. This is much faster, especially for
      drbd instances.
      
      This is a forward-port of rev 1570 on the ganeti-1.2 branch, resending
      due to some conflicts.
      
      Reviewed-by: imsnah
      57821cac
    • Iustin Pop's avatar
      Convert gnt-instance info to the hvparams model · 24838135
      Iustin Pop authored
      Some informations are not printed nicely (e.g. “virtual CDROM: False”),
      but this is the first step.
      
      Reviewed-by: imsnah
      24838135
    • Iustin Pop's avatar
      Change gnt-instance modify to the hvparams model · 74409b12
      Iustin Pop authored
      Reviewed-by: imsnah
      74409b12
    • Iustin Pop's avatar
      Change gnt-instance list to the hvparams model · 5018a335
      Iustin Pop authored
      This is just a change of the various hvm_ and pvm parameters to the hv
      model. Parameters are queried via hv/$name or via the whole dict as
      returned by hvparams.
      
      Reviewed-by: ultrotter,imsnah
      5018a335
    • Iustin Pop's avatar
      Switch instance hypervisor parameters to hvparams · 6785674e
      Iustin Pop authored
      This big patch changes instance create to the new hvparams structure.
      Old parameters are removed, so old jobs or old instances file will break
      current clusters.
      
      Reviewed-by: ultrotter
      6785674e
    • Iustin Pop's avatar
      Temporary fix for dual hvm/pvm instances · f23b5ae8
      Iustin Pop authored
      We have a problem with the current model of combining instance lists
      from multiple hypervisors: we don't allow duplicates, but "xm list"
      gives the same output for both pvm and hvm. This is a lack in the actual
      xen hypervisor implementation/split between pvm and hvm, but for now we
      implement a weak workaround: identical instance params will be allowed,
      and merged. This breaks because there is a delta in listing, and should
      be treated as temporary workaround only.
      
      Note that there are two cases for duplicate instance: the above one (xen
      is the same, whether pvm or hvm), and the other case, the real error,
      when we have two different hypervisors reporting the same instance name.
      The latter case needs to be handled better (not by refusing to list the
      instances in the backend).
      
      Reviewed-by: ultrotter
      f23b5ae8
    • Iustin Pop's avatar
      Implement FillHV for instance-related rpc calls · 26ba2bd8
      Iustin Pop authored
      We fill the instance hvparams with cluster defaults, and send a modified
      dict over the wire to the node methods - they don't know anything about
      cluster defaults versus instance parameters.
      
      Reviewed-by: ultrotter
      26ba2bd8
    • Iustin Pop's avatar
      Export the hypervisor.ValidateParameters over RPC · 6217e295
      Iustin Pop authored
      The newly-added node-specific ValidateParams hypervisor method is
      exported over RPC, using the semi-standard (success, message) return
      value. Multi-node call, so that we call on both primary and secondary at
      once.
      
      Reviewed-by: ultrotter
      6217e295
    • Iustin Pop's avatar
      Implement the new hypervisor API in base/xen · f48148c3
      Iustin Pop authored
      This patch adds the new methods CheckParameterSyntax and the
      ValidateParameters in the base and xen hypervisors. It also changes the
      xen hypervisor to use the new hvparams field on instance.
      
      Reviewed-by: imsnah
      f48148c3
    • Michael Hanselmann's avatar
      Get rid of httperror module · 937e4814
      Michael Hanselmann authored
      This was a leftover from the early days of the remote API in Ganeti 1.2.
      
      Reviewed-by: ultrotter
      937e4814
    • Iustin Pop's avatar
      Implement parameter removal in SplitKeyVal · fcd62d84
      Iustin Pop authored
      This patch adds paramter removal in SplitKeyVal, by prefixing a
      value-less key with "-"; this is needed in resetting parameters back to
      cluster defaults, but care must be applied now that None can come from
      the parser.
      
      Reviewed-by: imsnah
      fcd62d84
    • Iustin Pop's avatar
      Add the hv/be params object attributes · 5bf7b5cf
      Iustin Pop authored
      This patch adds the instance and cluster be/hvparams attributes, and the
      Fill* methods on the cluster object. Nothing else is changes, except
      that these attributes exist now on the objects.
      
      Reviewed-by: ultrotter
      5bf7b5cf
    • Iustin Pop's avatar
      Add constants for the HV/BE parameter names · e64b8beb
      Iustin Pop authored
      Since we don't want the string values of the parameters (e.g.
      “kernel_path”) spread over the code, we introduce constants for these.
      
      Reviewed-by: ultrotter,schreiberal
      e64b8beb
  3. 13 Oct, 2008 4 commits
    • Iustin Pop's avatar
      Fix a few rpc-related errors · 16ad1a83
      Iustin Pop authored
      This fixes:
        - whitespace change, double lines between methods
        - duplication of call_upload_file, introduced by mistake in rev 1795
          and which went undetected because of the many changes in that ref
          (only diff -b shows it clearly)
        - call_instance_info didn't pass the hypervisor name parameter, but
          the backend requires it
      
      Reviewed-by: ultrotter
      16ad1a83
    • Iustin Pop's avatar
      Add two new options types for CLI usage · a8469393
      Iustin Pop authored
      For the new 2.0-style command line options, we need to parse strings of
      the type:
        ident:key=val[,...]
      and
        key=val[,...]
      
      This patch adds two new option builders for these two, which return
      (ident, {key=val,}) and {key=val,} for the above two formats. It also
      handles specially constructs of type “key” (val is set to True) and
      “no_key” (val is set to False, and the ‘no_’ prefix is stripped).
      
      Reviewed-by: imsnah
      a8469393
    • Iustin Pop's avatar
      Some small typos on design docs · 2d8ed1fe
      Iustin Pop authored
      Reviewed-by: imsnah
      2d8ed1fe
    • Iustin Pop's avatar
      Update the cluster parameters design doc · ca8ac26a
      Iustin Pop authored
      As discussed, we update the design doc with the three classes of
      parameters and other changes.
      
      Reviewed-by: imsnah
      ca8ac26a