1. 08 Oct, 2007 8 commits
  2. 04 Oct, 2007 5 commits
  3. 03 Oct, 2007 2 commits
  4. 02 Oct, 2007 2 commits
  5. 01 Oct, 2007 1 commit
  6. 28 Sep, 2007 1 commit
  7. 27 Sep, 2007 5 commits
  8. 26 Sep, 2007 1 commit
    • Michael Hanselmann's avatar
      Enhance QA. · 5d640672
      Michael Hanselmann authored
      - Test “gnt-backup export” and “gnt-backup import”.
      - Move “ResolveInstanceName” to qa_utils.py.
      - Fix tests for “ganeti-watcher”.
      - Make instance shutdown and startup configurable.
      Reviewed-by: schreiberal
  9. 25 Sep, 2007 4 commits
  10. 24 Sep, 2007 3 commits
  11. 21 Sep, 2007 5 commits
    • Iustin Pop's avatar
      Change class hierarchy in objects.py · ec29fe40
      Iustin Pop authored
      It makes sense to make the TaggableObject a child of the ConfigObject,
      since in this case we can derive the Instance, Node and Cluster objects
      only from the TaggableObject and have a cleaner hierarchy.
      For consistency child classes will have to declare their slots by adding
      their parents on top.
      Reviewed-by: imsnah,ultrotter
    • Iustin Pop's avatar
      Remove requirement that host names are FQDN · 89e1fc26
      Iustin Pop authored
      We currently require that hostnames are FQDN not short names
      (node1.example.com instead of node1). We can allow short names as long
        - we always resolve the names as returned by socket.gethostname()
        - we rely on having a working resolver
      These issues are not as big as may seem, as we only did gethostname() in
      a few places in order to check for the master; we already required
      working resolver all over the code for the other nodes names (and thus
      requiring the same for the current node name is normal).  The patch
      moves some resolver calls from within execution path to the checking
      path (which can abort without any problems). It is important that after
      this patch is applied, no name resolving is called from the execution
      path (LU.Exec() or other code that is called from within those methods)
      as in this case we get much better code flow.
      This patch also changes the functions for doing name lookups and
      encapsulates all functionality in a single class.
      The final change is that, by requiring working resolver at all times, we
      can change the 'return None' into an exception and thus we don't have to
      check manually each time; only some special cases will check
      (ganeti-daemon and ganeti-watcher which are not covered by the
      generalized exception handling in cli.py). The code is cleaner this way.
      Reviewed-by: imsnah
    • Iustin Pop's avatar
      Move a constant from ganeti-master to constants.py · 619fdc8e
      Iustin Pop authored
      The EXIT_NODESETUP_ERROR is a useful constant and ganeti-watcher could
      use it too. This patch moves it to constants.py and modifed the
      ganeti-master script to use it from there.
      Reviewed-by: imsnah
    • Iustin Pop's avatar
      Fix tools/burnin w.r.t. OpCreateInstance.ip_check · e9f745aa
      Iustin Pop authored
      Since we added a new, required parameter to OpCreateInstance, we need to
      update burnin to build the correct opcode.
      Reviewed-by: schreiberal
    • Iustin Pop's avatar
      Add __slots__ on TaggableObject · 2057f6c7
      Iustin Pop authored
      Unless we use __slots__ on all parents, we don't get the benefits that
      __slots__ bring. This patch adds this attribute to the TaggableObject so
      that Instances, Nodes and the Clusters behave as intended.
      Reviewed-by: schreiberal,imsnah
  12. 20 Sep, 2007 1 commit
    • Iustin Pop's avatar
      Ask for confirmation when touching multiple instances · 804a1e8e
      Iustin Pop authored
      This patch makes the new startup/shutdown multi-instance operations to
      ask for confirmation when touching more than one instance (and unless
      --force-multi is given).
      The code is not very short, but it does present a nice (IMO) user
      Reviewed-by: ultrotter
  13. 19 Sep, 2007 2 commits
    • Iustin Pop's avatar
      Improve the cli.AskUser() function · 47988778
      Iustin Pop authored
      This patch improves the AskUser function by allowing it to:
       - choose from multiple choices (instead of only y/n)
       - give help to the user
       - preserve line breaks and whitespace formatting in the message
      With this patch, an instance removal looks like this:
      root@xen-test1-4:~# gnt-instance remove tsetest1
      This will remove the volumes of the instance tsetest1 (including
      mirrors), thus removing all the data of the instance. Continue?
      y/[n]/?: ?
       y - Perform the operation
       n - Do not perform the operation
      This will remove the volumes of the instance tsetest1 (including
      mirrors), thus removing all the data of the instance. Continue?
      y/[n]/?: y
      The patch also removed the _ask_user member of the opts argument, since
      external code was using it (and thus it makes no sense for it to be a
      private member); now gnt-* scripts are using the AskUser function
      Reviewed-by: ultrotter
    • Iustin Pop's avatar
      Allow 'add instance' to not start the new instance · bdd55f71
      Iustin Pop authored
      This patch allows 'gnt-instance add' to not start the newly-created
      instance. It also allow 'gnt-instance add' and 'gnt-backup import' to
      not check for IP conflicts (only when not starting the instance).
      Reviewed-by: ultrotter