Reviewed-by: iustinp

Otherwise it would be done on the first read/write operation, making
error handling more difficult (such as EOF during handshake).

Reviewed-by: iustinp

Reviewed-by: iustinp

Also add a comment next to the place where the SSL connection is shut
down.

Reviewed-by: iustinp

We should initialized the _last_cluster_serial in the constructor too (just to
be consistent).

Reviewed-by: amishchenko

This was changed in the past, but it seems this class was forgotten.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Wrong indentation and uniformize one method signature.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

This only means most of our error paths in this module were not working
(and generating exceptions).

Reviewed-by: amishchenko

Reviewed-by: amishchenko

This adds a docstring to the _autoconf.py file detailing how it's
generated (the other comment it's not visible in pydoc/epydoc).

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Quoting Michael: "why is this even working?"

Reviewed-by: imsnah,amishchenko

The default value of 'False' wasn't initialized properly. It doesn't
require initialization, but it's cleaner this way.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Two problems: the iallocator.hypervisor wasn't initialized to None in
the constructor, so pylint doesn't realize it's initialized later with
setattr.

Second, 'hypervisor' is a module, so we shouldn't use it as a variable.

Reviewed-by: amishchenko

And a small whitespace fix.

Reviewed-by: amishchenko

hypervisor is a module, so we shouldn't use it as an argument.

Reviewed-by: amishchenko

A few cases of wrong variable name.

Reviewed-by: amishchenko

This is a leftover from the abstraction of AdjustCandidatePool, and it
also requires the config lock, so it's better to remove it.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

For safety, we use the same algorithm as in disk count.

Reviewed-by: amishchenko

_RecursiveFindBD takes a parameter that isn't used; moreover, nowhere in
the SVN history can I find a case that it has been used.

As such, remove this parameter and fix its callers.

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Instead of relying that the usage of the parameter is ok with mutable
default parameters, let's just make it safer..

Reviewed-by: amishchenko

Reviewed-by: amishchenko

Remove unused vars

Reviewed-by: amishchenko

Reviewed-by: imsnah

In the iteration we don't care about the node names, so we change the
for loop to be over the values (and not itervalues).

Reviewed-by: amishchenko

It'll be queried from other classes.

Reviewed-by: iustinp

It's more appropriate.

Reviewed-by: iustinp

This patch should fix all outstanding epydoc parsing errors; as such, we
switch epydoc into verbose mode so that any new errors will be visible.

Reviewed-by: imsnah

epydoc seems to be mightily confused by decorators and how they change
functions (it starts mixing the parameters of the decorated function
into the decorator itself); so we want it to parse only and not look at
the objects themselves.

Reviewed-by: ultrotter

Reviewed-by: iustinp

Reviewed-by: iustinp

This is a leftover from old code.

Reviewed-by: iustinp

This solves a problem with many concurrent requests. By default, 1024
is the maximum backlog on Linux kernels. We limit the number of clients
through MAX_CHILDREN, too. The idea of just increasing the backlog is
taken from lighttpd.

Reviewed-by: amishchenko

Adding compression to larger amounts of data is more efficient than
transferring it (len(nodes) - 1) times over the network without
compression. We were able to compress a 800KB config file to about
30 KB, which is about 40 KB with Base64 encoding (required due to
the way SimpleJson handles strings).

Reviewed-by: ultrotter