1. 01 Nov, 2007 4 commits
    • Guido Trotter's avatar
      Separate OS status and path · 5efc50fc
      Guido Trotter authored
      Make _DiagnoseOSStatus only return a status message for the OS diagnose object
      and create a new _DiagnoseOSPath function to get the path out. This will let us
      be more flexible in the messages we display to the user.
      
      Reviewed-By: imsnah
      5efc50fc
    • Iustin Pop's avatar
      Whitespace fixes · 5d0fe286
      Iustin Pop authored
      Reviewed-by: ultrotter
      5d0fe286
    • Michael Hanselmann's avatar
      Cleanup colouring functions. · dfe11bad
      Michael Hanselmann authored
      Make the code somewhat smaller. Disable disk failure test for master for now.
      
      Reviewed-by: schreiberal
      
      dfe11bad
    • Michael Hanselmann's avatar
      Cleanup QA scripts. · b1ffe1eb
      Michael Hanselmann authored
      - Split main() function into several small ones.
      - Current work on disk failure tests. This is not yet finished.
      - Fix small typo in qa_node.py.
      
      Reviewed-by: schreiberal
      
      b1ffe1eb
  2. 31 Oct, 2007 6 commits
    • Iustin Pop's avatar
      Revert "Implement multi-failover options" · 80de0e3f
      Iustin Pop authored
      This reverts commit 289, as the node failover functionality was already
      implemented in gnt-node (as opposed to gnt-instance). My mistake.
      
      Reviewed-by: ultrotter
      80de0e3f
    • Michael Hanselmann's avatar
      Fix usage of OpReplaceDisks. · 22d31e49
      Michael Hanselmann authored
      Reviewed-by: iustinp
      
      22d31e49
    • Iustin Pop's avatar
      Small improvements to multi-instance selections · bcee9cb4
      Iustin Pop authored
      This patch fixes the documentation in a few cases and adds handling of
      the situation where no instance is selected due to too restrictive
      options given.
      
      Reviewed-by: imsnah
      bcee9cb4
    • Iustin Pop's avatar
      Implement multi-failover options · 36c87212
      Iustin Pop authored
      This patch adds the same style of multi-instance selection as in
      shutdown/startup to the failover subcommand, with the exception that we
      cannot failover with --node or --all (it doesn't make sense).
      
      Reviewed-by: imsnah
      36c87212
    • Iustin Pop's avatar
      More sane handling of errors during failover · 24a40d57
      Iustin Pop authored
      Currently we ignore errors on instance shutdown (on the source node)
      during instance failover. We should do this only if the user gave a
      command line options allowing this, as it's a dangerous thing to do.
      
      This patch fixes this by using the same "--ignore-consistency" option
      for deciding whether to continue or abort. It also expands a bit the man
      page.
      
      Reviewed-by: imsnah
      24a40d57
    • Iustin Pop's avatar
      Fix bridge checking in instance failover · 50ff9a7a
      Iustin Pop authored
      The current code checks the bridge on the primary node of the instance,
      but we need to check it on the destination node.
      
      This was caught by testing failover with a down primary node.
      
      Reviewed-by: imsnah
      50ff9a7a
  3. 30 Oct, 2007 1 commit
  4. 29 Oct, 2007 8 commits
  5. 28 Oct, 2007 1 commit
    • Guido Trotter's avatar
      Import two itertools recipes · 78feb6fb
      Guido Trotter authored
      The two function 'any' and 'all' are copied as-is from the python 2.4
      documentation for the itertools module. They are useful (and are already
      builtin function in python 2.5).
      
      Reviewed-by: iustinp
      
      78feb6fb
  6. 26 Oct, 2007 1 commit
  7. 25 Oct, 2007 1 commit
    • Iustin Pop's avatar
      Modify two mirror-device related rpc calls · 153d9724
      Iustin Pop authored
      The two calls mirror_addchild and mirror_removechild take only one child
      for addition/removal. While this is enough for our md usage, for local
      disk replacement in drbd8, we need to be able to specify both the data
      and metadata device. This patch modifies these two rpc calls (and their
      backend implementation and their usage in cmdlib) to take a list of
      children to add/remove.
      
      Reviewed-by: imsnah
      153d9724
  8. 24 Oct, 2007 8 commits
    • Iustin Pop's avatar
      Initial implementation of drbd8 template type · a1f445d3
      Iustin Pop authored
      This is a partially working drbd8 template type. It does:
        - add/remove
        - startup/failover/shutdown
      
      Not working is replace disks, which needs custom code for this template.
      
      Reviewed-by: imsnah
      a1f445d3
    • Iustin Pop's avatar
      Allow DRBD8 to sync after sb1-pri with no changes · f38478b2
      Iustin Pop authored
      Currently the way we shutdown or startup disks seems to make DRBD8
      unhappy. Until we rewrite the sequence of (de)activation, allow DRBD to
      connect after a sb1-pri condition with no changes to the data.
      
      Reviewed-by: imsnah
      f38478b2
    • Iustin Pop's avatar
      Fix a disk handling bug triggered by failover · b352ab5b
      Iustin Pop authored
      This leaves an instance's disks configured for the primary node as after
      disk activation we want to start the instance anyway. As such,
      _GatherBlockDevs in backend.py will need the disks configured for the
      primary.
      
      Reviewed-by: imsnah
      b352ab5b
    • Iustin Pop's avatar
      Add DRBD8 class for handling drbd version 8.x · a2cfdea2
      Iustin Pop authored
      This duplicates some code from the DRBDev class, but not very much, and
      it will be expanded with the new functionality available for the 8.x
      version. Currently the code is not accessible outside the module.
      
      This patch introduces a dependency on the pyparsing module.
      
      Reviewed-by: imsnah
      a2cfdea2
    • Iustin Pop's avatar
      Move/rename _IsValidMeta to base drbd class · ae26a287
      Iustin Pop authored
      The DRBDev._IsValidMeta only checks for the metadata device size. Since
      this is a useful check (but not complete) for DRBD8, move it to the base
      class and name it _CheckMetaSize.
      
      Reviewed-by: imsnah
      ae26a287
    • Iustin Pop's avatar
      More abstractions from DRBD7 to base class · 5a47ad20
      Iustin Pop authored
      This moves the _SetFromMinor and _MassageProcData to the base class.
      
      Reviewed-by: imsnah
      5a47ad20
    • Iustin Pop's avatar
      Improve out-of-minors handling · 0caf6485
      Iustin Pop authored
      Currently, the out-of-minors handling is not very good: though both MD
      and DRBD functions for finding an unused minor can return None, only the
      DRBD code checks for this case.
      
      This patch improves this by making the functions _FindUnusedMinor raise
      an error instead of None, and gets rid of the one manual check for the
      return value.
      
      Reviewed-by: imsnah
      0caf6485
    • Iustin Pop's avatar
      Move some methods from DRBDev to BaseDRBD · 770fe0f9
      Iustin Pop authored
      Since some of the methods and constants are valid for both 0.7 and 8.x
      versions, we move them to the base class.
      
      Reviewed-by: imsnah
      770fe0f9
  9. 19 Oct, 2007 3 commits
    • Iustin Pop's avatar
      Some tiny style fixes · aa4260ca
      Iustin Pop authored
      Reviewed-by: imsnah
      aa4260ca
    • Iustin Pop's avatar
      Split some DRBD functionality based on versions · 0f7f32d9
      Iustin Pop authored
      This is a small split of some functionality from the DRBDev class into a
      base drbd class that holds just a few things, in order to make migration
      to drbd 8.x easier.
      
      Reviewed-by: imsnah
      0f7f32d9
    • Iustin Pop's avatar
      Abstract more strings values into constants · fe96220b
      Iustin Pop authored
      Currently, the disk types are defined using constants in the code.
      Convert those into constants so that we can easily find them and check
      their usage.
      
      Note that we don't rename the values of the constants as they are used
      in the configuration file, and as such it's best to leave them as they
      are.
      
      Reviewed-by: imsnah
      fe96220b
  10. 18 Oct, 2007 3 commits
    • Michael Hanselmann's avatar
      Implement disk failure QA test. · e8ae0c20
      Michael Hanselmann authored
      Testing failure on the primary node is currently disabled due to drbd problems.
      
      Reviewed-by: iustinp
      
      e8ae0c20
    • Alexander Schreiber's avatar
      Patch series for reboot feature, part 3 · 579d4337
      Alexander Schreiber authored
      This patch series implements the reboot command for gnt-instance. It
      supports three types of reboot: soft (hypervisor reboot), hard (instance
      config rebuild and reboot) and full (full instance shutdown and startup
      again).
      
      This patch contains the gnt-instance script and the man page for it.
      
      Reviewed-by: iustinp
      
      579d4337
    • Alexander Schreiber's avatar
      Patch series for reboot feature, part 2 · bf6929a2
      Alexander Schreiber authored
      This patch series implements the reboot command for gnt-instance. It
      supports three types of reboot: soft (hypervisor reboot), hard (instance
      config rebuild and reboot) and full (full instance shutdown and startup
      again).
      
      This patch contains the opcode and lu part.
      
      Reviewed-by: iustinp
      
      bf6929a2
  11. 17 Oct, 2007 2 commits
    • Alexander Schreiber's avatar
      Patch series for reboot feature, part 1 · 007a2f3e
      Alexander Schreiber authored
      This patch series implements the reboot command for gnt-instance. It
      supports three types of reboot: soft (hypervisor reboot), hard (instance
      config rebuild and reboot) and full (full instance shutdown and startup
      again).
      
      This patch contains the backend and rpc part of the patch.
      
      
      Reviewed-by: iustinp
      
      007a2f3e
    • Alexander Schreiber's avatar
      Fix unit tests for hooks. · fafa5990
      Alexander Schreiber authored
      Reviewed-by: imsnah
      
      fafa5990
  12. 16 Oct, 2007 2 commits