Skip to content
Snippets Groups Projects
  1. Sep 04, 2012
    • Iustin Pop's avatar
      Move generated htools test stubs to htest/ · 189b51fa
      Iustin Pop authored
      
      This moves the last (I think) htools-related bits out of test/ under
      htest/.
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      189b51fa
    • Iustin Pop's avatar
      Move shelltests from test/ to htest/shelltests/ · b8a9c7f2
      Iustin Pop authored
      
      This is another rather trivial patch, moving all the (htools)
      shelltests to their own directory.
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      b8a9c7f2
    • Iustin Pop's avatar
      Move haskell test code to htest/ · f0f3a6df
      Iustin Pop authored
      
      This is the first commit of a series that will attempt to cleanup the
      test code organisation, which evolved somewhat organically from the
      initial pure htools functionality.
      
      The proposed organisation of the tree will be as follows:
      
      - htools (or maybe renamed to haskell or hs): only production code
      - htest: top-level test directory, containing test.hs, static helper
        scripts, etc.
      - htest/Ganeti/*.hs: modules implementing the actual test properties
        and test cases for the correspondingly-named production code modules
      - htest/data: containing test data files for the test cases
      
      This particular patch moves all the test code (test.hs, hpc-htools.hs
      symlink) and helper scripts (offline-test.sh, etc.) from htools/ to
      htest/, while updating the files themselves (if they had paths
      mentioning htools/), .gitignore and the Makefile.
      
      The only special mention is that in Makefile, we used to have a BINARY
      shell variable in binary build rule; that was computed via stripping
      `htools/' prefix; I've cleaned that and replaced with $(notdir $@);
      even though it's duplicated a few times, it leads to more readable
      make output (and easier to copy-paste).
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      f0f3a6df
  2. Mar 26, 2012
    • Iustin Pop's avatar
      Add trivial tests for gnt-* cli · 30f2802f
      Iustin Pop authored
      
      While testing some other stuff, I realised that the gnt-* commands
      could be broken (as in, the script fails with syntax errors), but make
      check doesn't detect it. Since we have shelltest, we can now add
      trivial tests for this case.
      
      One downside is that starting the scripts seems to be much slower
      than the htools binaries, so we can't add as many tests.
      
      The other downside is that shelltest is now required for all
      development work, but I think this is a small disadvantage compared to
      the increased testing possibilities.
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      30f2802f
  3. Mar 22, 2012
    • Iustin Pop's avatar
      Fix out-of-tree builds · 3e5012c6
      Iustin Pop authored
      
      The new shell tests do not succeed out-of-tree, due to static paths
      and other issues. This trivial patch fixes these issue, make distcheck
      now passes.
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      3e5012c6
    • Iustin Pop's avatar
      Convert manual shell tests to shelltestrunner · 53d4cdf1
      Iustin Pop authored
      
      This is more of a RFC… Basically most of the shell-based tests are
      converted from exec+grep to shelltestrunner.
      
      Things are not all fine and nice though:
      
      - we have dependencies between tests, as some generate some data files
        needed later; this is not nice, and we depend on serial execution in
        testrunner
      - we can still fail with no so nice messages in the offline-test
        script (when we generate most of the data)
      
      But overall, I think the tests are much nicer to
      define/read/debug:
      
      - each test is standalone, with the only dependency being an optional
        input data file; this is much better than a single monolithic shell
        script
      - in case of failures, the failure is clearly shown by shell test,
        both for exit code and stdout/stderr
      - shelltest can run in --debug mode, where the exact details are shown
        much better than the alternative of "set -x" for the shell script
      
      Comments welcome!
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      53d4cdf1
  4. Mar 15, 2012
  5. Mar 13, 2012
  6. Mar 05, 2012
  7. Nov 01, 2010
  8. Oct 27, 2010
  9. Apr 21, 2010
  10. Dec 28, 2009
  11. Oct 10, 2007
    • Iustin Pop's avatar
      Remove the shebang from modules · 2f31098c
      Iustin Pop authored
      Since modules are not directly executables, remove the shebang from
      them. This helps with lintian warnings.
      
      Also make the autogenerated _autoconf.py contain two comment lines at
      the beginning, like the other modules.
      
      Reviewed-by: ultrotter
      2f31098c
  12. Jul 16, 2007
Loading