Convert manual shell tests to shelltestrunner
This is more of a RFC… Basically most of the shell-based tests are converted from exec+grep to shelltestrunner. Things are not all fine and nice though: - we have dependencies between tests, as some generate some data files needed later; this is not nice, and we depend on serial execution in testrunner - we can still fail with no so nice messages in the offline-test script (when we generate most of the data) But overall, I think the tests are much nicer to define/read/debug: - each test is standalone, with the only dependency being an optional input data file; this is much better than a single monolithic shell script - in case of failures, the failure is clearly shown by shell test, both for exit code and stdout/stderr - shelltest can run in --debug mode, where the exact details are shown much better than the alternative of "set -x" for the shell script Comments welcome! Signed-off-by:Iustin Pop <iustin@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
Showing
- Makefile.am 13 additions, 1 deletionMakefile.am
- htools/offline-test.sh 28 additions, 159 deletionshtools/offline-test.sh
- test/htools-balancing.test 67 additions, 0 deletionstest/htools-balancing.test
- test/htools-basic.test 21 additions, 0 deletionstest/htools-basic.test
- test/htools-dynutil.test 19 additions, 0 deletionstest/htools-dynutil.test
- test/htools-excl.test 10 additions, 0 deletionstest/htools-excl.test
- test/htools-hail.test 77 additions, 0 deletionstest/htools-hail.test
- test/htools-hspace.test 8 additions, 0 deletionstest/htools-hspace.test
- test/htools-invalid.test 35 additions, 0 deletionstest/htools-invalid.test
- test/htools-multi-group.test 35 additions, 0 deletionstest/htools-multi-group.test
- test/htools-no-backend.test 21 additions, 0 deletionstest/htools-no-backend.test
- test/htools-rapi.test 11 additions, 0 deletionstest/htools-rapi.test
- test/htools-single-group.test 24 additions, 0 deletionstest/htools-single-group.test
- test/htools-text-backend.test 30 additions, 0 deletionstest/htools-text-backend.test
Loading
Please register or sign in to comment