1. 20 Jul, 2012 1 commit
  2. 19 Jul, 2012 21 commits
  3. 18 Jul, 2012 3 commits
  4. 17 Jul, 2012 1 commit
  5. 13 Jul, 2012 4 commits
  6. 11 Jul, 2012 2 commits
  7. 07 Jul, 2012 1 commit
  8. 06 Jul, 2012 7 commits
    • Iustin Pop's avatar
      Replace a few explicit case expressions · 76ae2e5b
      Iustin Pop authored
      
      
      Since we're just talking about converting Maybe into another monad, we
      can do that via the maybe function, instead of explicit casing.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      76ae2e5b
    • Iustin Pop's avatar
      Fix Haskell coverage results · 96eccc1f
      Iustin Pop authored
      
      
      There are two current issues with the coverage values:
      
      - we don't import all modules, thus leading to incomplete
        coverage results (too optimistic);
      - we use hpc in its default mode (intersection), which means that even
        modules which do have coverage results but are not used in all
        binaries we test will be dropped from the results; thanks to Agata,
        passing --union to hpc is enough to have better results (don't
        remember why this wasn't there in the first place…)
      
      After adding more modules to the import list and fixing the combining
      mode, we now have a complete list of modules in coverage results, many
      with zero coverage, so our overall coverage has dropped to about 60%.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      96eccc1f
    • Iustin Pop's avatar
      Also compute Haskell tags in "make tags" · 2db53645
      Iustin Pop authored
      
      
      Note however that this won't work correctly with older compilers, due
      to ghc issue #4256; however, it's a handy way to build complete a TAGS
      file for Emacs.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      2db53645
    • Iustin Pop's avatar
      Cleanup the QC.hs file w.r.t. compiler options · fce98abd
      Iustin Pop authored
      
      
      Currently, we build the Haskell unittests with custom GHC flags,
      because we (I) were quite lazy when initially writing the
      unittests. This is not a problem for the tests themselves, but it
      creates problem when (for example) one would want to pass all
      $(HS_LIB_SRCS) to the compilers; this is not doable unless we
      "degrade" the flags used for all modules, instead of just for QC.hs.
      
      So we do two things to fix this:
      
      - first, we go and add type declaration to all functions that were
        missing them (in QC), and fix the couple of cases of monomorphism
        restrictions; this gets us rid of -fno-warn-missing-signature and
        -fno-warn-monomorphism-restriction
      - then, we move the actually important remaining options
        (-fno-warn-orphans and -fno-warn-unused-imports; see the explanation
        for the latter in the newly added FIXME) to a compiler pragma in the
        file, so that when building the unittests only this file is using
        the extra options
      
      And finally we can then drop the other unused options
      (-fno-warn-missing-methods anmd -Wwarn), leaving htools/test use
      simply -fhpc. This is more in-line with the other files, and thus we
      can handle all of HS_LIB_SRCS the same.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      fce98abd
    • René Nussbaumer's avatar
      RAPI regression beparams/memory fix · 28a45bfc
      René Nussbaumer authored
      
      
      For compatibility with the old Ganeti version, we want to keep the
      beparams/memory field around for another release. This patch fixes this
      regression.
      Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      28a45bfc
    • Agata Murawska's avatar
      Installation instructions update · fc6075dd
      Agata Murawska authored
      
      
      This patch aims at improving documentation for installing ganeti - both for users and developers.
      Signed-off-by: default avatarAgata Murawska <agatamurawska@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      fc6075dd
    • Iustin Pop's avatar
      Fix Query2.hs to compile without warnings · b647b6d7
      Iustin Pop authored
      
      
      Since this is not yet used by any targets, we didn't detect yet the
      compilation warnings. Just trivial exports/imports cleanup.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      b647b6d7