1. 13 May, 2008 4 commits
    • Iustin Pop's avatar
      CLI: remove command opts/args in "gnt-X" · 57d0151e
      Iustin Pop authored
      [Forward-port of the 1.2 branch patch]
      
      This patch removes all the parameters and options from the output
      "gnt-X" (i.e. the subcommand list for command). This is done in order to
      uniformize the output, currently only some parameters are shown and they
      are not always consistent (e.g. required versus important parameters).
      
      Reviewed-by: ultrotter
      57d0151e
    • Iustin Pop's avatar
      Watcher: do not activate disks for started instances · eee1fa2d
      Iustin Pop authored
      Currently the watcher runs first the instance startup and then the
      boot-id method of disk reactivation. However, irrelevant of the fact
      that a node has rebooted or not, if we just started an instance, there's
      no need for its disks to be activated again, since the start instance
      has done that (if it is at all possible).
      
      The patch modifies the watcher to remember all started instances and not
      run activate-disks for them.
      
      Reviewed-by: ultrotter
      eee1fa2d
    • Iustin Pop's avatar
      Watcher: do not activate disks for admin_down · 0c0f834d
      Iustin Pop authored
      Currently the watcher does activate disks (via bootid mechanisms) even
      for admin_down instances.  This patch logs and skips over these
      instances.
      
      Reviewed-by: ultrotter
      0c0f834d
    • Iustin Pop's avatar
      Reduce chance of ssh failures in verify cluster · b544cfe0
      Iustin Pop authored
      The cluster verify builds a sorted list of nodes and passes that to all
      the nodes (in parallel) for ssh checks. This means that for a cluster
      with N nodes, there will be approximately N simultaneous connections to
      the first node, then to the second node, etc. This, coupled with the
      ssh daemon's “MaxStartups” parameter, can create false alarms about ssh
      connectivity.
      
      This patch randomizes the node list in the backend (therefore, each node
      should have it's own order of ssh-ing to the other nodes) and the chance
      of these alarms should be reduced.
      
      Reviewed-by: ultrotter
      b544cfe0
  2. 12 May, 2008 1 commit
    • Iustin Pop's avatar
      bdev: always log command output if it failed · 6c896e2f
      Iustin Pop authored
      Currently many error handling code paths in bdev.py log only
      result.fail_reason (i.e. exit code or signal that killed the command)
      but not its output. This makes debugging very hard.
      
      The patch changes all places where we only log fail_reason to also log
      result.output.
      
      Reviewed-by: ultrotter
      6c896e2f
  3. 10 May, 2008 1 commit
    • Iustin Pop's avatar
      DRBD: Fix another bug in diskless activation · ab6cc81c
      Iustin Pop authored
      DRBD8 requires that we pass ‘--create-device’ to the first command that
      wants to activate a new DRBD minor. We do this currently when we run the
      “drbdsetup ... disk” command which we run before the network setup.
      
      But if the LVs are missing, we skip the ‘disk’ subcommand and run only
      the ‘net’ one, so it might be that the activation fails because the
      minor we selected was never created in the first place.
      
      The patch adds the required parameter to the DRBD8._AssembleNet() call.
      Since it's a no-op for existing minors, it should not create any
      problems (tested and works both with configured and unconfigured
      minors).
      
      Reviewed-by: ultrotter
      ab6cc81c
  4. 09 May, 2008 1 commit
    • Michael Hanselmann's avatar
      Remove utils.CheckDaemonAlive and use “xm info” instead · e3e66f02
      Michael Hanselmann authored
      There are a couple of reasons for doing so:
      - /proc is not OS independent, it's only supported by Linux (there are
        emulations on other systems, but those might differ from the way
        Linux represents data).
      - Checking a daemon's state doesn't necessarily mean it's usable.
        Connecting to the socket using “xm info” is much safer.
      - Reduce code size.
      
      Reviewed-by: iustinp
      e3e66f02
  5. 08 May, 2008 3 commits
    • Guido Trotter's avatar
      Improve DRBD8.Open's docstring a bit more · f860ff4e
      Guido Trotter authored
      Reviewed-by: iustinp
      
      f860ff4e
    • Guido Trotter's avatar
      Fix comment typo in bdev.py · 7b62772e
      Guido Trotter authored
      Reviewed-by: iustinp
      
      7b62772e
    • Iustin Pop's avatar
      Fix DRBD8 diskless assembling · bf25af3b
      Iustin Pop authored
      The algorithm for attaching to existing DRBD devices is not trivial. It
      has four alternatives, and there is a bug in the last one when we have
      diskless devices.
      
      The last case (local disk info matches but remote/network configuration
      doesn't match) we disconnect from the network and reattach with the
      correct info. We do this because correct local device has higher
      priority than remote device.
      
      However, the test we use (self._MatchesLocal) can succeed in two cases:
        - we have a disk and it's the same as the one attached
        - we don't have a disk and the drbd is in diskless mode
      
      But this creates problems for the fourth case as when we already have
      one diskless DRBD, activating then next one will do:
        - _MatchesLocal? yes, because both config data and system have no
          disks (with the effect that all diskless devices are identical)
        - _MatchesRemote? no, because this disk is configured to its current
          remote peer, not to our new one
      
      The fix is trivial, although the algorithm not: we only allow overriding
      the network configuration when the disk information matches and we are
      not diskless, by adding the <"local_dev" in info'> test.
      
      Reviewed-by: ultrotter
      bf25af3b
  6. 07 May, 2008 2 commits
  7. 06 May, 2008 2 commits
  8. 05 May, 2008 7 commits
    • Michael Hanselmann's avatar
      Generate devel/upload during build time from template · 94f3875d
      Michael Hanselmann authored
      - Use variable with prefix instead of grep and sed
      - Always run with /bin/bash
      
      Reviewed-by: ultrotter
      94f3875d
    • Iustin Pop's avatar
      Export the number of cpus to iallocator scripts · 4337cf1b
      Iustin Pop authored
      Now that we have the number of cpus available from the hypervisors, we
      can export this to the iallocator scripts.
      
      Reviewed-by: ultrotter
      4337cf1b
    • Iustin Pop's avatar
      Minor doc/help update · 872c949f
      Iustin Pop authored
      This shortens the help output in gnt-node so that the output looks
      nicer, and improves the manual page for gnt-instance with the new
      'status' field.
      
      Reviewed-by: ultrotter
      872c949f
    • Iustin Pop's avatar
      Improve the gnt-* list field selection · 48c4dfa8
      Iustin Pop authored
      This patch allows the '-o' option to the list subcommands to add more
      fields to the default list instead of replacing the default list by
      prefixing the fields list with '+'.
      
      The patch also moves the listing (in the help output) of the default
      field list from hardcoded to built at runtime from the actual list.
      
      Reviewed-by: ultrotter
      48c4dfa8
    • Iustin Pop's avatar
      Add node cpu count to gnt-node list · e8a4c138
      Iustin Pop authored
      This patch adds the backend and frontend changes needed for being able
      to list the cpu count.
      
      Reviewed-by: ultrotter
      e8a4c138
    • Guido Trotter's avatar
      Wrap exception in _DistributeConfig code · 9ff994da
      Guido Trotter authored
      nodelist.remove(X) could potentially raise a ValueError (even if the chance
      that the current node is not in the list are pretty scarce, and its absence
      should raise a red flag anyway). If this happens let things go on, as that's
      what the code which previously distributed the config did.
      
      Reviewed-by: iustinp
      9ff994da
    • Guido Trotter's avatar
      Simplify target generation in DistributeConfig · 41362e70
      Guido Trotter authored
      Currently we get the list of nodes, and for each one extract all its info, and
      just to exclude it if the name matches ours. Since the list of nodes is a list
      of names just use .remove() to exclude ourself from it, and use that list
      directly.
      
      Reviewed-by: iustinp
      41362e70
  9. 02 May, 2008 2 commits
    • Guido Trotter's avatar
      ssconf: update the SetKey docstring · 8498462b
      Guido Trotter authored
      SetKey is used, other than for adding new nodes, in another few cases. Update
      the docstring to reflect this, so we don't mislead people reading it.
      
      Reviewed-by: iustinp
      
      8498462b
    • Guido Trotter's avatar
      Delete hypervisor.py · 310bbdde
      Guido Trotter authored
      This completes the changes in r898 by actually getting rid of the old unused
      hypervisor.py code which was left in the code tree.
      
      Reviewed-by: iustinp
      310bbdde
  10. 01 May, 2008 2 commits
  11. 30 Apr, 2008 8 commits
    • Manuel Franceschini's avatar
      Remove deprecated disk templates from doc · 808753d4
      Manuel Franceschini authored
      Since local_raid1 and remote_raid1 are deprecated they are removed
      from the docs. This patch removes some old documentation sections
      and bumps the documented version from 1.2 to 1.3.
      
      Reviewed-by: iustinp
      808753d4
    • Guido Trotter's avatar
      hooks.sgml: Add cluster-verify hooks information · 470e7e06
      Guido Trotter authored
      Reviewed-by: iustinp
      
      470e7e06
    • Guido Trotter's avatar
      Add cluster-verify hooks · d8fff41c
      Guido Trotter authored
      Only post-hooks are run on cluster verify, and then their output is sent back
      to the LU, which upon failure displays it to the user and changes the result of
      the execution to a failure.
      
      Reviewed-by: iustinp
      
      d8fff41c
    • Guido Trotter's avatar
      Add a LU Hooks notification function · 1fce5219
      Guido Trotter authored
      Previously LUs could be failed by pre-hooks, and post-hooks just had effects by
      themselves. This patch allows a LU to define the HooksCallBack function if it
      wants to know about its hooks' results and alter its results in response.
      
      The ChainOpCode execution path contains some commented out hooks code, which
      this patch modifies to run the HooksCallBack function, so this is not forgot if
      it ever gets uncommented out.
      
      Reviewed-by: iustinp
      
      1fce5219
    • Guido Trotter's avatar
      HooksMaster: Make RunPhase return the rpc output · b07a6922
      Guido Trotter authored
      Right now the hooks output is propagated from the nodes all the way up to
      HooksMaster.RunPhase, which uses it for debugging PRE hooks, but then silently
      discards them. We'll now propagate it up to the Processor.ExecOpCode function,
      where they can be handled for other purposes (or discarded again, of course).
      This patch also improves a bit the HooksMaster.RunPhase docstring.
      
      Reviewed-by: iustinp
      
      b07a6922
    • Guido Trotter's avatar
      Remove NoHooksLU.BuildHooksEnv · 10cd4a29
      Guido Trotter authored
      Since NoHooksLU defines HPATH as None, BuildHooksEnv will never be called (as
      the LogicalUnit.BuildHooksEnv docstring correctly states). Removing the
      function altogether, to avoid having dead code lying around, and to make sure
      the non-implemented one in LogicalUnit will be called if someone mistakenly
      tries to call it, so it's immediately clear that something is wrong.
      
      Reviewed-by: iustinp
      
      10cd4a29
    • Guido Trotter's avatar
      LogicalUnit.BuildHooksEnv, update docstring · 8a3fe350
      Guido Trotter authored
      The LogicalUnit.BuildHooksEnv docstring used to say that the node list should
      not include the master node. This is obviously not the case checking the
      relevant code, and double-checking with iustin he confirmed it just document
      some obsolete behaviour. This patch removes those remarks making the docstring
      shorter, easier, and, last but not least, correct! ;)
      
      Reviewed-by: iustinp
      
      8a3fe350
    • Guido Trotter's avatar
      Remove non-existing arguments from some docstrings · 7b7857ee
      Guido Trotter authored
      A fewdocstrings in the HooksRunner backend class list arguments the relevant
      functions do not take.  Clean them up.
      
      Reviewed-by: iustinp
      
      7b7857ee
  12. 29 Apr, 2008 3 commits
  13. 28 Apr, 2008 4 commits
    • Manuel Franceschini's avatar
      Raise PrereqError when exporting file-based instance · b6023d6c
      Manuel Franceschini authored
      This patch adds a check to LUExportInstance.CheckPrereq to raise an
      error when an instance with file disks is exported.
      
      Reviewed-by: ultrotter
      b6023d6c
    • Manuel Franceschini's avatar
      Add file backend storage options to ImportInstance · 93cb65c5
      Manuel Franceschini authored
      This patch adds the file storage options to gnt-backup import which
      would otherwise fail since the values of file_storage_dir and
      file_driver are accessed in LUCreateInstance.
      
      Reviewed-by: ultrotter
      93cb65c5
    • Michael Hanselmann's avatar
      Split hypervisor.py into several files · 65a6f9b7
      Michael Hanselmann authored
      Before it was a huge file with more than 700 lines. No code changes were
      made except for changing imports and class names where needed. In the
      future, we could even think about only importing the hypervisors we
      actually need. The patch finished QA scripts and distcheck successfully.
      
      Reviewed-by: iustinp
      65a6f9b7
    • Iustin Pop's avatar
      Move the 'cmd' lock from cli.py to ganeti-masterd · a4af651e
      Iustin Pop authored
      This patch removes the lock and the lock options from cli.py and moves
      them to the master.
      
      Later during development we can remove it completely, but for now it's
      good to protect any other tool that uses the lock directly.
      
      Reviewed-by: imsnah,ultrotter
      a4af651e