Commit 9ff994da authored by Guido Trotter's avatar Guido Trotter

Wrap exception in _DistributeConfig code

nodelist.remove(X) could potentially raise a ValueError (even if the chance
that the current node is not in the list are pretty scarce, and its absence
should raise a red flag anyway). If this happens let things go on, as that's
what the code which previously distributed the config did.

Reviewed-by: iustinp
parent 41362e70
......@@ -544,7 +544,10 @@ class ConfigWriter:
nodelist = self.GetNodeList()
myhostname = self._my_hostname
nodelist.remove(myhostname)
try:
nodelist.remove(myhostname)
except ValueError:
pass
result = rpc.call_upload_file(nodelist, self._cfg_file)
for node in nodelist:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment