1. 28 Aug, 2012 24 commits
  2. 27 Aug, 2012 3 commits
    • Iustin Pop's avatar
      Merge branch 'devel-2.6' · 951accad
      Iustin Pop authored
      
      
      * devel-2.6:
        Make stable-2.6 compatible with newer pep8
        Fix computation of disk sizes in _ComputeDiskSize
        Add verification of RPC results in _WipeDisks
        Add test for checking that all gnt-* subcommands run OK
        Fix double use of PRIORITY_OPT in gnt-node migrate
        Add new Makefile target to rebuild the whole dist
        rapi client: accept arbitrary shutdown arguments
        Handle offline nodes for "instance down" checks
        Add missing rst files to Makefile.am
        Release version 2.6.0 (final)
        Fix 'explicitely' common typo
        Fix issue in LUClusterVerifyGroup with multi-group clusters
        Add QA test for node group modification of ndparams
        Fix node group modification of node parameters
        Fix RST formatting in NEWS file
        Update NEWS and bump version for release 2.5.2
        Fix boot=on flag for CDROMs
        KVM: only pass boot flag once
        Ensure a stable content of the bash completion file
      
      Conflicts (all trivial):
              Makefile.am  (design drafts on both sides, pep8 changes)
              autotools/build-bash-completion (copyright years)
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      951accad
    • Iustin Pop's avatar
      Merge branch 'stable-2.6' into devel-2.6 · b5df6331
      Iustin Pop authored
      
      
      * stable-2.6:
        Make stable-2.6 compatible with newer pep8
        Fix computation of disk sizes in _ComputeDiskSize
        Add verification of RPC results in _WipeDisks
        Add test for checking that all gnt-* subcommands run OK
        Fix double use of PRIORITY_OPT in gnt-node migrate
        Add new Makefile target to rebuild the whole dist
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      b5df6331
    • Iustin Pop's avatar
      Make stable-2.6 compatible with newer pep8 · 2fefc557
      Iustin Pop authored
      
      
      This is done so that all current branches can run with newer pep8;
      note that instead of fixing the problems (like I did on master), I've
      just silenced more. These should *not* be merged onto master!
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      2fefc557
  3. 24 Aug, 2012 1 commit
  4. 23 Aug, 2012 2 commits
    • Iustin Pop's avatar
      Bump pep8 version to 1.2 · 5ae4945a
      Iustin Pop authored
      
      
      Debian Wheezy will ship with this version, and it has many improved checks compared to 0.6, so let's:
      
      - bump version in the docs
      - silence some new checks that are wrong due to our indent=2 instead of 4
      - fix lots of errors in the code where the indentation was wrong by 1
        or 2 spaces
      - fix a few cases of == True, False, None and replace with 'is'
      - re-indent some cases where the code is OK, but pep8 complains
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      5ae4945a
    • Iustin Pop's avatar
      Change node parameter oob_program to VTYPE_STRING · 1df4d430
      Iustin Pop authored
      
      
      Since this is an inheritable parameter, having it as a MABYE_STRING
      creates only problems (per our derivation rules). We change it to
      STRING, with the default "", meaning no program. Note that most of the
      code already accepts this as valid for "no program", and some comments
      even say that this is the expected value.
      
      We have some other parameters like this, I'll have to investigate
      whether they need to be changed too. But right now I need this for the
      hconfd changes (it's a prerequisite for them, I forgot to send it in
      that patch series).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      1df4d430
  5. 22 Aug, 2012 1 commit
    • Constantinos Venetsanopoulos's avatar
      Fix computation of disk sizes in _ComputeDiskSize · 6a3166cb
      Constantinos Venetsanopoulos authored
      
      
      Currently, hail fails with FailDisk when trying to add an instance
      of type: 'file', 'sharedfile' and 'rbd'.
      
      This is due to a "0" or None value in the corresponding dict inside
      _ComputeDiskSize, which results in a "O" or non Int value of the
      exported 'disk_space_total' parameter. This in turn makes hail fail,
      when trying to process the value:
      
       - with "Unable to read Int" if value is None (file)
       - with FailDisk if value is 0 (sharedfile, rbd)
      
      The latter happens because the 0 value doesn't match the instance's
      IPolicy, since it is lower than the minimum disk size.
      
      The second problem still exists when using adoption with 'plain'
      and 'blockdev' template and will be addressed in another commit.
      Signed-off-by: default avatarConstantinos Venetsanopoulos <cven@grnet.gr>
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      6a3166cb
  6. 15 Aug, 2012 1 commit
    • Iustin Pop's avatar
      Add verification of RPC results in _WipeDisks · f08e5132
      Iustin Pop authored
      
      
      Due to an oversight, the pause/resume sync RPC calls in _WipeDisks
      lack the verification of the overall RPC status, and directly iterate
      over the payload. The code actually doing the wipe does verify
      correctly the results. This can result in jobs failing with a hard to
      diagnose:
      
      OpExecError ['NoneType' object is not iterable]
      
      instead of proper "RPC failed" message.
      
      This patch adds a hard check on the pause call, but for the resume
      call it just logs a warning if the RPC failed; the rationale being
      that if we can't contact the node for pausing the sync, it's likely
      wiping will fail too, but after the wipe has been done, we can
      continue.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      f08e5132
  7. 14 Aug, 2012 1 commit
  8. 13 Aug, 2012 2 commits
    • Iustin Pop's avatar
      Add a server-side Luxi implementation · 13f2321c
      Iustin Pop authored
      
      
      This is a trivial code change, but it allows us to finally test the
      send-receive code on both client and server sides via a simple
      in-process server.
      
      The unittest works, but it won't handle timeouts very nicely; it will
      wait until the actual Luxi timeout expires, instead of using much
      shorter timeouts as we could in the same process.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      13f2321c
    • Iustin Pop's avatar
      Switch the Luxi interface from Strings to ByteStrings · e821050d
      Iustin Pop authored
      
      
      I'm doing this change for future performance optimisations. Currently
      we use the Luxi interface just as a client, so not in the hot path,
      but when we'll use this as a server interface, we're interested to
      both reduce the space and time consumption of the interface.
      
      We have to simultaneous changes here:
      
      - switch from using socket-related function (sendto, recv, etc.) to
        handle-based functions, since the standard network library doesn't
        work with sockets
      - switch from using Strings for the internal buffer to strict
        ByteStrings; the only downside is that we now have the issue of
        decoding/encoding from binary to UTF-8 strings, a fact which brings
        its own issues into the mix (we have to check for failed decodings,
        etc.); but this is similar to what we'll have to handle on the
        Python side when moving to Python 3.x
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      e821050d
  9. 10 Aug, 2012 2 commits
  10. 09 Aug, 2012 1 commit
  11. 08 Aug, 2012 2 commits