1. 29 Feb, 2008 1 commit
    • Iustin Pop's avatar
      Fix cluster rename operation · 488b540d
      Iustin Pop authored
      This one-liner fixes the cluster rename operation. As a side note, we
      should have a QA test for this too.
      
      Reviewed-by: imsnah
      488b540d
  2. 28 Feb, 2008 5 commits
    • Guido Trotter's avatar
      LockSet: make acquire() fail faster on wrong locks · e6c200d6
      Guido Trotter authored
      This patch makes acquire() first look up all the locks in the dict and then try
      to acquire them later. The advantage is that if a lockname is already wrong
      since the beginning we won't need to first queue and acquire other locks to
      find this out.
      
      Of course since there is no locking between the two steps a delete() could
      still happen in between, but SharedLocks are safe in this regard and will just
      make the .acquire() operation fail if this unfortunate condition happens.
      
      Since the right way to check if an instance/node exists and make sure it won't
      stop existing after that is acquiring its lock this improves the common case
      (checking for an incorrect name) while not penalizing correctness, or
      performance as would happen if we kept a lock for the whole process.
      
      Reviewed-by: iustinp
      e6c200d6
    • Guido Trotter's avatar
      LockSet implementation and unit tests · aaae9bc0
      Guido Trotter authored
      A LockSet represents locking for a set of resources of the same type. A thread
      can acquire multiple resources at the same time, and release some or all of
      them, but cannot acquire more resources incrementally at different times
      without releasing all of them in between.
      
      Internally a LockSet uses a SharedLock for each resource to be able to grant
      both exclusive and shared acquisition. It also supports safe addition and
      removal of resources at runtime. Acquisitions are ordered alphabetically in
      order to grant them to be deadlock-free. A lot of assumptions about how the
      code interacts are made in order to grant both safety and speed; in order to
      document all of them the code features pretty lenghty comments.
      
      The test suit tries to catch most common interactions but cannot really tests
      tight race conditions, for which we still need to rely on human checking.
      
      This is the second basic building block for the Ganeti Lock Manager. Instance
      and Node locks will be put in LockSets to manage their acquisition and release.
      
      Reviewed-by: imsnah
      aaae9bc0
    • Guido Trotter's avatar
      Fix the gnt-cluster init man page · f3b100e1
      Guido Trotter authored
      Some options were missing in the gnt-cluster init man page.  This patch adds
      them, removes an empty line, and clarifies a bit more some requirements.
      
      Reviewed-by: schreiberal
      f3b100e1
    • Guido Trotter's avatar
      Don't allow renaming to an existing instance · 7bde3275
      Guido Trotter authored
      Even if the target instance is down or we are not checking for IP conflicts
      changing an instance name to a new one which is already in the cluster is
      doomed to fail, because in a lot of places (among which figures the mind of
      most users/admins) instance names are assumed to be unique.
      
      Reviewed-by: imsnah
      7bde3275
    • Alexander Schreiber's avatar
      Clarify online help for xc-instance reinstall. · 5336d63d
      Alexander Schreiber authored
      Reviewed-by: imsnah
      
      5336d63d
  3. 27 Feb, 2008 2 commits
  4. 26 Feb, 2008 2 commits
  5. 25 Feb, 2008 2 commits
  6. 23 Feb, 2008 1 commit
    • Guido Trotter's avatar
      Improve ganeti example cron file · 0d349b3a
      Guido Trotter authored
      The cron file in ganeti's example directory is now static, and executes
      ganeti-watcher in /usr/local/sbin no matter where it's really installed. With
      this patch we generate it at build time substituting the right value of
      @SBINDIR@ from ganeti.cron.in. We also make sure ganeti-watcher exists and is
      executable before running it.
      
      This is targeted at 1.2 as well.
      
      Reviewed-by: iustinp
      0d349b3a
  7. 22 Feb, 2008 3 commits
    • Manuel Franceschini's avatar
      Small comment fix. · 6c8af3d0
      Manuel Franceschini authored
      6c8af3d0
    • Manuel Franceschini's avatar
      c99a3cc0
    • Iustin Pop's avatar
      Break trunk by removing twisted · 81010134
      Iustin Pop authored
      This patch switches from the twisted usage for inter-node protocol to
      simple BaseHTTPServer/httplib. The patch has more deletions because we
      use no authentication, no encryption at all.
      
      As such, this is just for trunk, and only for testing. What it brings is
      the ability to use the rpc library from within multiple threads in
      parallel (or it should so).
      
      Since the changes are very few and non-intrusive, they can be reverted
      without impacting the rest of the code.
      
      This passes burnin. QA was not tested.
      
      Reviewed-by: imsnah
      81010134
  8. 21 Feb, 2008 1 commit
    • Guido Trotter's avatar
      Add a few SharedLock delete() tests · 84152b96
      Guido Trotter authored
      - Check that even a shared acquire() fails on a deleted lock
      - Check that delete() fails on a lock you share (must own it or nothing)
      
      These are assumptions I build on in future code, so better check for them.
      Currently no code change is necessary for them to be valid.
      
      Reviewed-by: iustinp
      84152b96
  9. 20 Feb, 2008 2 commits
    • Guido Trotter's avatar
      SharedLock: fix a wrong unit-test helper code · 4354ab03
      Guido Trotter authored
      The _doItDelete helper code was supposed to be used to dispatch threads that
      deleted the SharedLock. It actually just acquired it exclusively. This remained
      unnoticed as the helper thread is just used to test interaction, not the delete
      code by itself, and delete requires an exclusive acquire anyway.
      
      Reviewed-by: imsnah
      4354ab03
    • Guido Trotter's avatar
      Add another 1.1->1.2 compatibility alias · 00ce8b29
      Guido Trotter authored
      gnt-instance replace-disks used to be called replace_disks.
      
      Reviewed-by: iustinp
      00ce8b29
  10. 19 Feb, 2008 1 commit
    • Guido Trotter's avatar
      Add the delete() operation to SharedLock · a95fd5d7
      Guido Trotter authored
      This new operation lets a lock be cleanly deleted. The lock will be exclusively
      held before deletion, and after it pending and future acquires will raise an
      exception. Other SharedLock operations are modify to deal with delete() and to
      avoid code duplication.
      
      This patch also adds unit testing for the new function and its interaction with
      the other lock features. The helper threads are sligtly modified to handle and
      report the condition of a deleted lock. As a bonus a non-related unit test
      about not supporting non-blocking mode yet has been added as well.
      
      This feature will be used by the LockSet in order to support deadlock-free
      delete of resources. This in turn will be useful to gracefully handle the
      removal of instances and nodes from the cluster dealing with the fact that
      other operations may be pending on them.
      
      Reviewed-by: iustinp
      a95fd5d7
  11. 18 Feb, 2008 5 commits
  12. 16 Feb, 2008 1 commit
    • Guido Trotter's avatar
      Fix gnt-instance info i1 i2 ... · 515207af
      Guido Trotter authored
      Due to an indentation error only the last instance queried got returned by
      LUQueryInstanceData. Moving the append() call inside the for cycle to fix this
      issue.
      
      This is a one-liner targeted at 1.2.3
      
      Reviewed-by: iustinp
      515207af
  13. 15 Feb, 2008 2 commits
  14. 14 Feb, 2008 4 commits
    • Iustin Pop's avatar
      Alter the device activation code · 40a03283
      Iustin Pop authored
      This tiny patch fixes the breakage that the previous patch about
      activation did by removing the Close() call after activation.
      
      The initial reason for that call was that if the device is already
      active and open, but we need it closed, we close it automatically.
      
      This however conflicts with the 2-step open in the case the instance is
      already open.
      
      It makes sense to remove the call since in the current Ganeti setup,
      just doing Close() is not enough to change the device from (e.g.)
      primary to secondary, as some devices (e.g. md) might need Shutdown not
      Close.
      
      It also gets rid of a Close() in the CreateBlockDevice function, due to
      the same reasoning (although in Create the child should not have a
      different status anyway).
      
      Reviewed-by: imsnah
      40a03283
    • Iustin Pop's avatar
      Two small improvements to burnin · d7b47a77
      Iustin Pop authored
      This tiny patch fixes the verbose option to actually work, and also when
      creating instances it logs the secondary node too (even if this doesn't
      apply for plain templates, it doesn't create an error).
      
      Reviewed-by: imsnah
      d7b47a77
    • Iustin Pop's avatar
      Modify the default output of gnt-instance list · d8052456
      Iustin Pop authored
      This patch adds a new field available for selection in gnt-instance list
      names "status" which represents the combined value of "admin_state" and
      "oper_state". Since this is much easier to parse (e.g. gnt-instance list
      |grep ERROR), we also modify the default field list to use this instead
      of the admin/oper state fields.
      
      Reviewed-by: imsnah
      d8052456
    • Michael Hanselmann's avatar
      Code style updates for QA code. · c68d1f43
      Michael Hanselmann authored
      Reviewed-by: iustinp
      c68d1f43
  15. 12 Feb, 2008 1 commit
    • Guido Trotter's avatar
      Parse double protocol version in drbd8.2 · c3f9340c
      Guido Trotter authored
      DRBD 8.2 uses a double integer field ad protocol version, rather than a single
      one. This patch fixes the ganeti parsing code, allowing both the old and the
      new version type. In order to do so the internal _GetVersion function is
      changed to return a dict, rather than a list, and the second protocol field is
      added, only if present, as proto2.
      
      This is a fix for issue 24.
      
      Reviewed-by: iustinp
      c3f9340c
  16. 10 Feb, 2008 1 commit
  17. 08 Feb, 2008 1 commit
    • Guido Trotter's avatar
      Shared Lock implementation and unit tests. · 162c1c1f
      Guido Trotter authored
      Adding a locking.py file for the ganeti locking library. Its first component is
      the implementation of a non-recursive blocking shared lock complete with a
      testing library.
      
      Reviewed-by: imsnah, iustinp
      162c1c1f
  18. 06 Feb, 2008 1 commit
  19. 05 Feb, 2008 2 commits
    • Iustin Pop's avatar
      Add a test opcode that sleeps for a given duration · 06009e27
      Iustin Pop authored
      This can be used for testing purposes.
      
      Reviewed-by: ultrotter,imsnah
      06009e27
    • Iustin Pop's avatar
      Reduce the chance of DRBD errors with stale primaries · fdbd668d
      Iustin Pop authored
      This patch is a first step in reducing the chance of causing DRBD
      activation failures when the primary node has not-perfect data.
      
      This issue is more seen with DRBD8, which has an 'outdate' state (in
      which it can get more often). But it can (and before this patch, usually
      will) happen with both 7 and 8 in the case the primary has data to sync.
      
      The error comes from the fact that, before this patch, we activate the
      primary DRBD device and immediately (i.e. as soon as we can run another
      shell command) we try to make it primary. This might fail - since the
      primary knows it has some data to catch up to - but we ignored this
      error condition. The failure was visible later, in either md failing to
      activate over a read-only storage or by instance failing to start.
      
      The patch has two parts: one affecting bdev.py, which changes failures
      in BlockDev.Open() from returning False to raising
      errors.BlockDeviceError; noone (except a generic method inside bdev.py)
      checked this return value and we logged it but the master didn't know
      about it; now all classes raise errors from Open if they have a failure.
      
      The other part, affecting cmdlib.py, changes the activation sequence
      from:
        - activate on primary node as primary and secondary as secondary, in
          whatever order a function returns the nodes
      to the following:
        - activate all drives as secondaries, on both the primary and the
          secondary nodes of the instance
        - after that, on the primary node, re-activate the device stack as
          primary
      
      This is in order to give the chance to DRBD to connect and make the
      handshake. As noted in the comments, this just increases the chances of
      a handshake/connect, not fixing entirely the problem. However, it is a
      good first step and it passes all tests of starting with stale (either
      full or partial) primaries, with both drbd 7 and 8, and also passes a
      burnin.
      
      Note that the patch might make the device activation a little bit
      slower, but it is a reasonable trade-off.
      
      Reviewed-by: imsnah
      fdbd668d
  20. 04 Feb, 2008 2 commits