Skip to content
Snippets Groups Projects
  1. Sep 12, 2012
  2. Sep 04, 2012
  3. Aug 28, 2012
  4. Aug 10, 2012
  5. Aug 07, 2012
    • Iustin Pop's avatar
      Switch job IDs to numeric · 76b62028
      Iustin Pop authored
      
      This has been a long-standing cleanup item, which we've always
      refrained from doing due to the high estimated effort needed.
      
      In reality, it turned out that after some infrastructure improvements
      (the previous patches), the actual job queue-related changes are quite
      small.
      
      We will need to update the NEWS file later, but so far the RAPI
      documentation doesn't mention that the job ID is a string (it only
      says it is "a number"), so it doesn't look like it needs update.
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      76b62028
    • Iustin Pop's avatar
      Make jqueue unittests more generic · 09532dcc
      Iustin Pop authored
      
      This patch removes/abstracts some hardcoded values in the jqueue
      unittests. Currently we have a per-resource type name field, but the
      name field values are hardcoded at the call sites, instead of being
      abstracted into separate variables.
      
      This will become a problem later, so let's just introduce some new
      vars holding these; modifying the tests later will be therefore
      easier.
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      09532dcc
  6. Jun 28, 2012
  7. Jun 27, 2012
  8. Jun 25, 2012
  9. Jun 20, 2012
  10. Jun 15, 2012
  11. Jun 14, 2012
  12. Jun 11, 2012
  13. May 23, 2012
  14. May 15, 2012
  15. May 14, 2012
  16. May 11, 2012
  17. May 10, 2012
  18. May 09, 2012
    • Iustin Pop's avatar
      Fix exception re-raising in Python Luxi clients · 98dfcaff
      Iustin Pop authored
      
      Commit e687ec01 (present in 2.5 since the 2.5 beta 3) did consistency
      fixes across the code-base. Unfortunately this was done without enough
      checks on the actual meaning of one of the fixes, which means error
      re-raising in lib/errors.py is broken.
      
      The problem is that:
      
        raise cls, args
      
      is different than:
      
        raise cls(args)
      
      And our unit-tests didn't catch this (this patch updates the tests).
      
      This breakage is usually trivial, like wrong error messages:
      
        $ gnt-instance remove no-such-instance
        Failure: prerequisites not met for this operation:
        ("Instance 'no-such-instance' not known", 'unknown_entity')
      
      versus:
      
        $ gnt-instance remove no-such-instance
        Failure: prerequisites not met for this operation:
        error type: unknown_entity, error details:
        Instance 'no-such-instance' not known
      
      or:
      
        $ gnt-instance add … no-such-instance
        Failure: prerequisites not met for this operation:
        ('The given name (no-such-instance) does not resolve: Name or service not known', 'resolver_error')
      
      versus:
      
        $ gnt-instance add … no-such-instance
        Failure: prerequisites not met for this operation:
        error type: resolver_error, error details:
        The given name (no-such-instance) does not resolve: Name or service not known
      
      But in some cases where we rely on a certain data representation
      (e.g. HooksAbort), this actually breaks because we try to iterate over
      the wrong type:
      
        File "/usr/lib/python2.6/dist-packages/ganeti/cli.py", line 1907, in FormatError
           for node, script, out in err.args[0]:
        ValueError: need more than 1 value to unpack
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      98dfcaff
    • Iustin Pop's avatar
      Allow clock skews in certificate verification · f97a7ada
      Iustin Pop authored
      
      Currently we allow for up to NODE_MAX_CLOCK_SKEW time difference
      between nodes in some operations, but not everywhere: SSL certificate
      verification (import/export, both intra and inter-cluster) has a zero
      limit (downwards), and a week upwards. This can cause even
      intra-cluster backup problems, if the source node has a time even two
      seconds in the future.
      
      To fix this, when we verify certificates compare with a time offset
      with the max skew, which fixes the lower bound and reduces the upper
      bound by an insignificant amount (0.04%).
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      f97a7ada
  19. May 08, 2012
    • Iustin Pop's avatar
      Correct capitalisation of two Luxi calls · 83c046a2
      Iustin Pop authored
      
      Two Luxi calls have inconsistent an name/value mapping (in the Python
      code):
      
      - REQ_AUTOARCHIVE_JOBS versus AutoArchiveJobs (versus AutoarchiveJobs)
      - REQ_QUEUE_SET_DRAIN_FLAG versus SetDrainFlag (no Queue)
      
      While these are only a consistency issue, let's fix them so that the
      Haskell code (which uses the auto-generated camel-case form) doesn't
      need to handle them case specially, and looks more like the Python
      code (hah, joke!).
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      83c046a2
  20. May 04, 2012
  21. Apr 27, 2012
  22. Apr 26, 2012
  23. Apr 19, 2012
  24. Apr 16, 2012
  25. Mar 30, 2012
Loading