- May 02, 2008
-
-
Guido Trotter authored
SetKey is used, other than for adding new nodes, in another few cases. Update the docstring to reflect this, so we don't mislead people reading it. Reviewed-by: iustinp
-
Guido Trotter authored
This completes the changes in r898 by actually getting rid of the old unused hypervisor.py code which was left in the code tree. Reviewed-by: iustinp
-
- May 01, 2008
-
-
Guido Trotter authored
- Add a docstring to IOServer's constructor - Add argument description to PoolWorker's and JobRunner's ones Reviewed-by: iustinp
-
Guido Trotter authored
Reviewed-by: iustinp
-
- Apr 30, 2008
-
-
Manuel Franceschini authored
Since local_raid1 and remote_raid1 are deprecated they are removed from the docs. This patch removes some old documentation sections and bumps the documented version from 1.2 to 1.3. Reviewed-by: iustinp
-
Guido Trotter authored
Reviewed-by: iustinp
-
Guido Trotter authored
Only post-hooks are run on cluster verify, and then their output is sent back to the LU, which upon failure displays it to the user and changes the result of the execution to a failure. Reviewed-by: iustinp
-
Guido Trotter authored
Previously LUs could be failed by pre-hooks, and post-hooks just had effects by themselves. This patch allows a LU to define the HooksCallBack function if it wants to know about its hooks' results and alter its results in response. The ChainOpCode execution path contains some commented out hooks code, which this patch modifies to run the HooksCallBack function, so this is not forgot if it ever gets uncommented out. Reviewed-by: iustinp
-
Guido Trotter authored
Right now the hooks output is propagated from the nodes all the way up to HooksMaster.RunPhase, which uses it for debugging PRE hooks, but then silently discards them. We'll now propagate it up to the Processor.ExecOpCode function, where they can be handled for other purposes (or discarded again, of course). This patch also improves a bit the HooksMaster.RunPhase docstring. Reviewed-by: iustinp
-
Guido Trotter authored
Since NoHooksLU defines HPATH as None, BuildHooksEnv will never be called (as the LogicalUnit.BuildHooksEnv docstring correctly states). Removing the function altogether, to avoid having dead code lying around, and to make sure the non-implemented one in LogicalUnit will be called if someone mistakenly tries to call it, so it's immediately clear that something is wrong. Reviewed-by: iustinp
-
Guido Trotter authored
The LogicalUnit.BuildHooksEnv docstring used to say that the node list should not include the master node. This is obviously not the case checking the relevant code, and double-checking with iustin he confirmed it just document some obsolete behaviour. This patch removes those remarks making the docstring shorter, easier, and, last but not least, correct! ;) Reviewed-by: iustinp
-
Guido Trotter authored
A fewdocstrings in the HooksRunner backend class list arguments the relevant functions do not take. Clean them up. Reviewed-by: iustinp
-
- Apr 29, 2008
-
-
Manuel Franceschini authored
Reviewed-by: iustinp
-
Michael Hanselmann authored
Reviewed-by: iustinp
-
Iustin Pop authored
This patch adds a mechanism to disable utils.RunCmd in selected programs. This is needed in the master daemon unless we confirm threading doesn't pose any problems. This makes cluster init fail, but creating new trunk clusters is anyway broken at the moment. Reviewed-by: ultrotter
-
- Apr 28, 2008
-
-
Manuel Franceschini authored
This patch adds a check to LUExportInstance.CheckPrereq to raise an error when an instance with file disks is exported. Reviewed-by: ultrotter
-
Manuel Franceschini authored
This patch adds the file storage options to gnt-backup import which would otherwise fail since the values of file_storage_dir and file_driver are accessed in LUCreateInstance. Reviewed-by: ultrotter
-
Michael Hanselmann authored
Before it was a huge file with more than 700 lines. No code changes were made except for changing imports and class names where needed. In the future, we could even think about only importing the hypervisors we actually need. The patch finished QA scripts and distcheck successfully. Reviewed-by: iustinp
-
Iustin Pop authored
This patch removes the lock and the lock options from cli.py and moves them to the master. Later during development we can remove it completely, but for now it's good to protect any other tool that uses the lock directly. Reviewed-by: imsnah,ultrotter
-
Iustin Pop authored
This patch converts the cli.py SubmitOpCode method to use the unix protocol and thus execute the opcodes via the master. The patch allows a partial burnin to work with the master. Currently the query opcodes, since they are executed via the SubmitOpCode, are executed inside a job too, which is suboptimal, but they work fine. The cmd lock has been removed from the master, but the cli.py still takes the lock. This is ok for this in-progress patch (since the master still has only one executor thread). This will be fixed in a future patch. Reviewed-by: ultrotter
-
Manuel Franceschini authored
bdev.FileStorage does not have major or minor fields, so gnt-instance info for file backed instances fails with a TypeError. This patch adds checks to prevent that and print 'N/A' instead. Reviewed-by: imsnah
-
Manuel Franceschini authored
This patch changes the code executed when testing the signal handling of RunCmd. Since sh does not always point to bash (e.g. on Ubuntu, where it points to /bin/dash) this test might fail due to the returned exit code is different so the received signal is not correctly detected. Additionally fix the docstring of testSignal. Reviewed-by: iustinp
-
Iustin Pop authored
Currently the iallocator execution takes place in the master, which is a violation of the current architecture, and will create problems with a threaded master daemon. This patch moves the execution to the backend, similar to the hooks runner, by: - introducing a new class that handles the execution in the backend (and could be used also for listing the allocators, etc.) - introducing a new rpc call - replacing the actual execution in IAllocator.Run() with a rpc call This passes burnin with the dumb allocator Reviewed-by: imsnah
-
Iustin Pop authored
The commit "IAllocator: some more info exported" broke the instance list generation due to a wrong index variable. This patch fixes that. Reviewed-by: ultrotter
-
- Apr 25, 2008
-
-
Michael Hanselmann authored
Add parameters to not check the path for absoluteness, implement a dry run mode and automatically create a backup if requested. This will be used by the cfgupgrade utility. Reviewed-by: schreiberal
-
Iustin Pop authored
This patch adds the following information to the exported info: - hypervisor type (in the main dict) - total memory used by primary instances (in each node dict) (can be computed from the node+instance dicts, but it's cheap to compute from Ganeti) (this is not live data, just from the config) - total memory used by primary instances marked to be up, similar to the above Reviewed-by: imsnah
-
Iustin Pop authored
Currently we try to convert the values returned by call_node_info to ints, and if all succeed, we actually do the conversion. Simplify this by doing it in one step. The patch also adds exporting of node memory as 'reserved_memory'. Reviewed-by: imsnah
-
Iustin Pop authored
This patch extends the config objects with the slots to handle more HVM configuration items. Author: schreiberal Reviewed-by: iustinp,imsnah
-
Michael Hanselmann authored
Reviewed-by: iustinp
-
Iustin Pop authored
Reviewed-by: imsnah
-
- Apr 24, 2008
-
-
Manuel Franceschini authored
This patch initializes nic_count and disk_count with 0. This prevents some reference errors if the snap_disks block device list is empty. Reviewed-by: ultrotter
-
Iustin Pop authored
This small patch fixes: - wrong indentation in two places - use of 'os' variable that hides global scope os module Reviewed-by: imsnah
-
Iustin Pop authored
This patch implements secondary replace via the iallocator. The new opcode parameter 'iallocator' behaves like this: if passed, it will always compute and assign a new secondary, behaving in effect as if the secondary node has been passed. It conflicts with actually giving the secondary too. [Note: not tested with remote_raid1, but the code should behave the same, we only touch CheckPrereq and we assign a node.] The patch also adds burnin support for the replace secondary operation; with this in place, burnin can fully work with auto-assigned nodes. Reviewed-by: ultrotter
-
Iustin Pop authored
This simple patch adds memory size for the burnin instances, which helps testing allocator algorithm response based on the available node memory and instance memory size values. Reviewed-by: ultrotter
-
Iustin Pop authored
The patch which generalized the IAllocator was half-true: it actually put the selection of the node inside the IAllocator, so callers were not able to specify replace primary node. This patch does: - split the arguments to the constructor in three sets: mode and name are always passed, and then we differentiate between allocation parameters and relocation ones - add a new relocate_from option to the IAllocator constructor which is a list of nodes we want to move the instance off - rename the 'nodes' argument in the request object to 'relocate_from' since this is clearer and is not confused with the result field also called 'nodes' Reviewed-by: ultrotter
-
- Apr 23, 2008
-
-
Manuel Franceschini authored
This patch adds the two attributes file_storage_dir and file_driver to the CreateInstance opcode in the ImportExport method, since otherwise it will fail with the file storage patches. Reviewed-by: iustinp
-
Guido Trotter authored
When the allocator or a non-mirrored template are used the message shown by burnin at instance creation time was wrong. Fixing it. Reviewed-by: iustinp
-
Guido Trotter authored
Make burnin remove exports after importing the instance back. Reviewed-by: iustinp
-
Guido Trotter authored
This patch also fixes the LUExportInstance Prereq docstring. Reviewed-by: iustinp
-
Manuel Franceschini authored
This patch adds the possibility to execute instance renaming when doing a cluster burnin. The optional parameter --rename takes one 'spare' instance name. Given this option it renames all given instances to the spare one and back to their original name. Reviewed-by: iustinp
-