Skip to content
Snippets Groups Projects
  1. Oct 04, 2007
  2. Sep 21, 2007
    • Iustin Pop's avatar
      Remove requirement that host names are FQDN · 89e1fc26
      Iustin Pop authored
      We currently require that hostnames are FQDN not short names
      (node1.example.com instead of node1). We can allow short names as long
      as:
        - we always resolve the names as returned by socket.gethostname()
        - we rely on having a working resolver
      
      These issues are not as big as may seem, as we only did gethostname() in
      a few places in order to check for the master; we already required
      working resolver all over the code for the other nodes names (and thus
      requiring the same for the current node name is normal).  The patch
      moves some resolver calls from within execution path to the checking
      path (which can abort without any problems). It is important that after
      this patch is applied, no name resolving is called from the execution
      path (LU.Exec() or other code that is called from within those methods)
      as in this case we get much better code flow.
      
      This patch also changes the functions for doing name lookups and
      encapsulates all functionality in a single class.
      
      The final change is that, by requiring working resolver at all times, we
      can change the 'return None' into an exception and thus we don't have to
      check manually each time; only some special cases will check
      (ganeti-daemon and ganeti-watcher which are not covered by the
      generalized exception handling in cli.py). The code is cleaner this way.
      
      Reviewed-by: imsnah
      89e1fc26
  3. Sep 17, 2007
    • Iustin Pop's avatar
      Add rename instance support to ConfigWriter · fc95f88f
      Iustin Pop authored
      This patch adds support for renaming instances to the ConfigWriter
      class. It's needed in here in order to guarantee that we don't lose the
      instance during the rename (the instance will be there, either with the
      old name or with the new name).
      
      Reviewed-by: imsnah
      fc95f88f
  4. Aug 14, 2007
    • Iustin Pop's avatar
      Style changes for pep-8 and python-3000 compliance. · 3ecf6786
      Iustin Pop authored
      This changes the raising of exceptions from:
        raise Exception, value
      to
        raise Exception(value)
      
      as the first form will be removed in python-3000 and the second form is
      preferred now.
      
      The changes also involve a few cases of changing from raising standard
      exceptions and use our own ones.
      
      The new version also fixes many pylint-generated warnings, especially in
      ganeti-noded where I changed many methods to @staticmethod.
      
      There is no functionality changed (barring any bugs).
      3ecf6786
  5. Aug 03, 2007
  6. Jul 27, 2007
    • Iustin Pop's avatar
      Move the cluster name from ConfigWriter to SimpleStore. · 5fcdc80d
      Iustin Pop authored
      Reason: if left ConfigWriter, nodes don't know to which cluster they belong.
      This will bite us later when we'll revisit node join operation.
      
      Cons: we lose the cluster name from the config file, which means a
      standalone "cluster.data" is a little bit harder to analyze. But I have
      a plan for this which will follow shortly.
      
      Implementing this will also allow us to cleanly fix "gnt-cluster
      getmaster".
      
      Reviewed-by: imsnah
      5fcdc80d
  7. Jul 26, 2007
  8. Jul 25, 2007
  9. Jul 23, 2007
    • Iustin Pop's avatar
      Big change/cleanup in relation to the master startup: · 880478f8
      Iustin Pop authored
        - move the master node name from the ConfigWriter to SimpleStore (all
          nodes need this, and it was the only thing pulled in from the
          ConfigWriter on nodes)
        - fix mcpu.py and the testing w.r.t. this change; for testing, rename
          the fake_config.py to mocks.py and add a FakeSStore object
        - then add a ganeti-master script which can be run on any node at boot
          and which will not do anything if not master on start (on stop it
          will still try to remove the ip address)
        - also add a new cluster-wide variable (master_netdev) that determines
          on which interface we add this ip address; it's customizable at
          cluster init time
        - also remove the cluster name file which was separately handled from
          ssconf (not needed anymore)
        - remove the master init.d links from the list of config files as this
          is not our responsibility now
      
      880478f8
  10. Jul 16, 2007
Loading