1. 12 Jul, 2011 3 commits
  2. 11 Jul, 2011 4 commits
    • Michael Hanselmann's avatar
      Merge branch 'devel-2.4' · b795a775
      Michael Hanselmann authored
      * devel-2.4:
        ht: Add new check for numbers
        Fix off-by-one bug in job serial generation
        Shorten some unbreakable lines in man pages
        Correct some spelling mistakes
        Fix bug in recreate-disks for DRBD instances
        Fix a lint warning
        KVM: configure bridged NICs at migration start
        Fix RAPI documentation regarding master role
        Fix bug in drbd8 replace disks on current nodes
      
      Conflicts:
      	lib/cmdlib.py: Trivial
      	lib/opcodes.py: Trivial
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      b795a775
    • Michael Hanselmann's avatar
      ht: Add new check for numbers · 697f49d5
      Michael Hanselmann authored
      Places which receive floats can usually also deal with integers, e.g.
      OpTestDelay. Tests are added and the new check function is used for the
      aforementioned opcode and verifying query results.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      697f49d5
    • Michael Hanselmann's avatar
      Fix off-by-one bug in job serial generation · 3c88bf36
      Michael Hanselmann authored
      Commit 009e73d0 (September 2009) changed the job queue to generate
      multiple job serials at once. Ever since it would return one more than
      requested.
      
      The “serial” file in the job queue directory is defined to contain the
      “last job ID used” (design-2.0). With the change above, the serial file
      would always contain the next serial number. The first value returned by
      the generating function was the one contained in the file, so during the
      switch in 2009 one job may have been overwritten.
      
      This patch changes the code to always return the exact number of
      serials, to keep the last used serial on disk and adds an assertion.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      3c88bf36
    • Iustin Pop's avatar
      Reverts the patch series about console wrappers · 7238edb5
      Iustin Pop authored
      This reverts commits 030a9cb8 and
      ae082df0.
      
      There are two problems:
      
      - Makefile.am breakage, which is trivial to revert
      - unittest breakage, which honestly I'm not sure how to fix and how
        serial consoles interact with the unpause helper
      
      After the reset, the startup --paused still works but won't unpause
      the instance automatically (if I understood the code correctly).
      
      Furthermore, the code also fixes a style issue in hv_kvm.py (too long
      line) introduced by the next commit after the above two.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      7238edb5
  3. 08 Jul, 2011 3 commits
  4. 06 Jul, 2011 1 commit
  5. 05 Jul, 2011 6 commits
  6. 01 Jul, 2011 5 commits
  7. 28 Jun, 2011 14 commits
  8. 27 Jun, 2011 3 commits
    • Apollon Oikonomopoulos's avatar
      KVM: configure bridged NICs at migration start · cc8a8ed7
      Apollon Oikonomopoulos authored
      Commit 5d9bfd87 moved tap interface handling from KVM to Ganeti, partly
      to also solve the problem of routed interfaces getting configured too
      early during live migrations, causing network anomalies. In that
      direction, configuration of NICs of incoming instances was deferred to
      FinalizeMigration time.
      
      However, this causes minor issues with bridged interfaces; KVM sends out
      an ARP-like packet upon migration finish, which is lost because the tap
      interface is not yet configured. As a consequence, intermediate network
      equipment (i.e. switches) does not get notified about the topology
      change, until the instance transmits another packet after the bridge has
      been configured, or the switch's ARP cache expires.
      
      The proper solution to that is to support different phases in network
      configuration (pre/post migration), which also requires separate ifup
      scripts. Until then we fall back to configuring bridged interfaces on
      incoming instances at migration start, instead of finish.
      Signed-off-by: default avatarApollon Oikonomopoulos <apollon@noc.grnet.gr>
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      cc8a8ed7
    • Iustin Pop's avatar
      96747bda
    • Iustin Pop's avatar
      Fix bug in drbd8 replace disks on current nodes · db8e5f1c
      Iustin Pop authored
      Currently the drbd8 replace-disks on the same node (i.e. -p or -s) has
      a bug in that it does modify the instance disk temporarily before
      changing it back to the same value. However, we don't need to, and
      shouldn't do that: what this operation do is simply change the LVM
      configuration on the node, but otherwise the instance disks keep the
      same configuration as before.
      
      In the current code, this change back-and-forth is fine *unless* we
      fail during attaching the new LVs to DRBD; in which case, we're left
      with a half-modified disk, which is entirely wrong.
      
      So we change the code in two ways:
      
      - use temporary copies of the disk children in the old_lvs var
      - stop updating disk.children
      
      Which means that the instance should not be modified anymore (except
      maybe for SetDiskID, which is a legacy and unfortunate decision that
      will have to cleaned up sometime).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      db8e5f1c
  9. 24 Jun, 2011 1 commit