Skip to content
Snippets Groups Projects
  1. Dec 14, 2010
  2. Dec 10, 2010
  3. Nov 29, 2010
    • Iustin Pop's avatar
      Simplify QA commands · 2f4b4f78
      Iustin Pop authored
      
      Currently, 95% of the QA commands are executed in the same way: on the
      master, based on a command list and with expectancies for succes:
      
          AssertEqual(StartSSH(master['primary'],
                               utils.ShellQuoteArgs(cmd)).wait(), 0)
      
      The rest 5% are variations on this theme (maybe the command needs to
      fail, or the node is different, etc.). Based on this, we can simplify
      the code significantly if we abstract the common theme into a new
      AssertCommand() function. This saves ~250 lines of code in the QA suite,
      around 8% of the entire QA code size.
      
      Additionally, the output was very cryptic before (the famous "QA error:
      1 != 0" messages), whereas now we show a clear error message (node,
      command, exit code and failure mode).
      
      The patch replaces single quotes with double quotes in all the parts of
      the code that I touch; let me know if that's not OK…
      
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      2f4b4f78
  4. Nov 01, 2010
  5. Jun 14, 2010
  6. May 11, 2010
  7. Mar 26, 2010
  8. Sep 05, 2008
    • Michael Hanselmann's avatar
      QA: Remove dry run mode · 26a61f87
      Michael Hanselmann authored
      It didn't work as planned because some commands depend on the return
      value or output of some operations.
      
      Reviewed-by: iustinp
      26a61f87
  9. Aug 26, 2008
  10. Aug 18, 2008
  11. Aug 15, 2008
  12. Feb 14, 2008
  13. Dec 03, 2007
  14. Nov 22, 2007
  15. Nov 08, 2007
  16. Nov 01, 2007
  17. Oct 18, 2007
  18. Oct 15, 2007
  19. Oct 12, 2007
  20. Oct 10, 2007
  21. Sep 26, 2007
    • Michael Hanselmann's avatar
      Enhance QA. · 5d640672
      Michael Hanselmann authored
      - Test “gnt-backup export” and “gnt-backup import”.
      - Move “ResolveInstanceName” to qa_utils.py.
      - Fix tests for “ganeti-watcher”.
      - Make instance shutdown and startup configurable.
      
      Reviewed-by: schreiberal
      
      5d640672
  22. Sep 13, 2007
Loading