1. 31 May, 2011 1 commit
    • Michael Hanselmann's avatar
      jqueue: Fix potential race condition when cancelling queued jobs · 66bd7445
      Michael Hanselmann authored
      
      
      When a job was cancelled, its status would be changed and the file
      written again. Since this was a final status, the job file could be
      moved anytime for archival. If the job was still in the queue, however,
      it would be processed (not fully, just updating the “end_timestamp”
      attribute) and written again. This was bad as it could leave the same
      job in two different files.
      
      With this patch the processor is changed to return early for finished
      jobs. Cancelling a queued job will finalize it right away. Unittests are
      updated.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      66bd7445
  2. 30 May, 2011 1 commit
    • Apollon Oikonomopoulos's avatar
      Fix argument order in ReserveLV and ReserveMAC · 8785b71b
      Apollon Oikonomopoulos authored
      
      
      ConfigWriter.ReserveLV() and Configwriter.ReserveMAC() called
      TemporaryReservationManager.Reserve() with the ec_id and resource arguments
      swapped. As a result, two reservation attempts for the same resource type
      within the same LU would fail, even if the resources requested were different,
      e.g.:
      
        $ gnt-instance add -t sharedfile -o debootstrap+default \
             --net 0:mac=00:01:02:03:04:00 \
             --net 1:mac=00:01:02:03:04:ff \
             --disk 0:size=2g  test_instance
        Failure: prerequisites not met for this operation:
        error type: resource_not_unique, error details:
        MAC address 00:01:02:03:04:ff already in use in cluster
      
      This patch fixes the argument order in the call to Reserve().
      Signed-off-by: default avatarApollon Oikonomopoulos <apollon@noc.grnet.gr>
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      8785b71b
  3. 26 May, 2011 1 commit
    • Michael Hanselmann's avatar
      TLReplaceDisks: Move assertion checking locks · a9b42993
      Michael Hanselmann authored
      Commit 1bee66f3
      
       added assertions for ensuring only the necessary locks
      are kept while replacing disks. One of them makes sure locks have been
      released during the operation. Unfortunately the commit added the check
      as part of a “finally” branch, which is also run when an exception is
      thrown (in which case the locks may not have been released yet). Errors
      could be masked by the assertion error. Moving the check out of the
      “finally” branch fixes the issue.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      a9b42993
  4. 24 May, 2011 6 commits
  5. 17 May, 2011 1 commit
  6. 16 May, 2011 6 commits
  7. 12 May, 2011 4 commits
  8. 11 May, 2011 3 commits
  9. 10 May, 2011 3 commits
  10. 09 May, 2011 4 commits
    • Iustin Pop's avatar
      Some man page updates · 0a68e0ff
      Iustin Pop authored
      
      
      This adds documentation for both the short and long form of many
      options (which was inconsistent before: in some cases only the short
      form was used, in others only the long form).
      
      Note that the standard this patch adopts is to document both forms as
      such:
      
        {-O|--os-parameters} …
      
      This makes it a bit uglier in complex situations, but the alternatives
      considered were not perfect either. Other suggestions (with patches)
      welcome.
      
      Additionally, it fixes two doc bugs:
      
      - in gnt-cluster.rst, the --prealloc-wipe-disks section was in the
        middle of a paragraph
      - in gnt-instance.rst, a list was not typed correctly, thus it was
        mangled as a single paragraph
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      0a68e0ff
    • Marco Casavecchia's avatar
      Add 2 new variables to the OS scripts environment · 519719fd
      Marco Casavecchia authored
      
      
      Add INSTANCE_PRIMARY_NODE and INSTANCE_SECONDARY_NODES. These new
      values are useful for OS scripts that needs to know the nodes where
      the instance lives.. or has lived.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      [iustin@google.com: fixed small issue with SECONDARY_NODES]
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      519719fd
    • Iustin Pop's avatar
      Add --no-wait-for-sync when converting to drbd · 456798ab
      Iustin Pop authored
      
      
      Currently, when converting an instance from plain to DRBD, the
      instance is blocked during the entire resync period. This patch adds
      the --no-wait-for-sync so that the operation finishes as soon as the
      DRBD sync has started, without waiting for the entire sync. This makes
      the instance available much faster.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      456798ab
    • Iustin Pop's avatar
      Recreate instance disks: allow changing nodes · c8a96ae7
      Iustin Pop authored
      
      
      This patch introduces the option of changing an instance's nodes when
      doing the disk recreation. The rationale is that currently if an
      instance lives on a node that has gone down and is marked offline,
      it's not possible to re-create the disks and reinstall the instance on
      a different node without hacking the config file.
      
      Additionally, the LU now locks the instance's nodes (which was not
      done before), as we most likely allocate new resources on them.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      c8a96ae7
  11. 06 May, 2011 2 commits
  12. 04 May, 2011 2 commits
  13. 03 May, 2011 2 commits
  14. 02 May, 2011 4 commits