Commit 931413f6 authored by Iustin Pop's avatar Iustin Pop
Browse files

Rename instance: only show new name when different

It makes not sense to show messages like:
Fri May  6 02:04:01 2011  - INFO: Resolved given name 'instance18' to

So we'll skip the message if the resolved name is identical to the
requested one.
Signed-off-by: default avatarIustin Pop <>
Reviewed-by: default avatarMichael Hanselmann <>
parent 9d5b1371
......@@ -5536,8 +5536,9 @@ class LUInstanceRename(LogicalUnit):
new_name = self.op.new_name
if self.op.name_check:
hostname = netutils.GetHostname(name=new_name)
self.LogInfo("Resolved given name '%s' to '%s'", new_name,
if hostname != new_name:
self.LogInfo("Resolved given name '%s' to '%s'", new_name,
new_name = self.op.new_name =
if (self.op.ip_check and
netutils.TcpPing(hostname.ip, constants.DEFAULT_NODED_PORT)):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment