This increases the overall coverage by 5%-10% (depending on coverage
type). Some modules are still not unittested at all, as HUnit is a
better choice for them.

… and export more functions. This will help with unit testing.

This patch moves from allowing no-limits for disk/cpu ratios, and always
use a real limit. For disk, it's simple since we use 0, which means no
reservations for disks. For CPU, we set an (arbitrary) limit of 64 v/p,
which should be reasonable as a default limit (it can be changed via the
command line).

Currently we just print a fake result and exit early. This is bad, since
it doesn't use the same codepaths for all the result printing, and has
already led to a bug where hspace looks like completely ignoring the
tiered specs request.

This patch changes the code to override the computation, instead of the
printout, thus allowing tiered specs results for such cases.

We returned the KM_POOL_* metrics as the final state, not as the delta
between the final and the initial state.

This patch adds the metrics of used/allocable/unallocable resources.

In case we're not enabling limits, let's restrict this to -1, instead of
-1 times the number of pcpus.

Given two cluster states, the new function can answer the following
questions:

- how much resources currently allocated
- how much resources finally allocated (delta from above is how much we
  can actually allocate on the cluster)
- unallocable resources (whatever is left free after the previous step)

We add a new field that tracks the available virtual cpus (expressed as
node cpus times the vcpu ratio).

* master:
  Fix iallocator crash when no solutions exist
  Fix IAllocator multi-evacuate message

Commit 54365762 added an un-guarded `head' call, which crashes with
“Prelude.head: empty list” when no results exists for the per-instance
allocation/relocation calls.

This patch fixes this, and also adds another check for an unguarded
`head' call during parsing of input data.
(cherry picked from commit e41f4ba0)

Since Ganeti passes full host names (not common-suffix-stripped), we
need to remove the suffix from the evac_nodes keys too. In case one node
is not part of the cluster, it will lead to a wrong error message, but
for now it fixes the problem.

Commit 54365762 added an un-guarded `head' call, which crashes with
“Prelude.head: empty list” when no results exists for the per-instance
allocation/relocation calls.

This patch fixes this, and also adds another check for an unguarded
`head' call during parsing of input data.

For some versions of haddock, this can create problems.

This removes some manual checks from a few places in the code with a
single list defined once.

GHC 6.12 has some new warnings, which are valid in most cases except
(IMHO) printf usage.

GHC 6.12 has become more picky about unused imports, so we need to
remove/tighten some of them.

… via a GHC make variable.

This allows hscan to work also with NO_CURL (but only for the local
machine, of course).

Instead of deciding based on secondary node, use the new flag.

This updates the movable flag on instances if they have only one node
(we don't rely on OpMoveInstance) or if they are set so via the command
line options.

This doesn't yet enable the use of the new flag.

This will be used instead of checking for no secondary and for
simplifying 'do not touch' instances.

This adds a short note for the new iallocator mode.

Signed-off-by: Iustin Pop <iustin@google.com>

This patch adds the new request loading/execution (trivial), but the
actual response formatting becomes more difficult as now the response
type differs by request.

Signed-off-by: Iustin Pop <iustin@google.com>

This will be used by the node evacuate IAllocator request type.

Signed-off-by: Iustin Pop <iustin@google.com>

We'll need AllocElement in both Cluster and IAlloc in the future, so we
move it to Node.hs which is imported by both.

Signed-off-by: Iustin Pop <iustin@google.com>

In preparation for multiple responses, we change from Maybe to List
(both used in the container sense).

This allows us to keep the same workflow for all kind of requests.

Signed-off-by: Iustin Pop <iustin@google.com>

Since not all structures will have these keys in the future, we move
them into per-structure keys.

Signed-off-by: Iustin Pop <iustin@google.com>

Signed-off-by: Iustin Pop <iustin@google.com>

This mode restricts the list of instances to be moved to the instances
living on the offline (and drained) nodes.

Signed-off-by: Iustin Pop <iustin@google.com>

Signed-off-by: Iustin Pop <iustin@google.com>