- Jul 06, 2012
-
-
René Nussbaumer authored
For compatibility with the old Ganeti version, we want to keep the beparams/memory field around for another release. This patch fixes this regression. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- Jul 05, 2012
-
-
Iustin Pop authored
Currently, _RedistributeAncillaryFiles computes two lists: the list of online nodes (for all files redistribution), and the list of vm_capable nodes, for hypervisor-specific files. However, the vm_capable list includes offline nodes too, leading to warning messages: WARNING: Copy of file /etc/xen/xend-config.sxp to node node13.example.com failed: Node is marked offline We fix this by trivially intersecting the vm_capable list with the online one. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Bernardo Dal Seno <bdalseno@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
René Nussbaumer authored
This error does not show up until we exceed the pool of master candidates and have nodes which are not master candidates. The background is that we check for master-ip-setup script on master candidates and expect them not to be on the other nodes. However, we distribute a default master-ip-script which break this assumption. Furthermore, there's no reason why the file should just exists on the master candidates. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- Jun 29, 2012
-
-
Constantinos Venetsanopoulos authored
With the new gnt-instance modify syntax for addition and removal of disks/NICs on arbitrary indexes, we hit an assertion if the user passes `modify' as one of the disk's parameters. E.g:: gnt-instance modify --disk 2:modify,size=3G instance1 gnt-instance modify --disk 3:add,size=1G,modify instance2 This patch fixes the bug, by allowing `modify' to be passed as a parameter (as happens with `add' and `remove'), as long as it is not done alongside `add' or `remove'. If so, it is treated in the same way as if none of modify/add/remove is passed --> modify. Signed-off-by:
Constantinos Venetsanopoulos <cven@grnet.gr> Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Agata Murawska <agatamurawska@google.com>
-
- Jun 28, 2012
-
-
René Nussbaumer authored
We call _OpenRealBD during the process and this needs disk parameters to work. This was reported by Constantinos. The fix is very ugly though. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- Jun 27, 2012
-
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Agata Murawska <agatamurawska@google.com>
-
René Nussbaumer authored
This annotates the disks for the blockdev_remove where it is appropriate. It leaves out 2 cases were we can't reliably annotate disk parameters due to lack of knowledge what we should annotate. Those cases affects only lvs used for drbd, so it doesn't affect the bug reported by Constantinos. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Agata Murawska <agatamurawska@google.com>
-
René Nussbaumer authored
This is also related to the bug reported by Constantinos, as we've only one getmirrorstatus_multi call in whole cmdlib, we just annotate them while we are building the disk list. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Agata Murawska <agatamurawska@google.com>
-
René Nussbaumer authored
Not annotating them works for DRBD but not for RBD as reported by Constantinos. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Agata Murawska <agatamurawska@google.com>
-
- Jun 20, 2012
-
-
Iustin Pop authored
_PrepareNicModification returns the invalid type, which triggers an assert resulting in a mysterious error: Failure: command execution error: Without any explanation. We fix this by removing the return value from _PrepareNicModification, and instead returning the expected type (since it differs per create/modification) from the (existing) wrappers for this function. We don't need to return actual changes from this function as _ApplyNicMods is the function that computes/returns the formatted changes. Signed-off-by:
Iustin Pop <iustin@google.com> Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Jun 19, 2012
-
-
Michael Hanselmann authored
The function is supposed to return a list, not a string. Without this patch the error message ends up as “C, a, n, ', t, , c, h, a, n, g, e, …”. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- Jun 18, 2012
-
-
Iustin Pop authored
While reviewing the RAPI docs (for commit 003306f9), I realised that the punctuation used in RAPI is inconsistent, especially with regards to definition lists. This patch changes all such lists to not have punctuation, except for one case (the ecode descriptions, which have multiple paragraphs). Furthermore, it fixes the few opcodes which had docs ending with punctuation to not do so anymore. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Jun 15, 2012
-
-
Iustin Pop authored
Sadly we don't have a way to test that, for example, all (G|N|I)Q_CONFIG fields are exported in RAPI, so for now we don't test this; but we should, in the future. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
René Nussbaumer authored
This prevents from setting for example drbd options on the plain disk template. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
René Nussbaumer authored
This verifies the user (especially in nested dicts) does not provide a key which is not seen in the defaults dict for that dict. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Jun 14, 2012
-
-
Michael Hanselmann authored
These can be used, for example, to get jobs submitted after a certain timestamp. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Iustin Pop authored
As reported on the devel mailing list by Christos Stavrakakis, creation of plain instances is broken when the --no-wait-for-sync flag is passed, because in that case WaitForSync is not called, hence SetDiskID is not called at all, resulting in a None physical_id being passed to backend. We fix that by explicitly calling SetDiskID, which will cover the pause/resume and os_add RPC calls. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Jun 12, 2012
-
-
Bernardo Dal Seno authored
This patch only touches comments and man pages. Signed-off-by:
Bernardo Dal Seno <bdalseno@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Iustin Pop authored
For epydoc raise statement, it already expects an exception which will be hyperlinked; if passing an L{…} construct, it will instead break the formatting (the @raise will not be recognised, but merged into the previous paragraph). Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Jun 11, 2012
-
-
Iustin Pop authored
Per issue 243, "side-effects" are GenerateRuntime are bad as they execute only on the initial node of the instance. By moving the write-out of the keymap file to ExecuteRuntime, it will be done both at start and at migrate time. Furthermore, we update the docstring of GenerateKVMRuntime to explain this, and add a fixme related to the spice per-interface binding. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
-
Iustin Pop authored
Commit 4f580fef added the keymap support, but missed that this directory needs to be ensured/created at hypervisor init time. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
-
- Jun 08, 2012
-
-
Iustin Pop authored
This has been reported internally 3-4 times already, and the current version (from 8b437a6e) is still not good enough, it seems. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
This way, it can be reused in the Haskell code too. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
-
- Jun 01, 2012
-
-
Iustin Pop authored
Commit 2e04d454 introduced the new offline state for the instance state, but being a big monolithic patch it sneaked in something that doesn't make sense. The checks for extra instances (either wrongly up or just unknown) are done purely on a name-basis, not on objects, so the types there are wrong. Furthermore, they have no relation to the admin state of the instance, so we just drop the entire if block. We keep the increment of the offline instance count, but move it to a different loop over instances. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- May 31, 2012
-
-
René Nussbaumer authored
xm and xl are mostly compatible, there is just a change in migrate, which for now we simple bridge by comparing the command string. Also XEN_CMD is now set during configure time. This will then be fixed in Ganeti 2.7 when we make it an hvparams. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- May 30, 2012
-
-
René Nussbaumer authored
Redhat links its pycurl against NSS/ so this check fails and therefore makes ganeti-watcher unusable. Even though this seems to fix the problem and works, further testing on this might be needed. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- May 29, 2012
-
-
Iustin Pop authored
This didn't get completed in time for 2.6, so we document that it's not working as is. Well, it's not broken, just not used by anything. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
Iustin Pop authored
These were using exactly 80 chars, and I like them smaller. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- May 22, 2012
-
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Iustin Pop authored
This is adapted from the design doc. Also fixes a typo in cmdlib.py. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- May 21, 2012
-
-
René Nussbaumer authored
This patch reworks the beparams listing to the new style. However, due to this process the naming of the fields with mixed casing changed to lowercase and is therefore not 100% compatible with the previous versions. As "memory" is marked deprecated and sort of default we merge that just into the actual dict, which leads to the following output: - maxmem: 128 - memory: default (128) - minmem: 128 Instead of: - maxmem: 128 - minmem: 128 - memory: 128 Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- May 15, 2012
-
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Iustin Pop authored
This makes "gnt-cluster modify --specs-mem-size max=16g" work. The downside (due to how we iterate) is that error messages are not very clear: $ gnt-cluster modify --specs-mem-size max=16a Failure: prerequisites not met for this operation: error type: wrong_input, error details: Invalid disk ({}) or memory ({'max': '16a'}) size in policy: Unknown unit: a Also updates the help of these commands, which was very confusing before (at least for me). Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
These are only used in CLI programs to parse command line options and such they do not belong in object.py (I will change them more and I don't want to add more code in objects.py). Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
This function did the opposite: was computing which old instance violated the specs but no longer do it now. new - old is the expected behaviour. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-