- Mar 07, 2011
-
-
Iustin Pop authored
NEWS update and version bump. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
* devel-2.3: Fix LUClusterRepairDiskSizes and rpc result usage Fix RPC mismatch in blockdev_getsize[s] RAPI: fix evacuate node resource Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
Iustin Pop authored
Also specifies the comma-escaping feature. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
Iustin Pop authored
* devel-2.2: Fix LUClusterRepairDiskSizes and rpc result usage Fix RPC mismatch in blockdev_getsize[s] Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- Mar 04, 2011
-
-
Iustin Pop authored
This LU was introduced before the RPC result conversion from .data to .payload, and it has managed to keep the old-style usage (how? it's the only LU that does so). Fix by changing to payload, and add some extra logging for easier diagnose. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com> (cherry picked from commit 043beb38)
-
Iustin Pop authored
Commit 92fd2250 added consistency checks in the RPC layer, which broke the call_blockdev_getsizes RPC call (declared with 's' at the end in rpc.py, without 's' in the node daemon). The immediate fix is to correct the rpc function name, the long term one will be to remove this duplication. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Stephen Shirley <diamond@google.com> (cherry picked from commit ccfbbd2d)
-
Iustin Pop authored
PollJob returns the whole op_results, hence a list of opcode results. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- Mar 02, 2011
-
-
Guido Trotter authored
* origin/stable-2.4: Fix typo in kvm-ifup script NEWS: Replace smartquotes, start lines with uppercase Update NEWS and release 2.4.0 rc3 Fix potential data-loss bug in disk wipe routines Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Michael Hanselmann authored
Reported-by:
Bas Tichelaar <bas@30loops.net> Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
-
- Mar 01, 2011
-
-
Michael Hanselmann authored
- Sphinx converts ASCII quotes ("") to smartquotes (“”) automatically - Sentences or list items start with an uppercase letter - Changed description of non-verbose “gnt-* list” output slightly Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- Feb 28, 2011
-
-
Michael Hanselmann authored
The exception was never actually raised. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Adeodato Simo <dato@google.com>
-
Iustin Pop authored
Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
Iustin Pop authored
* devel-2.4: 1-char comment typo fix Expand some acronyms, add to glossary query_unittest: Fix argument to set() Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
Iustin Pop authored
For the 2.4 release, we only add the missing RPC calls. However, this needs to be fixed properly, by preventing usage of mis-configured disks. Also add a bit more logging so that it's directly clear on which node the wipe is being done. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- Feb 25, 2011
-
-
Stephen Shirley authored
Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Feb 24, 2011
-
-
Stephen Shirley authored
Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Feb 23, 2011
-
-
René Nussbaumer authored
Commit e431074f introduced an uncatched bug. This patch fixes this. The set is expecting a list or iteratable to work on, so it splitted the provided instance name into a set of characters. This caused the exp_status never been set and therefore not catched in one assert rule further below who checks that every status was tested. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Feb 22, 2011
-
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- Feb 21, 2011
-
-
Iustin Pop authored
Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
Iustin Pop authored
* devel-2.4: (23 commits) Fix pylint warnings Change the list formatting to a 'special' chars Add support for merging node groups Add option to rename groups on conflict Fix minor docstring typo Fix HV/OS parameter validation on non-vm nodes NodeQuery: mark live fields as UNAVAIL for non-vm_capable nodes NodeQuery: don't query non-vm_capable nodes Remove superfluous redundant requirement Don't remove master_candidate flag from merged nodes Use a consistent ECID base listrunner: convert from getopt to optparse listrunner: fix agent usage Revert "Disable the cluster-merge tool for the moment" Fix cluster-merging by not stopping noded Fix error msg for instances on offline nodes Minor reordering to match param order cluster verify and instance disks on offline nodes Cluster verify and N+1 warnings for offline nodes Handle gnt-instance shutdown --all for empty clusters Use gnt-node add --force-join to add foreign nodes Add --force-join option to gnt-node add Fix iterating over node groups Of the above commits present in the devel-2.4 branch, only the “Add --force-join option to gnt-node add” is a potential issue, but this has been QA-ed successfully. The other fixes are split in three groups: - non-core changes (cluster-merge, listrunner) - trivial fixes (docstrings, etc.) - bugs that we want fixed As such, instead of cherry-picking only individual patches, I propose that we unify stable and devel 2.4 and make a new RC out of the result. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Feb 18, 2011
-
-
Stephen Shirley authored
- 1 80-char line infraction - 4 changes in how arguments are passed to logging functions - 3 pylint disable-msg's because cluster-merge needs to access ganeti config internals Signed-off-by:
Stephen Shirley <diamond@google.com> Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
-
Guido Trotter authored
Currently the QA rename job wrongly passed the whole info dict to the client. Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Iustin Pop authored
And also enable verbose display via the, well, verbose option. Man page and tests are updated, and the formatting is moved from 4 if statements to a data structure. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Stephen Shirley authored
Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Stephen Shirley authored
Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Stephen Shirley authored
Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Guido Trotter authored
This tests at least the basic case, unfortunately there is no way to check all possibilities using the provided rapi client, as that will use the new method unless the cluster doesn't support it. Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Guido Trotter authored
Before c744425f instance reinstall accepted the "os" and "nostartup" optional query parameters. With that commit it was changed to allow "os" "start" and "osparams" via body rather than encoded in the URL. Unfortunately that commit introduced a bug, which required the "os" parameter to be passed for body requests, and at least one of "os" or "nostartup" for query request. This fix makes sure all parameters are optional again. Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- Feb 17, 2011
-
-
Iustin Pop authored
Currently, there is at least one LU that does wrong validation of HV parameters (against all nodes, LUClusterSetParams). It's possible to fix this case, but I went and modified the base functions to filter out non-vm_capable nodes so all callers are protected. Note: the _CheckOSParams function is never called with all nodes list, so modifying it shouldn't be needed. However, I think it's safe to do so (and it shouldn't hurt as an instance's node shouldn't ever lack the vm_capable bit). Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
Since we don't have the data per design, UNAVAIL is appropriate here, while NODATA is not. The patch also adds a comment: if we extend the live fields list to contain other data in the future, we need to reevaluate this solution. This should fix issue 143. The listing now shows (node2==ofline, node3==not vm_capable): Node DTotal DFree MTotal MNode MFree Pinst Sinst node1 698.6G 630.5G 32.0G 1.0G 30.0G 8 7 node2 (offline) (offline) (offline) (offline) (offline) 9 4 node3 (unavail) (unavail) (unavail) (unavail) (unavail) 0 0 Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
Because non-vm_capable nodes most likely don't have a hypervisor configured and/or storage, so the call will fail anyway. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
This LU was introduced before the RPC result conversion from .data to .payload, and it has managed to keep the old-style usage (how? it's the only LU that does so). Fix by changing to payload, and add some extra logging for easier diagnose. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
Commit 92fd2250 added consistency checks in the RPC layer, which broke the call_blockdev_getsizes RPC call (declared with 's' at the end in rpc.py, without 's' in the node daemon). The immediate fix is to correct the rpc function name, the long term one will be to remove this duplication. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Stephen Shirley <diamond@google.com>
-
Stephen Shirley authored
The condition is already covered by the previous requirement. Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Stephen Shirley authored
Prevents lots of spurious warnings like: 2011-02-10 17:00:22,776: CRITICAL Configuration data is not consistent: Not enough master candidates: actual 3, target 4 Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Stephen Shirley authored
ECID was being calculated completely differently in __MergeNodeGroups() and _MergeConfig() Signed-off-by:
Stephen Shirley <diamond@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Feb 16, 2011
-
-
Iustin Pop authored
The “-A” (use agent) was not documented, and instead of adding manual listing, I converted it to optparse like the other CLI tools. Note that I cleaned up a bit the usage and help texts. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
By delaying the agent key query until after the fork, we prevent the problem of simultaneous access to the agent. Tested that it works against 80 hosts in parallel without error; the current version breaks already at 20 hosts. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- Feb 14, 2011
-
-
Stephen Shirley authored
This reverts commit c0711f2c. Signed-off-by:
Stephen Shirley <diamond@google.com> Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Stephen Shirley authored
cli.RunWhileClusterStopped() stops noded on all of the nodes in the original cluster. This prevents /etc/hosts updates on the master, and config redistribution doesn't reach the other nodes in the original cluster. As all we want to do is merge while the master is stopped, simply stop it and start it again after. Signed-off-by:
Stephen Shirley <diamond@google.com> Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-