Commit 043beb38 authored by Iustin Pop's avatar Iustin Pop
Browse files

Fix LUClusterRepairDiskSizes and rpc result usage

This LU was introduced before the RPC result conversion from .data to
.payload, and it has managed to keep the old-style usage (how? it's
the only LU that does so). Fix by changing to payload, and add some
extra logging for easier diagnose.
Signed-off-by: default avatarIustin Pop <>
Reviewed-by: default avatarStephen Shirley <>
Reviewed-by: default avatarMichael Hanselmann <>
parent ccfbbd2d
......@@ -2579,11 +2579,13 @@ class LUClusterRepairDiskSizes(NoHooksLU):
self.LogWarning("Failure in blockdev_getsize call to node"
" %s, ignoring", node)
if len( != len(dskl):
if len(result.payload) != len(dskl):
logging.warning("Invalid result from node %s: len(dksl)=%d,"
" result.payload=%s", node, len(dskl), result.payload)
self.LogWarning("Invalid result from node %s, ignoring node results",
for ((instance, idx, disk), size) in zip(dskl,
for ((instance, idx, disk), size) in zip(dskl, result.payload):
if size is None:
self.LogWarning("Disk %d of instance %s did not return size"
" information, ignoring", idx,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment