Skip to content
Snippets Groups Projects
Commit 729c4377 authored by Iustin Pop's avatar Iustin Pop
Browse files

Fix QA mixup of node/instance tests


There are two node tests that are run from RunCommonInstanceTests, which is the
bad place—it causes these node tests to be run three times instead of once.

Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
parent eb180fe2
No related branches found
No related tags found
No related merge requests found
...@@ -213,15 +213,20 @@ def RunCommonInstanceTests(instance): ...@@ -213,15 +213,20 @@ def RunCommonInstanceTests(instance):
if qa_config.TestEnabled('tags'): if qa_config.TestEnabled('tags'):
RunTest(qa_tags.TestInstanceTags, instance) RunTest(qa_tags.TestInstanceTags, instance)
if qa_rapi.Enabled():
RunTest(qa_rapi.TestInstance, instance)
def RunCommonNodeTests():
"""Run a few common node tests.
"""
if qa_config.TestEnabled('node-volumes'): if qa_config.TestEnabled('node-volumes'):
RunTest(qa_node.TestNodeVolumes) RunTest(qa_node.TestNodeVolumes)
if qa_config.TestEnabled("node-storage"): if qa_config.TestEnabled("node-storage"):
RunTest(qa_node.TestNodeStorage) RunTest(qa_node.TestNodeStorage)
if qa_rapi.Enabled():
RunTest(qa_rapi.TestInstance, instance)
def RunExportImportTests(instance, pnode, snode): def RunExportImportTests(instance, pnode, snode):
"""Tries to export and import the instance. """Tries to export and import the instance.
...@@ -363,6 +368,8 @@ def main(): ...@@ -363,6 +368,8 @@ def main():
if qa_config.TestEnabled('tags'): if qa_config.TestEnabled('tags'):
RunTest(qa_tags.TestClusterTags) RunTest(qa_tags.TestClusterTags)
RunCommonNodeTests()
pnode = qa_config.AcquireNode(exclude=qa_config.GetMasterNode()) pnode = qa_config.AcquireNode(exclude=qa_config.GetMasterNode())
try: try:
if qa_config.TestEnabled('node-readd'): if qa_config.TestEnabled('node-readd'):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment