Commit eb180fe2 authored by Iustin Pop's avatar Iustin Pop
Browse files

ConfigWriter: prevent using a foreign config

If the configuration file doesn't denote this node as master, we prevent
startup. This would have detected our previous race condition more
easily, hence we add it as a permanent check.
Signed-off-by: default avatarIustin Pop <>
Reviewed-by: default avatarMichael Hanselmann <>
parent 21004460
......@@ -605,7 +605,7 @@ def MasterFailover(no_voting=False):
# instantiate a real config writer, as we now know we have the
# configuration data
cfg = config.ConfigWriter()
cfg = config.ConfigWriter(accept_foreign=True)
cluster_info = cfg.GetClusterInfo()
cluster_info.master_node = new_master
......@@ -132,7 +132,8 @@ class ConfigWriter:
@ivar _all_rms: a list of all temporary reservation managers
def __init__(self, cfg_file=None, offline=False, _getents=runtime.GetEnts):
def __init__(self, cfg_file=None, offline=False, _getents=runtime.GetEnts,
self.write_count = 0
self._lock = _config_lock
self._config_data = None
......@@ -156,7 +157,7 @@ class ConfigWriter:
self._my_hostname = netutils.Hostname.GetSysName()
self._last_cluster_serial = -1
self._cfg_id = None
# this method needs to be static, so that we can call it on the class
......@@ -1291,7 +1292,7 @@ class ConfigWriter:
self._config_data.nodegroups.values() +
def _OpenConfig(self):
def _OpenConfig(self, accept_foreign):
"""Read the config data from disk.
......@@ -1310,6 +1311,13 @@ class ConfigWriter:
raise errors.ConfigurationError("Incomplete configuration"
" (missing cluster.rsahostkeypub)")
if data.cluster.master_node != self._my_hostname and not accept_foreign:
msg = ("The configuration denotes node %s as master, while my"
" hostname is %s; opening a foreign configuration is only"
" possible in accept_foreign mode" %
(data.cluster.master_node, self._my_hostname))
raise errors.ConfigurationError(msg)
# Upgrade configuration if needed
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment