This will be used to lock the instance's nodes in addition to some more.

Reviewed-by: iustinp

This function was incompatible with the new locking system, and its
usage has been removed from the code. For now LUs share code by calling
common module-private functions in cmdlib.py, in the future they will
use tasklets (when those will be implemented).

Reviewed-by: iustinp

Now that they are not used in other opcodes by chaining,
this can easily be done.

Reviewed-by: iustinp

The calls to OpActivateInstanceDisks and OpDeactivateInstanceDisks has
been replaced by _StartInstanceDisks and _SafeShutdownInstanceDisks
respectively. This is the last usage of ChainOpCode.

Reviewed-by: iustinp

This new function checks whether an instance is running, before shutting
down its disks. This is what the Exec() of LUDeactivateInstanceDisks
did, so that is replaced by a call to this function.

Reviewed-by: iustinp

s/locking.LEVEL_INSTANCES/locking.LEVEL_INSTANCE/

Reviewed-by: iustinp

This constant replaces what we used to write in recalculate_locks, and
represents the lock recalculation mode. It lives in constants.py because
it's used only in cmdlib, and thus doesn't deal with the locking library
by itself.

Reviewed-by: iustinp

self._RunAllocator() sets self.op.remote_node, but doesn't return the
new remote node. If we set it to the return value of the function we
basically reset it to None, and iallocator is never run.

Reviewed-by: imsnah

This helps to prevent complete deadlocks.

Reviewed-by: iustinp

The rpc library returns a list, not a tuple, so we'll accept both.

Reviewed-by: iustinp

The rpc library returns a list, not a tuple, so we'll accept both.

Reviewed-by: iustinp

Fixing the check in gnt-cluster, or gnt-cluster verify-disks is broken.
Since the version in 1.2 used to return a tuple we'll accept both.

Reviewed-by: iustinp

Unfortunately for the first version we need to lock all nodes. The patch
discusses why this is and discuss ways to improve this in the future.

Reviewed-by: iustinp

Reviewed-by: iustinp

When rebooting an instance and we're not changing it's disks status (all
the cases except in a "full" reboot) we can lock just its primary node.

Reviewed-by: iustinp

As the name says when the flag is on (the default is off) only the
primary nodes are locked, as opposed to all of them.

Reviewed-by: iustinp

The timeout can be used in ganeti-noded to be more robust against
deadlocks.

Reviewed-by: iustinp

Also change title formatting to match client-api.txt.

Reviewed-by: iustinp

Only one process should modify the queue at the same time.

Reviewed-by: iustinp

It didn't work as planned because some commands depend on the return
value or output of some operations.

Reviewed-by: iustinp

Rather than specifying None in needed_locks every time, with a nice
comment saying to read what we mean rather than what we write, and that
None actually means All, in our magic world, we'll hide this secret
under the ALL_SET constant in the locking module, which has value, you
guessed it, None. After that we'll substitute all usage in cmdlib.

Some comments and examples have been fixed as well.

Reviewed-by: iustinp

SplitTime didn't round the same on different platforms. This patch changes
it to use microseconds and not care about rounding.

Reviewed-by: iustinp

This is not nice, removing it :)

Please use 'set nobomb' in your vi init file.

Reviewed-by: ultrotter

All the users of _GetWantedNodes have been converted to be concurrent
LUs, and thus cannot call this function with an empty list of nodes
anymore. This patch makes this restriction a part of the function
itself. This prevents mistakes in new concurrent LUs, and creates more
work for new non-concurrent LUs, which we shouldn't add anyway.

Reviewed-by: iustinp

Reviewed-by: iustinp

Reviewed-by: iustinp

It turns out this fields was already mandatory. If it hadn't beed valid,
in fact, a value of None would have been passed to _GetWantedNodes which
would have thrown an exception.

Reviewed-by: iustinp

Parallel opcodes are not (yet?) supported for chaining. Turns out
though that chaining is used only four times in the code, and twice it's
for querying exports. But what's the need to chain the full opcode, when
the simple call_export_list rpc is going to provide the same result?

Reviewed-by: iustinp

Reviewed-by: iustinp

Use a default vnc_bind_address if None is specified

Reviewed-by: iustinp

Implement more options for gnt-backup import

Reviewed-by: ultrotter

Add more fields to gnt-instance list

Reviewed-by: imsnah

Fix wrong wording of instance rename error message.

Reviewed-by: imsnah

Document behaviour of gnt-instance console for HVM

Reviewed-by: imsnah

Implement interactive instance OS reinstall.

Reviewed-by: ultrotter

more information for VNC console port

Reviewed-by: ultrotter

Allow access to HVM serial console

Reviewed-by: imsnah

Display VNC console port in gnt-instance info.


Reviewed-by: iustinp

Check HVM device type on instance modify as well.

Reviewed-by: imsnah

With this change when a user asks for a new memory size for an instance,
the number is checked instead of just applied. The operation fails only
if the instance would not be able to restart on its primary node, but
generates warnings should it be impossible to failover the instance or
should the computation be impossible due to nodes being unreachable.

This is a forward-port from branches/ganeti-1.2

Original-Reviewed-by: iustinp
Reviewed-by: iustinp