1. 24 Jun, 2011 1 commit
  2. 23 Jun, 2011 4 commits
  3. 22 Jun, 2011 1 commit
  4. 17 Jun, 2011 15 commits
  5. 15 Jun, 2011 1 commit
  6. 14 Jun, 2011 1 commit
  7. 10 Jun, 2011 4 commits
  8. 09 Jun, 2011 1 commit
  9. 08 Jun, 2011 2 commits
    • Michael Hanselmann's avatar
      Fix locking issues in LUClusterVerifyGroup · fceb01fe
      Michael Hanselmann authored
      
      
      - Use functions in ConfigWriter instead of custom loops
      - Calculate nodes only once instances locks are acquired, removes one
        potential race condition
      - Don't retrieve lists of all node/instance information without locks
      - Additionally move the end of the node time check window after the
        first RPC call--the second call isn't involved in checking the
        node time at all
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      fceb01fe
    • Michael Hanselmann's avatar
      cmdlib: Acquire BGL for LUClusterVerifyConfig · c5312a10
      Michael Hanselmann authored
      
      
      LUClusterVerifyConfig verifies a number of configuration settings. For
      doing so, it needs a consistent list of nodes, groups and instances. So
      far no locks were acquired at all (except for the BGL in shared mode).
      This is a race condition (e.g. if a node group is added in parallel) and
      can be fixed by acquiring the BGL in exclusive mode. Since this LU
      verifies the cluster-wide configuration, doing so instead of acquiring
      individual locks is just.
      
      Includes one typo fix and one docstring update.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      c5312a10
  10. 07 Jun, 2011 2 commits
  11. 03 Jun, 2011 1 commit
  12. 01 Jun, 2011 7 commits