Commit e2e10467 authored by Iustin Pop's avatar Iustin Pop
Browse files

Rename an ConfdInotifyEventHandler init argument

'file' is a builtin keyword/type. Like many others, it should not be
used as a variable/argument name.

No code is actually passing in this argument so renaming it is simple.
Signed-off-by: default avatarIustin Pop <>
Reviewed-by: default avatarOlivier Tharan <>
parent e0098923
......@@ -88,15 +88,15 @@ class ConfdAsyncUDPServer(daemon.AsyncUDPSocket):
class ConfdInotifyEventHandler(pyinotify.ProcessEvent):
def __init__(self, watch_manager, callback,
"""Constructor for ConfdInotifyEventHandler
@type watch_manager: L{pyinotify.WatchManager}
@param watch_manager: ganeti-confd inotify watch manager
@type callback: function accepting a boolean
@param callback: function to call when an inotify event happens
@type file: string
@param file: config file to watch
@type filename: string
@param filename: config file to watch
# no need to call the parent's constructor
......@@ -104,7 +104,7 @@ class ConfdInotifyEventHandler(pyinotify.ProcessEvent):
self.callback = callback
self.mask = pyinotify.EventsCodes.IN_IGNORED | \
self.file = file
self.file = filename
self.watch_handle = None
def enable(self):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment