From e2e104671b89481e0e430ba8d5437b7d1a6f9825 Mon Sep 17 00:00:00 2001
From: Iustin Pop <iustin@google.com>
Date: Tue, 29 Dec 2009 12:18:20 +0100
Subject: [PATCH] Rename an ConfdInotifyEventHandler init argument
'file' is a builtin keyword/type. Like many others, it should not be
used as a variable/argument name.
No code is actually passing in this argument so renaming it is simple.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Olivier Tharan <olive@google.com>
---
daemons/ganeti-confd | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/daemons/ganeti-confd b/daemons/ganeti-confd
index 24245fa62..421e73cce 100755
--- a/daemons/ganeti-confd
+++ b/daemons/ganeti-confd
@@ -88,15 +88,15 @@ class ConfdAsyncUDPServer(daemon.AsyncUDPSocket):
class ConfdInotifyEventHandler(pyinotify.ProcessEvent):
def __init__(self, watch_manager, callback,
- file=constants.CLUSTER_CONF_FILE):
+ filename=constants.CLUSTER_CONF_FILE):
"""Constructor for ConfdInotifyEventHandler
@type watch_manager: L{pyinotify.WatchManager}
@param watch_manager: ganeti-confd inotify watch manager
@type callback: function accepting a boolean
@param callback: function to call when an inotify event happens
- @type file: string
- @param file: config file to watch
+ @type filename: string
+ @param filename: config file to watch
"""
# no need to call the parent's constructor
@@ -104,7 +104,7 @@ class ConfdInotifyEventHandler(pyinotify.ProcessEvent):
self.callback = callback
self.mask = pyinotify.EventsCodes.IN_IGNORED | \
pyinotify.EventsCodes.IN_MODIFY
- self.file = file
+ self.file = filename
self.watch_handle = None
def enable(self):
--
GitLab