Commit 785d142e authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

LUVerifyCluster: Fix bug with offline nodes

 * Other Notes
   - NOTICE: 1 offline node(s) found.
 * Hooks Results
Failure: command execution error:
iteration over non-sequence

Commit a0c9776a

 introduced an error simulation mode to LUVerifyCluster.
Due to a small mistake, offline nodes weren't skipped when checking the
results of verification hooks and iterating over None raises an
“iteration over non-sequence” error.
Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarIustin Pop <>
parent 26751075
......@@ -1603,7 +1603,8 @@ class LUVerifyCluster(LogicalUnit):
test = msg and not res.offline
self._ErrorIf(test, self.ENODEHOOKS, node_name,
"Communication failure in hooks execution: %s", msg)
if test:
if res.offline:
# No need to investigate payload if node is offline.
# override manually lu_result here as _ErrorIf only
# overrides self.bad
lu_result = 1
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment