Skip to content
Snippets Groups Projects
Commit 32f88ce7 authored by Helga Velroyen's avatar Helga Velroyen
Browse files

Correction of design doc regarding RPC extension


This corrects the storage types design doc regarding the specification
of the RPC call.

Signed-off-by: default avatarHelga Velroyen <helgav@google.com>
Reviewed-by: default avatarBernardo dal Seno <bdalseno@google.com>
parent 4a4697de
No related branches found
No related tags found
No related merge requests found
...@@ -160,15 +160,15 @@ RPC changes ...@@ -160,15 +160,15 @@ RPC changes
----------- -----------
The noded RPC call that reports node storage space will be changed to The noded RPC call that reports node storage space will be changed to
accept a list of <disktemplate>,<key> string tuples. For each of them, it will accept a list of <storage_type>,<key> string tuples. For each of them, it will
report the free amount of storage space found on storage <key> as known report the free amount of storage space found on storage <key> as known
by the requested disk template. Depending on the disk template, the key would by the requested storage_type. Depending on the storage_type, the key would
be a volume group name, in case of lvm-based disk templates, a directory name be a volume group name in case of lvm, a directory name for the file-based
for the file and shared file storage, and a rados pool name for rados storage. storage, and a rados pool name for rados storage.
Masterd will know through the mapping of disk templates to storage types which Masterd will know through the mapping of storage types to storage calculation
storage type uses which mechanism for storage calculation and invoke only the functions which storage type uses which mechanism for storage calculation
needed ones. and invoke only the needed ones.
Note that for file and sharedfile the node knows which directories are allowed Note that for file and sharedfile the node knows which directories are allowed
and won't allow any other directory to be queried for security reasons. The and won't allow any other directory to be queried for security reasons. The
...@@ -269,8 +269,8 @@ But the ``node info`` call contains the value of the ...@@ -269,8 +269,8 @@ But the ``node info`` call contains the value of the
``exclusive_storage`` flag, which is currently only meaningful for the ``exclusive_storage`` flag, which is currently only meaningful for the
LVM storage type. Additional flags like the ``exclusive_storage`` flag LVM storage type. Additional flags like the ``exclusive_storage`` flag
for lvm might be useful for other disk templates / storage types as well. for lvm might be useful for other disk templates / storage types as well.
We therefore extend the RPC call with <disktemplate>,<key> to We therefore extend the RPC call with <storage_type>,<key> to
<disktemplate>,<key>,<params> to include any disk-template-specific <storage_type>,<key>,[<param>] to include any disk-template-specific
(or storage-type specific) parameters in the RPC call. (or storage-type specific) parameters in the RPC call.
The reporting of free spindles, also part of Partitioned Ganeti, is not The reporting of free spindles, also part of Partitioned Ganeti, is not
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment