Rather than specifying None in needed_locks every time, with a nice
comment saying to read what we mean rather than what we write, and that
None actually means All, in our magic world, we'll hide this secret
under the ALL_SET constant in the locking module, which has value, you
guessed it, None. After that we'll substitute all usage in cmdlib.

Some comments and examples have been fixed as well.

Reviewed-by: iustinp

SplitTime didn't round the same on different platforms. This patch changes
it to use microseconds and not care about rounding.

Reviewed-by: iustinp

This is not nice, removing it :)

Please use 'set nobomb' in your vi init file.

Reviewed-by: ultrotter

All the users of _GetWantedNodes have been converted to be concurrent
LUs, and thus cannot call this function with an empty list of nodes
anymore. This patch makes this restriction a part of the function
itself. This prevents mistakes in new concurrent LUs, and creates more
work for new non-concurrent LUs, which we shouldn't add anyway.

Reviewed-by: iustinp

Reviewed-by: iustinp

Reviewed-by: iustinp

It turns out this fields was already mandatory. If it hadn't beed valid,
in fact, a value of None would have been passed to _GetWantedNodes which
would have thrown an exception.

Reviewed-by: iustinp

Parallel opcodes are not (yet?) supported for chaining. Turns out
though that chaining is used only four times in the code, and twice it's
for querying exports. But what's the need to chain the full opcode, when
the simple call_export_list rpc is going to provide the same result?

Reviewed-by: iustinp

Reviewed-by: iustinp

Use a default vnc_bind_address if None is specified

Reviewed-by: iustinp

Implement more options for gnt-backup import

Reviewed-by: ultrotter

Add more fields to gnt-instance list

Reviewed-by: imsnah

Fix wrong wording of instance rename error message.

Reviewed-by: imsnah

Document behaviour of gnt-instance console for HVM

Reviewed-by: imsnah

Implement interactive instance OS reinstall.

Reviewed-by: ultrotter

more information for VNC console port

Reviewed-by: ultrotter

Allow access to HVM serial console

Reviewed-by: imsnah

Display VNC console port in gnt-instance info.


Reviewed-by: iustinp

Check HVM device type on instance modify as well.

Reviewed-by: imsnah

With this change when a user asks for a new memory size for an instance,
the number is checked instead of just applied. The operation fails only
if the instance would not be able to restart on its primary node, but
generates warnings should it be impossible to failover the instance or
should the computation be impossible due to nodes being unreachable.

This is a forward-port from branches/ganeti-1.2

Original-Reviewed-by: iustinp
Reviewed-by: iustinp

It was already allowed in gnt-instance modify, but ignored.
It will be used to force skipping parameter checks.

This is a forward-port from branches/ganeti-1.2

Original-Reviewed-by: imsnah
Reviewed-by: iustinp

Add HVM device type flag 4/4

Reviewed-by: ultrotter

Add HVM device type flags 3/4

Reviewed-by: ultrotter

Add HVM device type flags 2/3

Reviewed-by: ultrotter

Reported by Iustin.

It used to return this:
>>> utils.SplitTime(1234.999999999999)
(1234, 1000)

while it should've returned this:
>>> utils.SplitTime(1234.999999999999)
(1235, 0)

Reviewed-by: ultrotter

Add HVM device type flags 1/4

Reviewed-by: ultrotter

doc fix: Describe default values for HVM instance options & cleanup.

Reviewed-by: iustinp

Clarify cluster IP requirement.

Reviewed-by: iustinp

This patch alters the WaitForJobChanges luxi-RPC call to have a
configurable timeout, so that the call behaves nicely with long jobs
that have no update.

We do this by adding a timeout parameter in the RPC call, and returning
a special constant when the timeout is reached without an update. The
luxi client will repeatedly call the WaitForJobChanges until it gets a
real change. The timeout is hardcoded as half the RWTO value.

The patch also removes an unused variable (new_state) from the
WaitForJobChanges method.

Reviewed-by: imsnah,ultrotter

Fix gnt-instance modify for HVM parameters

This patch makes gnt-instance modify work again for the advanced
HVM parameters after it was broken by other changes.


Reviewed-by: ultrotter

Reviewed-by: imsnah

Reported by Iustin.

Reviewed-by: iustinp

By design if an empty list of locks is acquired from a set, no locks are
acquired, and thus release() cannot be called on the set. On the other
hand if None is passed instead of the list, the whole set is acquired,
and must later be released. When acquiring whole empty sets, a release
must happen too, because the set-lock is acquired.

Since we used to overwrite the required locks (needed_locks) with the
acquired ones, we weren't able to distinguish the two cases (empty list
of locks required, and all locks required, but an empty list returned
because the set is empty). Valid solutions include:
  (1) forbidding the acquire of empty lists of locks
  (2) skipping the acquire/release on empty lists of locks
  (3) separating the to-acquire and the acquired list

This patch implements the third approach, and thus LUs will find
acquired locks in the acquired_locks dict, rather than in needed_locks.
The LUs which used this feature before have been updated. This makes it
easier because it doesn't force LUs to do more checks on corner cases,
which are easily forgettable (1) and allows more flexibility if we want
LUs to release (part-of) the locks (which is still a possibly scary
operation, but anyway). This easily combines with (2) should we choose
to implement it.

Reviewed-by: imsnah

A job should only exist once in memory. After the cache is cleaned,
there can still be references to a job somewhere else. If there
are multiple instances, one can get updated while a function is
waiting for changes on another instance. By using
weakref.WeakValueDictionary, which automatically removes instances as
soon as there are no strong references to it anymore, we can solve
this problem.

Reviewed-by: iustinp

Reviewed-by: ultrotter

It can be confusing otherwise.

Reviewed-by: ultrotter

This is a result of the log timestamp changes.

Reviewed-by: imsnah

Seems noone ran a burnin lately :)

Reviwed-by: amischenko,ultrotter

This is a large patch, but I can't figure out how to split it without
breaking stuff. The old way of getting messages by always getting the
last one didn't bring all messages to the client if they were added
too fast, thereby making commands like “gnt-cluster verify” less than
useful. These changes now introduce some sort a serial number per
log entry to keep track what message a client already received. They
also remove the log lock per opcode to make reading log entries thread
safe.

Reviewed-by: ultrotter

This gives continous output instead it being buffered.

Reviewed-by: ultrotter