Commit fc84cd5d authored by Guido Trotter's avatar Guido Trotter
Browse files

kvm: make qmp connections more robust

Currently qmp fails at connect() time if there are socket errors. (eg.
if the instance was started without qmp). Add some better checking.

Also in the only place where we use it avoid hiding the error connecting
to the socket as a failure to read the password file.

In addition one variable is renamed because its name now conflicts with
the newly imported stat module.
Signed-off-by: default avatarGuido Trotter <>
Reviewed-by: default avatarIustin Pop <>
parent eb93b673
......@@ -35,6 +35,7 @@ import struct
import fcntl
import shutil
import socket
import stat
import StringIO
import affinity # pylint: disable=F0401
......@@ -226,6 +227,19 @@ class QmpConnection:
self._connected = False
self._buf = ""
def _check_socket(self):
sock_stat = None
sock_stat = os.stat(self.monitor_filename)
except EnvironmentError, err:
if err.errno == errno.ENOENT:
raise errors.HypervisorError("No qmp socket found")
raise errors.HypervisorError("Error checking qmp socket: %s",
if not stat.S_ISSOCK(sock_stat.st_mode):
raise errors.HypervisorError("Qmp socket is not a socket")
def _check_connection(self):
"""Make sure that the connection is established.
......@@ -244,7 +258,16 @@ class QmpConnection:
@raise errors.ProgrammerError: when there are data serialization errors
if self._connected:
raise errors.ProgrammerError("Cannot connect twice")
# Check file existance/stuff
except EnvironmentError:
raise errors.HypervisorError("Can't connect to qmp socket")
self._connected = True
# Check if we receive a correct greeting message from the server
......@@ -890,10 +913,10 @@ class KVMHypervisor(hv_base.BaseHypervisor):
return None
_, memory, vcpus = self._InstancePidInfo(pid)
stat = "---b-"
istat = "---b-"
times = "0"
return (instance_name, pid, memory, vcpus, stat, times)
return (instance_name, pid, memory, vcpus, istat, times)
def GetAllInstancesInfo(self):
"""Get properties of all instances.
......@@ -1433,19 +1456,21 @@ class KVMHypervisor(hv_base.BaseHypervisor):
# for connection.
spice_password_file = conf_hvp[constants.HV_KVM_SPICE_PASSWORD_FILE]
if spice_password_file:
spice_pwd = ""
spice_pwd = utils.ReadOneLineFile(spice_password_file, strict=True)
qmp = QmpConnection(self._InstanceQmpMonitor(
arguments = {
"protocol": "spice",
"password": spice_pwd,
qmp.Execute("set_password", arguments)
except EnvironmentError, err:
raise errors.HypervisorError("Failed to open SPICE password file %s: %s"
% (spice_password_file, err))
qmp = QmpConnection(self._InstanceQmpMonitor(
arguments = {
"protocol": "spice",
"password": spice_pwd,
qmp.Execute("set_password", arguments)
for filename in temp_files:
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment