Commit f965260c authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

gnt-instance info: Return static info if node offline

Before this patch “gnt-instance info” would fail with the error message
“Error checking node $node: Node is marked offline” if the instance's
primary node is marked offline and the user didn't explicitely request
static information only. With this patch the LU will automatically
return static information if the instance's primary node is marked

Some explicit loops are changed to map().
Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarIustin Pop <>
parent 3b61ee44
......@@ -985,7 +985,7 @@ def _FormatLogicalID(dev_type, logical_id, roman):
return data
def _FormatBlockDevInfo(idx, top_level, dev, static, roman):
def _FormatBlockDevInfo(idx, top_level, dev, roman):
"""Show block device information.
This is only used by L{ShowInstanceConfig}, but it's too big to be
......@@ -997,9 +997,6 @@ def _FormatBlockDevInfo(idx, top_level, dev, static, roman):
@param top_level: if this a top-level disk?
@type dev: dict
@param dev: dictionary with disk information
@type static: boolean
@param static: wheter the device information doesn't contain
runtime information but only static data
@type roman: boolean
@param roman: whether to try to use roman integers
@return: a list of either strings, tuples or lists
......@@ -1087,15 +1084,17 @@ def _FormatBlockDevInfo(idx, top_level, dev, static, roman):
elif dev["physical_id"] is not None:
if not static:
if dev["pstatus"]:
data.append(("on primary", helper(dev["dev_type"], dev["pstatus"])))
if dev["sstatus"] and not static:
if dev["sstatus"]:
data.append(("on secondary", helper(dev["dev_type"], dev["sstatus"])))
if dev["children"]:
data.append("child devices:")
for c_idx, child in enumerate(dev["children"]):
data.append(_FormatBlockDevInfo(c_idx, False, child, static, roman))
data.append(_FormatBlockDevInfo(c_idx, False, child, roman))
return d1
......@@ -1169,7 +1168,7 @@ def ShowInstanceConfig(opts, args):
buf.write("Creation time: %s\n" % utils.FormatTime(instance["ctime"]))
buf.write("Modification time: %s\n" % utils.FormatTime(instance["mtime"]))
buf.write("State: configured to be %s" % instance["config_state"])
if not opts.static:
if instance["run_state"]:
buf.write(", actual state is %s" % instance["run_state"])
##buf.write("Considered for memory checks in cluster verify: %s\n" %
......@@ -1223,7 +1222,7 @@ def ShowInstanceConfig(opts, args):
buf.write(" Disks:\n")
for idx, device in enumerate(instance["disks"]):
_FormatList(buf, _FormatBlockDevInfo(idx, True, device, opts.static,
_FormatList(buf, _FormatBlockDevInfo(idx, True, device,
opts.roman_integers), 2)
......@@ -10199,8 +10199,9 @@ class LUInstanceQueryData(NoHooksLU):
dev_sstatus = self._ComputeBlockdevStatus(snode,, dev)
if dev.children:
dev_children = [self._ComputeDiskStatus(instance, snode, child)
for child in dev.children]
dev_children = map(compat.partial(self._ComputeDiskStatus,
instance, snode),
dev_children = []
......@@ -10223,7 +10224,15 @@ class LUInstanceQueryData(NoHooksLU):
cluster = self.cfg.GetClusterInfo()
for instance in self.wanted_instances:
if not self.op.static:
pnode = self.cfg.GetNodeInfo(instance.primary_node)
if self.op.static or pnode.offline:
remote_state = None
if pnode.offline:
self.LogWarning("Primary node %s is marked offline, returning static"
" information only for instance %s" %
remote_info = self.rpc.call_instance_info(instance.primary_node,,
......@@ -10233,15 +10242,14 @@ class LUInstanceQueryData(NoHooksLU):
remote_state = "up"
remote_state = "down"
remote_state = None
if instance.admin_up:
config_state = "up"
config_state = "down"
disks = [self._ComputeDiskStatus(instance, None, device)
for device in instance.disks]
disks = map(compat.partial(self._ComputeDiskStatus, instance, None),
result[] = {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment