Commit f4d377e7 authored by Iustin Pop's avatar Iustin Pop
Browse files

Make backend._GetVGInfo check the validity of 'vgs'

Currently, the function backend._GetVGInfo only checks for errors via
the exit code of the 'vgs' command. However, there are other ways of
failure so we need to also check for valid output before parsing.

Furthermore, the checks on the exit code were reported via a 'raise
LVMError', however this exception is not handled anywhere and so the
remote caller will not get reasonable data.

This patch does two main things:
  - change the calling protocol for this function to not raise an error,
    and instead return the same type of argument always (dict) with the
    requested keys but values changed into None; this allows in the
    parent rpc call node_info to have valid memory information but
    "error" value for disk space, if there's an error with disks
  - check the validity of the output so that in case we fail to parse
    it, we don't abort with a backtrace in the node daemon but instead
    return the default result value (containing errors), and log these
    cases in the node daemon log file

We also bump the protocol version to 11.

Reviewed-by: ultrotter
parent 8d75db10
......@@ -491,20 +491,32 @@ def _GetVGInfo(vg_name):
vg_free is the free size of the volume group in MiB
pv_count are the number of physical disks in that vg
If an error occurs during gathering of data, we return the same dict
with keys all set to None.
retdic = dict.fromkeys(["vg_size", "vg_free", "pv_count"])
retval = utils.RunCmd(["vgs", "-ovg_size,vg_free,pv_count", "--noheadings",
"--nosuffix", "--units=m", "--separator=:", vg_name])
if retval.failed:
errmsg = "volume group %s not present" % vg_name
raise errors.LVMError(errmsg)
return retdic
valarr = retval.stdout.strip().split(':')
retdic = {
"vg_size": int(round(float(valarr[0]), 0)),
"vg_free": int(round(float(valarr[1]), 0)),
"pv_count": int(valarr[2]),
if len(valarr) == 3:
retdic = {
"vg_size": int(round(float(valarr[0]), 0)),
"vg_free": int(round(float(valarr[1]), 0)),
"pv_count": int(valarr[2]),
except ValueError, err:
logger.Error("Fail to parse vgs output: %s" % str(err))
logger.Error("vgs output has the wrong number of fields (expected"
" three): %s" % str(valarr))
return retdic
......@@ -25,7 +25,7 @@ from ganeti import _autoconf
# various versions
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment