Skip to content
Snippets Groups Projects
Commit f3196d68 authored by Helga Velroyen's avatar Helga Velroyen Committed by Iustin Pop
Browse files

Fix lint error about too many variables


Lint complains about too many variables in the CheckPrereq
method. While I think that this method/class would need
some refactoring in general, at least this patch makes lint
shut up for now.

Signed-off-by: default avatarHelga Velroyen <helgav@google.com>
Reviewed-by: default avatarMichele Tartara <mtartara@google.com>
Signed-off-by: default avatarIustin Pop <iustin@google.com>
parent 7309e7b6
No related branches found
No related tags found
No related merge requests found
...@@ -13346,11 +13346,11 @@ class LUInstanceSetParams(LogicalUnit): ...@@ -13346,11 +13346,11 @@ class LUInstanceSetParams(LogicalUnit):
res_min = _ComputeIPolicyInstanceSpecViolation(ipolicy, ispec_min) res_min = _ComputeIPolicyInstanceSpecViolation(ipolicy, ispec_min)
   
if (res_max or res_min): if (res_max or res_min):
res = set(res_max + res_min)
# FIXME: Improve error message by including information about whether # FIXME: Improve error message by including information about whether
# the upper or lower limit of the parameter fails the ipolicy. # the upper or lower limit of the parameter fails the ipolicy.
msg = ("Instance allocation to group %s (%s) violates policy: %s" % msg = ("Instance allocation to group %s (%s) violates policy: %s" %
(group_info, group_info.name, utils.CommaJoin(res))) (group_info, group_info.name,
utils.CommaJoin(set(res_max + res_min))))
raise errors.OpPrereqError(msg, errors.ECODE_INVAL) raise errors.OpPrereqError(msg, errors.ECODE_INVAL)
   
def _ConvertPlainToDrbd(self, feedback_fn): def _ConvertPlainToDrbd(self, feedback_fn):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment