Commit e2be81cf authored by Guido Trotter's avatar Guido Trotter
Browse files

Implement timers in confd

Timers are used both for checking for inotify failures, and for polling,
should inotify notices become too frequent.
Signed-off-by: default avatarGuido Trotter <>
Reviewed-by: default avatarMichael Hanselmann <>
parent 84c3ab28
......@@ -32,6 +32,7 @@ import logging
import asyncore
import socket
import pyinotify
import time
from optparse import OptionParser
......@@ -191,20 +192,29 @@ class ConfdConfigurationReloader(object):
check, to verify that the reload hasn't failed.
def __init__(self, reader):
def __init__(self, reader, mainloop):
"""Constructor for ConfdConfigurationReloader
@type reader: L{ssconf.SimpleConfigReader}
@param reader: ganeti-confd SimpleConfigReader
@type mainloop: L{daemon.Mainloop}
@param mainloop: ganeti-confd mainloop
self.reader = reader
self.mainloop = mainloop
self.polling = False
self.last_notification = 0
# Asyncronous inotify handler for config changes
self.wm = pyinotify.WatchManager()
self.inotify_handler = ConfdInotifyEventHandler(self.wm, self.OnInotify)
self.notifier = AsyncNotifier(self.wm, self.inotify_handler)
self.timer_handle = None
def OnInotify(self, notifier_enabled):
"""Receive an inotify notification.
......@@ -212,7 +222,17 @@ class ConfdConfigurationReloader(object):
@param notifier_enabled: whether the notifier is still enabled
if not notifier_enabled:
current_time = time.time()
time_delta = current_time - self.last_notification
self.last_notification = current_time
if time_delta < constants.CONFD_CONFIG_RELOAD_RATELIMIT:
logging.debug("Moving from inotify mode to polling mode")
self.polling = True
if notifier_enabled:
if not self.polling and not notifier_enabled:
except errors.InotifyError:
......@@ -229,6 +249,56 @@ class ConfdConfigurationReloader(object):
# to quit.
raise errors.ConfdFatalError(err)
# Reset the timer. If we're polling it will go to the polling rate, if
# we're not it will delay it again to its base safe timeout.
def _DisableTimer(self):
if self.timer_handle is not None:
self.timer_handle = None
def _EnableTimer(self):
if self.polling:
if self.timer_handle is None:
self.timer_handle = self.mainloop.scheduler.enter(
timeout, 1, self.OnTimer, [])
def OnTimer(self):
"""Function called when the timer fires
self.timer_handle = None
reloaded = self.reader.Reload()
except errors.ConfigurationError:
# transform a ConfigurationError in a fatal error, that will cause confd
# to quit.
raise errors.ConfdFatalError(err)
if self.polling and reloaded:"Reloaded ganeti config")
elif reloaded:
# We have reloaded the config files, but received no inotify event. If
# an event is pending though, we just happen to have timed out before
# receiving it, so this is not a problem, and we shouldn't alert
if not self.notifier.check_events():
logging.warning("Config file reload at timeout (inotify failure)")
elif self.polling:
# We're polling, but we haven't reloaded the config:
# Going back to inotify mode
logging.debug("Moving from polling mode to inotify mode")
self.polling = False
logging.debug("Performed configuration check")
def CheckConfd(options, args):
......@@ -258,7 +328,7 @@ def ExecConfd(options, args):
server = ConfdAsyncUDPServer(options.bind_address, options.port, processor)
# Configuration reloader
reloader = ConfdConfigurationReloader(reader)
reloader = ConfdConfigurationReloader(reader, mainloop)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment