Commit db859c7d authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

check-python-code: Detect old-style pylint disable-msg lines

Commit b459a848

 was supposed to replace all, but one was missed. Add a
check to autotools/check-python-code.
Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
Reviewed-by: default avatarAndrea Spadaccini <spadaccio@google.com>
parent 5b49ed09
#!/bin/bash
#
# Copyright (C) 2009 Google Inc.
# Copyright (C) 2009, 2011 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
......@@ -20,6 +20,9 @@
set -e
# Ensure the checks always use the same locale
export LC_ALL=C
readonly maxlinelen=$(for ((i=0; i<81; ++i)); do echo -n .; done)
if [[ "${#maxlinelen}" != 81 ]]; then
......@@ -58,6 +61,13 @@ for script; do
let ++problems
echo "Longest line in $script is longer than 80 characters" >&2
fi
if grep -n -H -E -i \
'#.*\bpylint[[:space:]]*:[[:space:]]*disable-msg\b' "$script"
then
let ++problems
echo "Found old-style pylint disable pragma in $script" >&2
fi
done
if [[ "$problems" -gt 0 ]]; then
......
......@@ -28,7 +28,7 @@ import tempfile
import shutil
try:
# pylint: disable-msg=E0611
# pylint: disable=E0611
from pyinotify import pyinotify
except ImportError:
import pyinotify
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment