Commit d755483c authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

Fail if node/group evacuation can't evacuate instances

If an instance can't be evacuated, only a message would be printed. With
this change the operation always aborts. Newly added unittests check for
this behaviour.
Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarIustin Pop <>
parent fb2865ae
......@@ -10285,9 +10285,10 @@ def _LoadNodeEvacResult(lu, alloc_result, early_release, use_nodes):
(moved, failed, jobs) = alloc_result
if failed:
lu.LogWarning("Unable to evacuate instances %s",
utils.CommaJoin("%s (%s)" % (name, reason)
for (name, reason) in failed))
failreason = utils.CommaJoin("%s (%s)" % (name, reason)
for (name, reason) in failed)
lu.LogWarning("Unable to evacuate instances %s", failreason)
raise errors.OpExecError("Unable to evacuate instances %s" % failreason)
if moved:
lu.LogInfo("Instances to be moved: %s",
......@@ -28,6 +28,7 @@ import time
import tempfile
import shutil
import operator
import itertools
from ganeti import constants
from ganeti import mcpu
......@@ -363,5 +364,71 @@ class TestClusterVerifyFiles(unittest.TestCase):
class _FakeLU:
def __init__(self):
self.warning_log = []
self.info_log = []
def LogWarning(self, text, *args):
self.warning_log.append((text, args))
def LogInfo(self, text, *args):
self.info_log.append((text, args))
class TestLoadNodeEvacResult(unittest.TestCase):
def testSuccess(self):
for moved in [[], [
("", "grp2", ["nodeA4509", "nodeB2912"]),
for early_release in [False, True]:
for use_nodes in [False, True]:
jobs = [
alloc_result = (moved, [], jobs)
assert cmdlib.IAllocator._NEVAC_RESULT(alloc_result)
lu = _FakeLU()
result = cmdlib._LoadNodeEvacResult(lu, alloc_result,
early_release, use_nodes)
if moved:
(_, (info_args, )) = lu.info_log.pop(0)
for (instname, instgroup, instnodes) in moved:
self.assertTrue(instname in info_args)
if use_nodes:
for i in instnodes:
self.assertTrue(i in info_args)
self.assertTrue(instgroup in info_args)
for op in itertools.chain(*result):
if hasattr(op.__class__, "early_release"):
self.assertEqual(op.early_release, early_release)
self.assertFalse(hasattr(op, "early_release"))
def testFailed(self):
alloc_result = ([], [
("", "errormsg21178"),
], [])
assert cmdlib.IAllocator._NEVAC_RESULT(alloc_result)
lu = _FakeLU()
self.assertRaises(errors.OpExecError, cmdlib._LoadNodeEvacResult,
lu, alloc_result, False, False)
(_, (args, )) = lu.warning_log.pop(0)
self.assertTrue("" in args)
self.assertTrue("errormsg21178" in args)
if __name__ == "__main__":
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment